Change extension detection mechanism #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the extension detection mechanism to check if the extension binary is present locally. Also, moves calls to extension outside of root trace span.
Motivation
Currently, checking for the datadog extension is done by attempting to open a tcp connection to the extension's endpoints on localhost. When the extension is present this request will fail. This has the side effect of generating an error span in our trace on cold starts. Instead, we swap to checking for access to the extension file first, before making the tcp connection.
The second change we make is to call extension methods, (including flush), outside of the main trace. This reduces the noise in the trace, and means the trace can now be flushed on the same invocation that created it.
Testing Guidelines
Updated integration tests, and added unit tests.
Additional Notes
Types of Changes
Check all that apply