Fix requests patching edge case #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 87.65% 87.95% +0.30%
==========================================
Files 29 29
Lines 972 980 +8
Branches 169 169
==========================================
+ Hits 852 862 +10
+ Misses 82 81 -1
+ Partials 38 37 -1
Continue to review full report at Codecov.
|
nhinsch
reviewed
Jan 11, 2021
|
|
||
| if (isIntegrationTest()) { | ||
| _logHttpRequest(requestOpts); | ||
| if (arg3 === undefined || arg3 === null) { |
There was a problem hiding this comment.
I would add a comment here explaining why this is necessary
nhinsch
reviewed
Jan 11, 2021
| options = { ...options, ...arg2 }; | ||
|
|
||
| let requestOpts: http.RequestOptions | undefined; | ||
| if (typeof arg1 === "string" || arg1 instanceof URL) { |
There was a problem hiding this comment.
Likewise I might add comments here to describe the different cases
nhinsch
approved these changes
Jan 11, 2021
Czechh
added a commit
that referenced
this pull request
Jan 11, 2021
* main: Bump version to 3.42.0 Fix requests patching edge case (#146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the x-ray only http patching behavior, to account for broken case.
Motivation
Issue #134
Testing Guidelines
In addition to the new test cases, I've tested this manually in a lambda and verified the request was able to complete correctly.
Additional Notes
Types of Changes
Check all that apply