Skip to content

Fix use of deprecated Buffer constructor #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Replaces deprecated buffer constructor use with Buffer.from method

Motivation

Issue #168

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner February 26, 2021 15:57
@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #169 (0635ad5) into main (5d1d7e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          31       31           
  Lines        1203     1203           
  Branches      236      236           
=======================================
  Hits         1041     1041           
  Misses        106      106           
  Partials       56       56           
Impacted Files Coverage Δ
src/trace/context.ts 90.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1d7e0...0635ad5. Read the comment docs.

@DarcyRaynerDD DarcyRaynerDD merged commit e889384 into main Feb 26, 2021
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-buffer-alloc branch February 26, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants