Skip to content

feat: Tag payloads even if there's no status code due to non HTTP fun… #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Oct 5, 2021

…ction invoke.

What does this PR do?

This ensures functions which don't set a status code can still have payloads automatically captured:
image

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner October 5, 2021 16:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #230 (565de8d) into main (9dbfca7) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   87.65%   87.89%   +0.24%     
==========================================
  Files          32       32              
  Lines        1231     1231              
  Branches      249      249              
==========================================
+ Hits         1079     1082       +3     
+ Misses         91       88       -3     
  Partials       61       61              
Impacted Files Coverage Δ
src/index.ts 77.87% <0.00%> (ø)
src/trace/listener.ts 88.73% <0.00%> (+1.40%) ⬆️
src/trace/tracer-wrapper.ts 93.75% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbfca7...565de8d. Read the comment docs.

@astuyve astuyve merged commit 32e2348 into main Oct 5, 2021
@astuyve astuyve deleted the aj/tag-object-even-if-not-http-span branch October 5, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants