Skip to content

Document how to apply the wrapper in code #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

tianchu
Copy link
Contributor

@tianchu tianchu commented Nov 17, 2021

What does this PR do?

Document how to apply the wrapper in code

Motivation

We have encountered a few cases (very rare though) where people have good reasons not being able to redirect the handler, but must apply the wrapper in code. Let's document it.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@tianchu tianchu requested a review from a team as a code owner November 17, 2021 14:28
@codecov-commenter
Copy link

Codecov Report

Merging #246 (53ac038) into main (86bf652) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          35       35           
  Lines        1335     1335           
  Branches      283      283           
=======================================
  Hits         1115     1115           
  Misses        196      196           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bf652...53ac038. Read the comment docs.

@tianchu tianchu merged commit d2e40f0 into main Nov 17, 2021
@tianchu tianchu deleted the tian.chu/document-applying-wrapper-in-code branch November 17, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants