Inferred spans for Lambda function URLs #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… infer the span correctly
…eted span on invocation finish
… follows command pattern. Update imports
…e attributes for JS
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 83.52% 83.13% -0.39%
==========================================
Files 35 36 +1
Lines 1335 1399 +64
Branches 283 295 +12
==========================================
+ Hits 1115 1163 +48
- Misses 196 209 +13
- Partials 24 27 +3
Continue to review full report at Codecov.
|
hghotra
reviewed
Nov 19, 2021
Comment on lines
+29
to
+30
| "span.type": "http", | ||
| "resource.name": domain + path, |
hghotra
reviewed
Nov 19, 2021
|
Yup! My bad, this was not supposed to be in the change list
…On Fri, Nov 19, 2021, 2:55 PM Harvinder Ghotra ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/trace/listener.ts
<#247 (comment)>
:
> @@ -147,8 +159,12 @@ export class TraceListener {
...this.stepFunctionContext,
};
}
-
- if (parentSpanContext !== null) {
+ if (this.inferredSpan !== (null || undefined)) {
Is there a reason for writing it this way? This basically reduces to:
this.inferredSpan !== undefined
Perhaps, it should just be:
⬇️ Suggested change
- if (this.inferredSpan !== (null || undefined)) {
+ if (this.inferredSpan) {
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#247 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMGISL4XLAIL25KIPFVGSLUM22TXANCNFSM5IM4STQQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Co-authored-by: Harvinder Ghotra <[email protected]>
astuyve
pushed a commit
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports inferred spans for lambda function URLs
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply