Skip to content

Fix xray trace metadata segment creation #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Respects X-Ray sampling decisions, and doesn't attempt to send a subsegment to x-ray when the whole trace has been sampled out.

Motivation

Prevents sending unwanted segments to x-ray.

Testing Guidelines

I've tested this manually, and create a test.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner November 22, 2021 20:25
@DarcyRaynerDD DarcyRaynerDD changed the title Fix xray trace creation Fix xray trace metadata segment creation Nov 22, 2021
@DarcyRaynerDD DarcyRaynerDD merged commit efc319d into main Nov 22, 2021
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-xray-trace-creation branch November 22, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants