Span Inferrer: Fix path for API Gateway V1

[hpetru]

What does this PR do?

This Pull Request fixes the span inferrer for API Gateway V1 events.

Motivation

Because of this bug, resources are not shown right in DataDog API Gateway service.

Testing Guidelines

I wrote a until test which replicates the bug.

Additional Notes

Looks like this problem happens only for API Gateway V1, but I also added an additional test case for API Gateway V2 just to make sure that my changes are not breaking something V2 related.

Types of Changes

• Bug fix
• New feature
• Breaking change
• Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

• This PR's description is comprehensive
• This PR contains breaking changes that are documented in the description
• This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
• This PR impacts documentation, and it has been updated (or a ticket has been logged)
• This PR's changes are covered by the automated tests
• This PR collects user input/sensitive content into Datadog
• This PR passes the integration tests (ask a Datadog member to run the tests)

[hpetru]

@astuyve Please take a look and let me know if anything else is needed to get this bug fix merged and a new version released.

[astuyve]

Thanks so much for the PR @hpetru - the code looks good, re-reading my PR I think I just missed this mid-refactor, so I appreciate your contribution!

Please run yarn lint and re-push, I'll re-run the specs and then cut a new release.

[codecov-commenter]

Codecov Report

Merging #262 (f31d9bf) into main (5bd4206) will increase coverage by 0.49%.
The diff coverage is 100.00%.

❗ Current head f31d9bf differs from pull request most recent head c8c49e6. Consider uploading reports for the commit c8c49e6 to get more accurate results

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   82.26%   82.75%   +0.49%     
==========================================
  Files          37       37              
  Lines        1618     1618              
  Branches      349      349              
==========================================
+ Hits         1331     1339       +8     
+ Misses        238      231       -7     
+ Partials       49       48       -1     

Impacted Files	Coverage Δ
src/trace/span-inferrer.ts	90.84% <100.00%> (+5.22%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd4206...c8c49e6. Read the comment docs.

[astuyve]

Hi @hpetru - the integration tests might be tricky to update for you as you'll need both a DD API key as well as an available AWS account.

I'll merge your branch into one of my own, update the tests, and merge that PR, which should solve this. Thanks again for your contribution!!

[astuyve]

This has been released to 5.71.0! We don't adhere to semver here as we keep the minor version in sync with the lambda layer version available on AWS. Unfortunately AWS doesn't allow semver for lambda layers. v71 is also published in all regions for all runtimes.

https://github.com/DataDog/datadog-lambda-js/releases/tag/v5.71.0

[hpetru]

@astuyve I'm afraid that the right change here should be:

const path = event.rawPath || event.requestContext.resourcePath || event.requestContext.routeKey;

[astuyve]

Hmm, I see. In our tests they were equivalent, is that not the case in your app? Can you show me the difference in your payload?
https://github.com/DataDog/datadog-lambda-js/blob/main/event_samples/api-gateway-v1.json#L67
https://github.com/DataDog/datadog-lambda-js/blob/main/event_samples/api-gateway-v1.json#L73