Skip to content

fix: Wrap logError in conditional for isAgentRunning, as this is now the agent's responsibility #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 14, 2022

What does this PR do?

Use logDebug instead of logError if the Agent (extension) is running. The API key is required there, not by this library (unless we are using the forwarder and sending metrics to the backend from this library)

Motivation

Fixes DataDog/serverless-plugin-datadog#237

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner March 14, 2022 19:55
@codecov-commenter
Copy link

Codecov Report

Merging #273 (42f89c3) into main (300ef85) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files          37       37           
  Lines        1630     1630           
  Branches      354      354           
=======================================
  Hits         1348     1348           
  Misses        234      234           
  Partials       48       48           
Impacted Files Coverage Δ
src/metrics/listener.ts 87.65% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@hghotra hghotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 'datadog:api key not configured' when using apiKeySecretArn
3 participants