Skip to content

feat: Release inferred spans for function URLs #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 4, 2022

What does this PR do?

Adds support for Lambda Function URLs

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner April 4, 2022 17:03
@astuyve astuyve requested a review from hghotra April 4, 2022 17:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #278 (1567a70) into main (aa00fd0) will decrease coverage by 0.15%.
The diff coverage is 73.52%.

❗ Current head 1567a70 differs from pull request most recent head 7432efd. Consider uploading reports for the commit 7432efd to get more accurate results

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   82.69%   82.54%   -0.16%     
==========================================
  Files          37       37              
  Lines        1630     1661      +31     
  Branches      354      364      +10     
==========================================
+ Hits         1348     1371      +23     
- Misses        234      237       +3     
- Partials       48       53       +5     
Impacted Files Coverage Δ
src/utils/event-type-guards.ts 97.50% <50.00%> (-2.50%) ⬇️
src/trace/span-inferrer.ts 88.88% <70.00%> (-2.03%) ⬇️
src/trace/trigger.ts 87.01% <83.33%> (-0.32%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@hghotra hghotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@astuyve astuyve merged commit 50a1b24 into main Apr 6, 2022
@astuyve astuyve deleted the aj/function-urls branch April 6, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants