Skip to content

Move span pointer to inferred span; add env var to toggle span pointers #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Jan 16, 2025

What does this PR do?

  1. Adds an env var DD_TRACE_AWS_ADD_SPAN_POINTERS to toggle span pointers
  2. Put span pointers on inferred (root) span instead of the lambda (child) span, as discussed in Slack.
  3. Wrap span.addSpanPointers with try/catch, since span is of type any.

Note that moving the location of the span pointer has no actual effect on the functionality and requires no changes on the UI side. As long as a span is found with a matching hash, span pointers work. Since the spans are on the same trace, this has no noticeable change for our users. This change just aligns span pointers with bottlecap (universally instrumented) runtimes.

Motivation

Testing Guidelines

Manual testing. The span links are now on the root (inferred) span.
Screenshot 2025-01-16 at 10 39 48 AM

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston mentioned this pull request Jan 16, 2025
11 tasks
@nhulston nhulston marked this pull request as ready for review January 16, 2025 17:39
@nhulston nhulston requested a review from a team as a code owner January 16, 2025 17:39
@nhulston nhulston marked this pull request as draft January 16, 2025 17:39
@nhulston nhulston marked this pull request as ready for review January 30, 2025 15:00
@nhulston nhulston merged commit 142439e into main Jan 30, 2025
30 checks passed
@nhulston nhulston deleted the nicholas.hulston/span-pointer-updates branch January 30, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants