Fix getEnhancedMetricTags on local env #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 90.01% 90.22% +0.21%
==========================================
Files 26 26
Lines 841 839 -2
Branches 142 141 -1
==========================================
Hits 757 757
+ Misses 55 54 -1
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
jeromemacias
force-pushed
the
enhanced_metrics_local
branch
from
14ddbdc to
7867f8b
Compare
hghotra
approved these changes
Aug 19, 2020
src/metrics/enhanced-metrics.spec.ts
Outdated
| @@ -64,6 +65,7 @@ describe("getEnhancedMetricTags", () => { | |||
| mockedGetProcessVersion.mockReturnValue("v8.10.0"); | |||
| expect(getEnhancedMetricTags(mockContextLocal)).toStrictEqual([ | |||
| "functionname:my-test-lambda", | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes usage of wrapper in local env, where
functionArncontext is not set.See this comment : 4bb170c#r41043013