Skip to content

Update condition for setting dd parent source #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2020

Conversation

hghotra
Copy link
Contributor

@hghotra hghotra commented Aug 15, 2020

What does this PR do?

This PR fixes a bug in Node Layer 26 which sets _dd.parent_source to xray for some edge cases which causes forwarder to ignore the traces. As a result, traces do not show up in Datadog.

Motivation

https://datadoghq.atlassian.net/browse/SLS-681

Testing Guidelines

  • Ran integration tests
  • Manually tested function

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@hghotra hghotra requested a review from a team as a code owner August 15, 2020 13:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   89.88%   90.01%   +0.13%     
==========================================
  Files          26       26              
  Lines         840      841       +1     
  Branches      141      142       +1     
==========================================
+ Hits          755      757       +2     
  Misses         55       55              
+ Partials       30       29       -1     
Impacted Files Coverage Δ
src/trace/listener.ts 91.80% <100.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffef30...119112b. Read the comment docs.

Copy link
Contributor

@Czechh Czechh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @hghotra - this LGTM.

@hghotra hghotra merged commit 8ab3c90 into master Aug 15, 2020
@hghotra hghotra deleted the hsg/sls-681/node-layer-26-fix branch August 15, 2020 15:08
Czechh added a commit that referenced this pull request Aug 18, 2020
* master:
  Update condition for setting dd parent source (#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants