Skip to content

Fix incorrect parent id of aws.lambda span #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

Fix incorrect parent id of aws.lambda span #115

merged 1 commit into from
Feb 19, 2021

Conversation

tianchu
Copy link
Collaborator

@tianchu tianchu commented Feb 19, 2021 •
edited
Loading

What does this PR do?

Similar to DataDog/datadog-lambda-js#166. Fix the incorrect parent id of the aws.lambda span when there is a trace context from the incoming event.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@tianchu tianchu requested a review from a team as a code owner February 19, 2021 19:32
@tianchu tianchu force-pushed the tian.chu/fix-incorrect-parent-id branch from 6e183e0 to 3b6fd4a Compare February 19, 2021 19:34
DarcyRaynerDD
DarcyRaynerDD approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianchu tianchu merged commit aff4771 into main Feb 19, 2021
@tianchu tianchu deleted the tian.chu/fix-incorrect-parent-id branch February 19, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarcyRaynerDD DarcyRaynerDD DarcyRaynerDD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianchu @DarcyRaynerDD