Skip to content

Handle datetime parameter for historical custom metrics submitted to the API #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

DylanLovesCoffee
Copy link
Contributor

What does this PR do?

We should allow datetime parameters passed to lambda_metric() when using ThreadStats

Motivation

Came up in support issue where a type error was raised

Testing Guidelines

Unit test

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner August 5, 2024 17:16
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix ints/2-byte size diff and you're good

@DylanLovesCoffee DylanLovesCoffee merged commit 8ac32ed into main Aug 8, 2024
51 checks passed
@DylanLovesCoffee DylanLovesCoffee deleted the dylan/datettime-metrics branch August 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants