-
Notifications
You must be signed in to change notification settings - Fork 46
Step Functions Legacy Lambda Span Linking #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/test_tracing.py
Outdated
@@ -647,6 +648,33 @@ def test_step_function_trace_data(self): | |||
expected_context, | |||
) | |||
|
|||
def test_is_legacy_lambda_step_function(self): | |||
sqs_event = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it doesn't matter much, but do we want to use the name sqs_event
when we've written this for Step Functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I just copied this over from another test
Will update this
What does this PR do?
Step Function events that are from Legacy Lambda enter the layer wrapped in a
Payload: {}
. Here's an exampleThis change will check if events fall into this case and parse them accordingly so that we can extract the trace context and infer a span link between the Step Function and the downstream Legacy Lambda
Motivation
https://github.com/DataDog/logs-backend/pull/78707
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply