Skip to content

feat: [SVLS-5677] DynamoDB Stream event span pointers #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Oct 16, 2024

What does this PR do?

Adds Span Pointers for Lambdas triggered by DynamoDB stream events.

Testing Guidelines

Unit tests. Also checked with a live test lambda.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@apiarian-datadog
Copy link
Contributor Author

Will update the PR once dd-trace-py 2.15.0 is actually released (probably next week)

@apiarian-datadog
Copy link
Contributor Author

Confirmed that this works as expected and creates usable links with a live test lambda

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5677-dynamodb-event-pointers branch from 03a6393 to 540f173 Compare October 30, 2024 15:35
@apiarian-datadog apiarian-datadog marked this pull request as ready for review October 30, 2024 15:45
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner October 30, 2024 15:45
Copy link
Contributor

@nhulston nhulston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just left a few small comments

@apiarian-datadog apiarian-datadog merged commit 02cc8c6 into main Oct 30, 2024
51 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5677-dynamodb-event-pointers branch October 30, 2024 19:17
avedmala added a commit that referenced this pull request Nov 18, 2024
* add logic to extract traceID from _datadog header

* rename test

* fix type

* added root arn case

* trigger ci

* Add `http.route` tags for API Gateway (#524)

Add route tags

* feat: [SVLS-5677] DynamoDB Stream event span pointers (#522)

* trigger ci

* use default propagator.extract

* lint

* lint

* updated to use trace/parent hash from _datadog

* lint

* skip is context complete check

* remove unused import

* fix legacy lambda parsing with new header

* using context object instead of pre-hashed values

* fixed trigger tags and tests

* pull sfn trace id generation out into a helper

* added unit tests

* update test data

* rename stepfunctions to states

* update current serverless version to v1

* Update trigger comment

Co-authored-by: kimi <[email protected]>

---------

Co-authored-by: Nicholas Hulston <[email protected]>
Co-authored-by: Aleksandr Pasechnik <[email protected]>
Co-authored-by: kimi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants