-
Notifications
You must be signed in to change notification settings - Fork 46
feat: [SVLS-5677] DynamoDB Stream event span pointers #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
apiarian-datadog
merged 8 commits into
main
from
aleksandr.pasechnik/svls-5677-dynamodb-event-pointers
Oct 30, 2024
Merged
feat: [SVLS-5677] DynamoDB Stream event span pointers #522
apiarian-datadog
merged 8 commits into
main
from
aleksandr.pasechnik/svls-5677-dynamodb-event-pointers
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will update the PR once |
Confirmed that this works as expected and creates usable links with a live test lambda |
…ding dd-trace-py from source
03a6393
to
540f173
Compare
nhulston
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just left a few small comments
duncanista
reviewed
Oct 30, 2024
avedmala
pushed a commit
that referenced
this pull request
Oct 30, 2024
avedmala
added a commit
that referenced
this pull request
Nov 18, 2024
* add logic to extract traceID from _datadog header * rename test * fix type * added root arn case * trigger ci * Add `http.route` tags for API Gateway (#524) Add route tags * feat: [SVLS-5677] DynamoDB Stream event span pointers (#522) * trigger ci * use default propagator.extract * lint * lint * updated to use trace/parent hash from _datadog * lint * skip is context complete check * remove unused import * fix legacy lambda parsing with new header * using context object instead of pre-hashed values * fixed trigger tags and tests * pull sfn trace id generation out into a helper * added unit tests * update test data * rename stepfunctions to states * update current serverless version to v1 * Update trigger comment Co-authored-by: kimi <[email protected]> --------- Co-authored-by: Nicholas Hulston <[email protected]> Co-authored-by: Aleksandr Pasechnik <[email protected]> Co-authored-by: kimi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Span Pointers for Lambdas triggered by DynamoDB stream events.
Testing Guidelines
Unit tests. Also checked with a live test lambda.
Types of Changes
Check all that apply