-
Notifications
You must be signed in to change notification settings - Fork 46
chore: support python 3.13 #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support python 3.13 #544
Conversation
This isn't ready since Python 3.13 isn't supported by the |
@@ -61,7 +61,7 @@ function docker_build_zip { | |||
# between different python runtimes. | |||
temp_dir=$(mktemp -d) | |||
docker buildx build -t datadog-lambda-python-${arch}:$1 . --no-cache \ | |||
--build-arg image=python:$1 \ | |||
--build-arg image=public.ecr.aws/docker/library/python:$1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we kept hitting rate limit errors from dockerhub, so we're switching to the public aws ecr instead.
3af3a80
to
8d1de37
Compare
the diff between the integration test snapshots for python 3.12 and 3.13 don't show any interesting differences, just notes that one of them is using python 3.12 and the other is using python 3.13. |
dd-trace-py with Python 3.13 support got released some days ago, see https://github.com/DataDog/dd-trace-py/releases/tag/v2.19.0 |
@dbast thanks for the reminder! i'll re-test our layer but since python 3.13 support in 2.19.0 is still somewhat experimental, we're planning to wait for the 2.20.0 release for actually releasing this change. |
8d1de37
to
3766511
Compare
dd-trace-py v2.20.0 was released |
3766511
to
cc4d20d
Compare
no significant differences between the new python 3.13 integration test output files and their analogous python 3.12 versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, please make sure you create the equivalent changes necessary in self-monitoring so this runs on 3.13 on the core stacks: extension, fullinstrument, baseline, etc.
c52baed
to
9b2bb87
Compare
What does this PR do?
Adding Python 3.13 support.
Testing Guidelines
Unit tests, integration tests, and self-monitoring checks.
Motivation
SVLS-6020
Types of Changes
Check all that apply