-
Notifications
You must be signed in to change notification settings - Fork 46
use ddtrace.auto since patch_all is being deprecated #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f08fd55
to
0cbdd58
Compare
0cbdd58
to
27b8d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change also require us to update the support ddtrace version? We're currently pinning to >=2.17.0
Integration tests are failing with
|
Also seeing |
Since ddtrace.auto starts all the products I'm just going to wait till we actually deprecate patch_all, then we can switch to using the internal patch_all method here. Alternatively ddtrace.auto could be used and we'd have to set the proper envars to disable certain products and probably change some logic in tracing.py. |
@ZStriker19 I'm seeing this in a Python lambda using version 69 of the datadog extension and 105 of the Python layer (3.12) |
What does this PR do?
Replaces the instrumentation mechanism of patch_all() with import ddtrace.auto, since patch_all is being deprecated
Motivation
DataDog/dd-trace-py#11918
Testing Guidelines
We'd just hope everything still works as expected
Additional Notes
Types of Changes
Check all that apply