DatadogLogs - Add Device's Brand, Name, and Model in LogEvent
#1672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
In the current logging implementation, we haven't automatically include device's brand, name, and model.
It is possible to add it manually by adding
device-model
in Global Attributes, as mentioned in this doc: https://docs.datadoghq.com/logs/log_collection/ios/?tab=cocoapods#global-attributesHowever, as user in #1489 mentioned, it would be nice if the SDK add the device's model automatically.
Resolve #1489
How?
A brief description of implementation details of this PR.
Review checklist
Custom CI job configuration (optional)
tools/