feat(logs): Add global log attributes #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to specify global attributes for a log on a given Core by using `Logs.addAttribute` and `Logs.removeAttribute`. refs: RUM-3069
Adds logs added with Logs.addAttribute to the crash context, and sends them in the attributes when the crash is logged. Add integration test for global log attributes. refs: RUM-3069
fuzzybinary
force-pushed
the
jward/RUM-3069-global-logs
branch
from
8eb55c5 to
7abfdcc
Compare
Datadog ReportBranch report: ✅ 0 Failed, 2579 Passed, 0 Skipped, 23m 21.52s Wall Time 🔻 Code Coverage Decreases vs Default Branch (8)
|
fuzzybinary
force-pushed
the
jward/RUM-3069-global-logs
branch
from
775b9e5 to
68621cb
Compare
ncreated
requested changes
Mar 11, 2024
DatadogCrashReporting/Sources/CrashContext/CrashContextProvider.swift
Outdated
Show resolved
Hide resolved
Comment on lines
1272
to
1275
| INFOPLIST_FILE = Runner/Info.plist; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
| LD_RUNPATH_SEARCH_PATHS = ( | ||
| "$(inherited)", |
There was a problem hiding this comment.
blocking/ The IPHONEOS_DEPLOYMENT_TARGET should be managed through local Base.local.xcconfig which is git-ignored. Let's remove all changes to this file 🙏, otherwise this is dropping iOS 11 in CI.
Comment on lines
59
to
60
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| selectedDebuggerIdentifier = "" | ||
| selectedLauncherIdentifier = "Xcode.IDEFoundation.Launcher.PosixSpawn" |
There was a problem hiding this comment.
question/ Not sure on these changes - they do not look necessary.
There was a problem hiding this comment.
Hrm, yeah, probably just some changes from when I was testing crashes. I'll revert them.
Co-authored-by: Maciek Grzybowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds the ability to specify global attributes for a log on a given Core by using
Logs.addAttributeandLogs.removeAttribute.refs: RUM-3069
Review checklist
Custom CI job configuration (optional)
tools/