Skip to content

Extend app launch handler to macCatalyst and visionOS #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Hengyu
Copy link

@Hengyu Hengyu commented Jun 8, 2024

What and why?

We can have app launch info on macCatalyst platform and visionOS platform

How?

Use #macro to gate platforms

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@Hengyu Hengyu requested review from a team as code owners June 8, 2024 05:29
@ncreated ncreated changed the base branch from develop to ncreated/merge-hengyu-enhance-macro-usage- September 3, 2024 09:22
@ncreated
Copy link
Member

ncreated commented Sep 3, 2024

Thanks @Hengyu 👋. We will take it over from here and merge to internal branch for CI and QA.

@ncreated ncreated merged commit c3c9d1f into DataDog:ncreated/merge-hengyu-enhance-macro-usage- Sep 3, 2024
5 of 6 checks passed
ncreated added a commit that referenced this pull request Sep 3, 2024
ncreated added a commit that referenced this pull request Sep 3, 2024
@Hengyu
Copy link
Author

Hengyu commented Sep 4, 2024

Thanks a lot @ncreated

@MaelNamNam
Copy link
Contributor

Hi @Hengyu 👋 Thanks fro your contribution! We just released this in version 2.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants