You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is essentially reverting #1567. Assumption made was wrong. We can expect view that from the wireframe perspective have a different root view (it can be done by fully covering the root with nontransparent view, which will remove the root during flattening process).
The reverted code was fixing some minor edge cases in React Native, although it has a serious penalty of creating double fullsnapshots in others.
Review checklist
Feature or bugfix MUST have appropriate tests (unit, integration)
Make sure each commit and the PR mention the Issue number or JIRA reference
Add CHANGELOG entry for user facing changes
Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)
2024-12-18 15:13:20 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2024-12-18 16:33:46 UTC ℹ️ MergeQueue: merge request added to the queue
The median merge time in develop is 28m.
2024-12-18 17:30:45 UTC 🚨 MergeQueue: This merge request is in error
mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:
target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
2024-12-18 17:32:44 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2024-12-18 18:03:11 UTC ℹ️ MergeQueue: merge request added to the queue
The median merge time in develop is 28m.
2024-12-18 18:29:56 UTC ℹ️ MergeQueue: This merge request was merged
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxep
force-pushed
the
maciey/RUM-7205/double-full-snapshot-bug
branch
from
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
What and why?
This PR is essentially reverting #1567. Assumption made was wrong. We can expect view that from the wireframe perspective have a different root view (it can be done by fully covering the root with nontransparent view, which will remove the root during flattening process).
The reverted code was fixing some minor edge cases in React Native, although it has a serious penalty of creating double fullsnapshots in others.
Review checklist
make api-surface)