Skip to content

Commit ea65fd8

Browse files
author
Cecile Terpin
committed
add comments
1 parent c1a7978 commit ea65fd8

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public final class ConfigDefaults {
6969
static final boolean DEFAULT_DB_CLIENT_HOST_SPLIT_BY_INSTANCE_TYPE_SUFFIX = false;
7070
static final boolean DEFAULT_DB_CLIENT_HOST_SPLIT_BY_HOST = false;
7171
static final String DEFAULT_DB_DBM_PROPAGATION_MODE_MODE = "disabled";
72+
// Default value is set to -1, it disables the latency trace interceptor
7273
static final int DEFAULT_TRACE_LATENCY_INTERCEPTOR_VALUE = -1;
7374
static final int DEFAULT_SCOPE_DEPTH_LIMIT = 100;
7475
static final int DEFAULT_SCOPE_ITERATION_KEEP_ALIVE = 30; // in seconds

dd-trace-api/src/main/java/datadog/trace/api/config/TracerConfig.java

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public final class TracerConfig {
7373
public static final String TRACE_HTTP_CLIENT_ERROR_STATUSES = "trace.http.client.error.statuses";
7474

7575
public static final String SPLIT_BY_TAGS = "trace.split-by-tags";
76+
// trace latency interceptor value should be in ms
7677
public static final String TRACE_LATENCY_INTERCEPTOR_VALUE = "trace.latency.interceptor.value";
7778
public static final String SCOPE_DEPTH_LIMIT = "trace.scope.depth.limit";
7879
public static final String SCOPE_STRICT_MODE = "trace.scope.strict.mode";

dd-trace-core/src/main/java/datadog/trace/core/traceinterceptor/LatencyTraceInterceptor.java

+10
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,16 @@
99
import org.slf4j.Logger;
1010
import org.slf4j.LoggerFactory;
1111

12+
// This trace latency interceptor is disabled by default.
13+
// We can activate it by setting the value of dd.trace.latency.interceptor.value to a positive value
14+
// This value should be in milliseconds and this interceptor will retain any local trace who has a
15+
// root
16+
// span duration greater than this value.
17+
// The activation of this interceptor is ignored if partial flush is enabled.
18+
// Note that since we're changing the sampling priority at the end of local trace, there is no
19+
// guarantee to get complete traces,
20+
// since the original sampling priority for this trace may have been already propagated.
21+
1222
public class LatencyTraceInterceptor extends AbstractTraceInterceptor {
1323
private static final Logger log = LoggerFactory.getLogger(LatencyTraceInterceptor.class);
1424
// duration configured in ms, need to be converted in nano seconds

dd-trace-core/src/test/groovy/datadog/trace/core/traceinterceptor/LatencyTraceInterceptorTest.groovy

-2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,4 @@ class LatencyTraceInterceptorTest extends DDCoreSpecification {
4545
"false" | "200" | DDTags.MANUAL_KEEP | 300 | 2
4646
"false" | "200" | DDTags.MANUAL_DROP | 300 | 2
4747
}
48-
49-
5048
}

0 commit comments

Comments
 (0)