-
Notifications
You must be signed in to change notification settings - Fork 303
Improve code analysis workflow #7543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049756
Total [baseline] (10.31 s) : 0, 10310004
Agent [candidate] (1.046 s) : 0, 1046243
Total [candidate] (10.344 s) : 0, 10344012
section appsec
Agent [baseline] (1.181 s) : 0, 1181205
Total [baseline] (10.576 s) : 0, 10575623
Agent [candidate] (1.189 s) : 0, 1189020
Total [candidate] (10.603 s) : 0, 10602745
section iast
Agent [baseline] (1.175 s) : 0, 1174596
Total [baseline] (10.865 s) : 0, 10864766
Agent [candidate] (1.195 s) : 0, 1195338
Total [candidate] (10.934 s) : 0, 10934461
section profiling
Agent [baseline] (1.245 s) : 0, 1245074
Total [baseline] (10.622 s) : 0, 10621966
Agent [candidate] (1.255 s) : 0, 1255007
Total [candidate] (10.664 s) : 0, 10663932
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.785 ms) : 0, 669785
BytebuddyAgent [candidate] (667.141 ms) : 0, 667141
GlobalTracer [baseline] (306.59 ms) : 0, 306590
GlobalTracer [candidate] (306.143 ms) : 0, 306143
AppSec [baseline] (51.659 ms) : 0, 51659
AppSec [candidate] (51.267 ms) : 0, 51267
Remote Config [baseline] (669.342 µs) : 0, 669
Remote Config [candidate] (664.309 µs) : 0, 664
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.488 ms) : 0, 7488
section appsec
BytebuddyAgent [baseline] (688.723 ms) : 0, 688723
BytebuddyAgent [candidate] (693.212 ms) : 0, 693212
GlobalTracer [baseline] (299.81 ms) : 0, 299810
GlobalTracer [candidate] (301.991 ms) : 0, 301991
AppSec [baseline] (158.713 ms) : 0, 158713
AppSec [candidate] (160.412 ms) : 0, 160412
IAST [baseline] (20.456 ms) : 0, 20456
IAST [candidate] (19.85 ms) : 0, 19850
Remote Config [baseline] (612.34 µs) : 0, 612
Remote Config [candidate] (618.76 µs) : 0, 619
Telemetry [baseline] (9.6 ms) : 0, 9600
Telemetry [candidate] (9.207 ms) : 0, 9207
section iast
BytebuddyAgent [baseline] (780.802 ms) : 0, 780802
BytebuddyAgent [candidate] (794.262 ms) : 0, 794262
GlobalTracer [baseline] (296.151 ms) : 0, 296151
GlobalTracer [candidate] (301.387 ms) : 0, 301387
AppSec [baseline] (53.521 ms) : 0, 53521
AppSec [candidate] (53.725 ms) : 0, 53725
IAST [baseline] (22.638 ms) : 0, 22638
IAST [candidate] (24.031 ms) : 0, 24031
Remote Config [baseline] (580.287 µs) : 0, 580
Remote Config [candidate] (613.853 µs) : 0, 614
Telemetry [baseline] (7.323 ms) : 0, 7323
Telemetry [candidate] (7.545 ms) : 0, 7545
section profiling
BytebuddyAgent [baseline] (662.339 ms) : 0, 662339
BytebuddyAgent [candidate] (668.715 ms) : 0, 668715
GlobalTracer [baseline] (388.993 ms) : 0, 388993
GlobalTracer [candidate] (391.389 ms) : 0, 391389
AppSec [baseline] (51.769 ms) : 0, 51769
AppSec [candidate] (52.364 ms) : 0, 52364
Remote Config [baseline] (690.051 µs) : 0, 690
Remote Config [candidate] (686.014 µs) : 0, 686
Telemetry [baseline] (7.346 ms) : 0, 7346
Telemetry [candidate] (7.426 ms) : 0, 7426
ProfilingAgent [baseline] (96.184 ms) : 0, 96184
ProfilingAgent [candidate] (96.425 ms) : 0, 96425
Profiling [baseline] (96.207 ms) : 0, 96207
Profiling [candidate] (96.449 ms) : 0, 96449
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051167
Total [baseline] (8.516 s) : 0, 8516352
Agent [candidate] (1.051 s) : 0, 1051322
Total [candidate] (8.512 s) : 0, 8511687
section iast
Agent [baseline] (1.178 s) : 0, 1177873
Total [baseline] (9.04 s) : 0, 9040393
Agent [candidate] (1.175 s) : 0, 1175196
Total [candidate] (8.968 s) : 0, 8968253
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1181794
Total [baseline] (8.973 s) : 0, 8973486
Agent [candidate] (1.173 s) : 0, 1173248
Total [candidate] (8.956 s) : 0, 8956187
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170223
Total [baseline] (8.961 s) : 0, 8961491
Agent [candidate] (1.167 s) : 0, 1167297
Total [candidate] (8.961 s) : 0, 8960791
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.596 ms) : 0, 669596
BytebuddyAgent [candidate] (670.278 ms) : 0, 670278
GlobalTracer [baseline] (308.408 ms) : 0, 308408
GlobalTracer [candidate] (307.734 ms) : 0, 307734
AppSec [baseline] (51.466 ms) : 0, 51466
AppSec [candidate] (51.529 ms) : 0, 51529
Remote Config [baseline] (669.264 µs) : 0, 669
Remote Config [candidate] (680.106 µs) : 0, 680
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.493 ms) : 0, 7493
section iast
BytebuddyAgent [baseline] (781.98 ms) : 0, 781980
BytebuddyAgent [candidate] (781.042 ms) : 0, 781042
GlobalTracer [baseline] (297.771 ms) : 0, 297771
GlobalTracer [candidate] (296.158 ms) : 0, 296158
AppSec [baseline] (53.0 ms) : 0, 53000
AppSec [candidate] (50.795 ms) : 0, 50795
IAST [baseline] (21.365 ms) : 0, 21365
IAST [candidate] (24.945 ms) : 0, 24945
Remote Config [baseline] (593.394 µs) : 0, 593
Remote Config [candidate] (582.614 µs) : 0, 583
Telemetry [baseline] (9.566 ms) : 0, 9566
Telemetry [candidate] (8.038 ms) : 0, 8038
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.528 ms) : 0, 785528
BytebuddyAgent [candidate] (779.609 ms) : 0, 779609
GlobalTracer [baseline] (297.827 ms) : 0, 297827
GlobalTracer [candidate] (295.888 ms) : 0, 295888
AppSec [baseline] (54.452 ms) : 0, 54452
AppSec [candidate] (52.663 ms) : 0, 52663
IAST [baseline] (22.261 ms) : 0, 22261
IAST [candidate] (22.012 ms) : 0, 22012
Remote Config [baseline] (586.456 µs) : 0, 586
Remote Config [candidate] (589.792 µs) : 0, 590
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (8.852 ms) : 0, 8852
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.494 ms) : 0, 777494
BytebuddyAgent [candidate] (775.418 ms) : 0, 775418
GlobalTracer [baseline] (295.436 ms) : 0, 295436
GlobalTracer [candidate] (295.422 ms) : 0, 295422
AppSec [baseline] (53.596 ms) : 0, 53596
AppSec [candidate] (52.427 ms) : 0, 52427
IAST [baseline] (21.526 ms) : 0, 21526
IAST [candidate] (22.75 ms) : 0, 22750
Remote Config [baseline] (581.492 µs) : 0, 581
Remote Config [candidate] (576.838 µs) : 0, 577
Telemetry [baseline] (7.986 ms) : 0, 7986
Telemetry [candidate] (7.122 ms) : 0, 7122
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section baseline
no_agent (373.188 µs) : 354, 393
. : milestone, 373,
iast (489.075 µs) : 467, 511
. : milestone, 489,
iast_FULL (551.043 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (519.622 µs) : 497, 543
. : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (492.37 µs) : 469, 515
. : milestone, 492,
iast_INACTIVE (451.801 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (474.251 µs) : 452, 497
. : milestone, 474,
tracing (442.328 µs) : 422, 462
. : milestone, 442,
section candidate
no_agent (372.269 µs) : 353, 392
. : milestone, 372,
iast (485.887 µs) : 464, 508
. : milestone, 486,
iast_FULL (555.683 µs) : 535, 577
. : milestone, 556,
iast_GLOBAL (511.411 µs) : 490, 533
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (484.777 µs) : 463, 506
. : milestone, 485,
iast_INACTIVE (453.889 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (487.076 µs) : 464, 510
. : milestone, 487,
tracing (448.01 µs) : 428, 468
. : milestone, 448,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1369
. : milestone, 1349,
appsec (1.73 ms) : 1707, 1754
. : milestone, 1730,
appsec_no_iast (1.733 ms) : 1709, 1756
. : milestone, 1733,
iast (1.486 ms) : 1464, 1509
. : milestone, 1486,
profiling (1.473 ms) : 1450, 1496
. : milestone, 1473,
tracing (1.465 ms) : 1440, 1489
. : milestone, 1465,
section candidate
no_agent (1.352 ms) : 1333, 1371
. : milestone, 1352,
appsec (1.708 ms) : 1683, 1732
. : milestone, 1708,
appsec_no_iast (1.717 ms) : 1692, 1742
. : milestone, 1717,
iast (1.485 ms) : 1463, 1507
. : milestone, 1485,
profiling (1.555 ms) : 1530, 1580
. : milestone, 1555,
tracing (1.465 ms) : 1440, 1490
. : milestone, 1465,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1467
. : milestone, 1456,
appsec (2.225 ms) : 2190, 2260
. : milestone, 2225,
iast (1.969 ms) : 1926, 2011
. : milestone, 1969,
iast_GLOBAL (2.024 ms) : 1980, 2067
. : milestone, 2024,
profiling (1.855 ms) : 1821, 1888
. : milestone, 1855,
tracing (1.838 ms) : 1805, 1871
. : milestone, 1838,
section candidate
no_agent (1.457 ms) : 1446, 1469
. : milestone, 1457,
appsec (2.223 ms) : 2188, 2257
. : milestone, 2223,
iast (1.984 ms) : 1940, 2028
. : milestone, 1984,
iast_GLOBAL (2.022 ms) : 1978, 2066
. : milestone, 2022,
profiling (1.846 ms) : 1813, 1879
. : milestone, 1846,
tracing (1.835 ms) : 1803, 1868
. : milestone, 1835,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7af6fda049, baseline=1.39.0-SNAPSHOT~dd52c8116b
dateFormat X
axisFormat %s
section baseline
no_agent (15.309 s) : 15309000, 15309000
. : milestone, 15309000,
appsec (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
iast (18.803 s) : 18803000, 18803000
. : milestone, 18803000,
iast_GLOBAL (17.967 s) : 17967000, 17967000
. : milestone, 17967000,
profiling (15.883 s) : 15883000, 15883000
. : milestone, 15883000,
tracing (15.34 s) : 15340000, 15340000
. : milestone, 15340000,
section candidate
no_agent (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
appsec (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
iast (18.976 s) : 18976000, 18976000
. : milestone, 18976000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
tracing (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
|
b1b96fb
to
9287689
Compare
Add build cache save/restore Disable CodeQL SARIF result upload to Datadog
65a6347
to
7af6fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, beware the PR title typo.
What Does This Do
This PR improves the code analysis workflow by:
Motivation
Improve the Trivy scan time
Remove CodeQL job error
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]