Skip to content

Increase lambda extension request timeout #7986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Increase lambda extension request timeout #7986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-trace-core/src/main/java/datadog/trace/lambda/LambdaHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class LambdaHandler {
private static final String START_INVOCATION = "/lambda/start-invocation";
private static final String END_INVOCATION = "/lambda/end-invocation";

private static final Long REQUEST_TIMEOUT_IN_S = 1L;
private static final Long REQUEST_TIMEOUT_IN_S = 3L;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems really weird that a 1 second timeout wouldn't be enough. Have you been able to reproduce these errors?

If you were able to reproduce the errors, did this change solve it?

Copy link
Contributor Author

@nhulston nhulston Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://datadoghq.atlassian.net/browse/SLES-1952?focusedCommentId=2021461 for more details.

Maybe implementing a retry mechanism would be a better solution, WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solution is fine 😄 Since we've been able to reproduce the error in self monitoring, in a perfect world we would build a layer from this branch and test it out for a bit. But since this change is otherwise harmless, I think just going ahead with it is fine. Though, for the customer's sake, I still think we should test this change out in self monitoring to ensure it indeed fixes the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's a good point. This might solve the problem, but maybe not. We only saw it in self monitoring once every few days, so we'll have to wait a while and see if the messages ever pops up again.

private static final int MAX_IDLE_CONNECTIONS = 5;
private static final Long KEEP_ALIVE_DURATION = 300L;

Expand Down
Loading