-
Notifications
You must be signed in to change notification settings - Fork 303
Refactored requires post-processing flag #8104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092707
Total [baseline] (10.446 s) : 0, 10446171
Agent [candidate] (1.102 s) : 0, 1102061
Total [candidate] (10.471 s) : 0, 10470507
section appsec
Agent [baseline] (1.235 s) : 0, 1234894
Total [baseline] (10.725 s) : 0, 10725333
Agent [candidate] (1.234 s) : 0, 1233783
Total [candidate] (10.701 s) : 0, 10700750
section iast
Agent [baseline] (1.221 s) : 0, 1220505
Total [baseline] (11.009 s) : 0, 11008925
Agent [candidate] (1.22 s) : 0, 1220468
Total [candidate] (10.954 s) : 0, 10953514
section profiling
Agent [baseline] (1.318 s) : 0, 1317972
Total [baseline] (10.816 s) : 0, 10816496
Agent [candidate] (1.321 s) : 0, 1320906
Total [candidate] (10.862 s) : 0, 10861709
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.6 ms) : 0, 695600
BytebuddyAgent [candidate] (701.438 ms) : 0, 701438
GlobalTracer [baseline] (317.53 ms) : 0, 317530
GlobalTracer [candidate] (319.468 ms) : 0, 319468
AppSec [baseline] (54.516 ms) : 0, 54516
AppSec [candidate] (55.015 ms) : 0, 55015
Remote Config [baseline] (674.351 µs) : 0, 674
Remote Config [candidate] (692.323 µs) : 0, 692
Telemetry [baseline] (10.662 ms) : 0, 10662
Telemetry [candidate] (11.571 ms) : 0, 11571
section appsec
BytebuddyAgent [baseline] (718.391 ms) : 0, 718391
BytebuddyAgent [candidate] (718.1 ms) : 0, 718100
GlobalTracer [baseline] (316.549 ms) : 0, 316549
GlobalTracer [candidate] (315.922 ms) : 0, 315922
AppSec [baseline] (167.725 ms) : 0, 167725
AppSec [candidate] (166.836 ms) : 0, 166836
Remote Config [baseline] (644.998 µs) : 0, 645
Remote Config [candidate] (643.938 µs) : 0, 644
Telemetry [baseline] (7.9 ms) : 0, 7900
Telemetry [candidate] (8.596 ms) : 0, 8596
IAST [baseline] (19.776 ms) : 0, 19776
IAST [candidate] (19.686 ms) : 0, 19686
section iast
BytebuddyAgent [baseline] (813.592 ms) : 0, 813592
BytebuddyAgent [candidate] (813.193 ms) : 0, 813193
GlobalTracer [baseline] (305.986 ms) : 0, 305986
GlobalTracer [candidate] (306.326 ms) : 0, 306326
AppSec [baseline] (58.381 ms) : 0, 58381
AppSec [candidate] (58.035 ms) : 0, 58035
Remote Config [baseline] (596.712 µs) : 0, 597
Remote Config [candidate] (618.351 µs) : 0, 618
Telemetry [baseline] (7.344 ms) : 0, 7344
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (20.863 ms) : 0, 20863
IAST [candidate] (21.128 ms) : 0, 21128
section profiling
ProfilingAgent [baseline] (93.662 ms) : 0, 93662
ProfilingAgent [candidate] (93.341 ms) : 0, 93341
BytebuddyAgent [baseline] (689.346 ms) : 0, 689346
BytebuddyAgent [candidate] (691.994 ms) : 0, 691994
GlobalTracer [baseline] (433.68 ms) : 0, 433680
GlobalTracer [candidate] (434.153 ms) : 0, 434153
AppSec [baseline] (53.675 ms) : 0, 53675
AppSec [candidate] (53.756 ms) : 0, 53756
Remote Config [baseline] (663.229 µs) : 0, 663
Remote Config [candidate] (667.474 µs) : 0, 667
Telemetry [baseline] (7.708 ms) : 0, 7708
Telemetry [candidate] (7.684 ms) : 0, 7684
Profiling [baseline] (93.686 ms) : 0, 93686
Profiling [candidate] (93.366 ms) : 0, 93366
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.109 s) : 0, 1108530
Total [baseline] (8.707 s) : 0, 8706537
Agent [candidate] (1.096 s) : 0, 1096062
Total [candidate] (8.64 s) : 0, 8640029
section iast
Agent [baseline] (1.22 s) : 0, 1220184
Total [baseline] (9.206 s) : 0, 9206230
Agent [candidate] (1.222 s) : 0, 1222150
Total [candidate] (9.23 s) : 0, 9229850
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.222 s) : 0, 1222042
Total [baseline] (9.18 s) : 0, 9180262
Agent [candidate] (1.222 s) : 0, 1221775
Total [candidate] (9.167 s) : 0, 9166970
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1218480
Total [baseline] (9.174 s) : 0, 9173517
Agent [candidate] (1.217 s) : 0, 1217255
Total [candidate] (9.182 s) : 0, 9181614
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (706.838 ms) : 0, 706838
BytebuddyAgent [candidate] (697.155 ms) : 0, 697155
GlobalTracer [baseline] (321.437 ms) : 0, 321437
GlobalTracer [candidate] (317.689 ms) : 0, 317689
AppSec [baseline] (54.828 ms) : 0, 54828
AppSec [candidate] (54.714 ms) : 0, 54714
Remote Config [baseline] (680.068 µs) : 0, 680
Remote Config [candidate] (690.754 µs) : 0, 691
Telemetry [baseline] (10.81 ms) : 0, 10810
Telemetry [candidate] (12.015 ms) : 0, 12015
section iast
BytebuddyAgent [baseline] (813.341 ms) : 0, 813341
BytebuddyAgent [candidate] (813.799 ms) : 0, 813799
GlobalTracer [baseline] (306.411 ms) : 0, 306411
GlobalTracer [candidate] (306.778 ms) : 0, 306778
AppSec [baseline] (56.168 ms) : 0, 56168
AppSec [candidate] (57.554 ms) : 0, 57554
IAST [baseline] (22.465 ms) : 0, 22465
IAST [candidate] (22.041 ms) : 0, 22041
Remote Config [baseline] (623.265 µs) : 0, 623
Remote Config [candidate] (625.699 µs) : 0, 626
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.567 ms) : 0, 7567
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (814.458 ms) : 0, 814458
BytebuddyAgent [candidate] (813.308 ms) : 0, 813308
GlobalTracer [baseline] (306.376 ms) : 0, 306376
GlobalTracer [candidate] (307.082 ms) : 0, 307082
AppSec [baseline] (57.298 ms) : 0, 57298
AppSec [candidate] (57.551 ms) : 0, 57551
IAST [baseline] (22.068 ms) : 0, 22068
IAST [candidate] (21.962 ms) : 0, 21962
Remote Config [baseline] (602.326 µs) : 0, 602
Remote Config [candidate] (620.812 µs) : 0, 621
Telemetry [baseline] (7.471 ms) : 0, 7471
Telemetry [candidate] (7.543 ms) : 0, 7543
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.412 ms) : 0, 811412
BytebuddyAgent [candidate] (811.357 ms) : 0, 811357
GlobalTracer [baseline] (306.439 ms) : 0, 306439
GlobalTracer [candidate] (306.144 ms) : 0, 306144
AppSec [baseline] (57.203 ms) : 0, 57203
AppSec [candidate] (57.535 ms) : 0, 57535
IAST [baseline] (21.64 ms) : 0, 21640
IAST [candidate] (20.468 ms) : 0, 20468
Remote Config [baseline] (623.729 µs) : 0, 624
Remote Config [candidate] (622.544 µs) : 0, 623
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.353 ms) : 0, 7353
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1377
. : milestone, 1359,
appsec (1.765 ms) : 1742, 1788
. : milestone, 1765,
appsec_no_iast (1.766 ms) : 1742, 1791
. : milestone, 1766,
iast (1.497 ms) : 1474, 1520
. : milestone, 1497,
profiling (1.513 ms) : 1490, 1535
. : milestone, 1513,
tracing (1.499 ms) : 1474, 1523
. : milestone, 1499,
section candidate
no_agent (1.345 ms) : 1325, 1366
. : milestone, 1345,
appsec (1.753 ms) : 1730, 1776
. : milestone, 1753,
appsec_no_iast (1.757 ms) : 1732, 1782
. : milestone, 1757,
iast (1.507 ms) : 1484, 1530
. : milestone, 1507,
profiling (1.526 ms) : 1503, 1549
. : milestone, 1526,
tracing (1.497 ms) : 1472, 1522
. : milestone, 1497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (375.681 µs) : 355, 397
. : milestone, 376,
iast (500.303 µs) : 479, 522
. : milestone, 500,
iast_FULL (659.179 µs) : 638, 681
. : milestone, 659,
iast_GLOBAL (516.212 µs) : 495, 538
. : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (499.897 µs) : 478, 522
. : milestone, 500,
iast_INACTIVE (454.969 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (490.467 µs) : 468, 513
. : milestone, 490,
tracing (457.116 µs) : 435, 479
. : milestone, 457,
section candidate
no_agent (380.537 µs) : 361, 400
. : milestone, 381,
iast (497.573 µs) : 476, 519
. : milestone, 498,
iast_FULL (658.282 µs) : 636, 681
. : milestone, 658,
iast_GLOBAL (521.027 µs) : 500, 542
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (492.182 µs) : 471, 513
. : milestone, 492,
iast_INACTIVE (454.703 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (487.496 µs) : 466, 509
. : milestone, 487,
tracing (453.34 µs) : 432, 474
. : milestone, 453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.52 s) : 18520000, 18520000
. : milestone, 18520000,
iast_GLOBAL (18.072 s) : 18072000, 18072000
. : milestone, 18072000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
section candidate
no_agent (15.444 s) : 15444000, 15444000
. : milestone, 15444000,
appsec (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
iast (18.825 s) : 18825000, 18825000
. : milestone, 18825000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
profiling (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
tracing (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1b54996ab3, baseline=1.45.0-SNAPSHOT~772d178d64
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.364 ms) : 2322, 2406
. : milestone, 2364,
iast (2.102 ms) : 2049, 2154
. : milestone, 2102,
iast_GLOBAL (2.143 ms) : 2090, 2196
. : milestone, 2143,
profiling (2.003 ms) : 1959, 2047
. : milestone, 2003,
tracing (1.943 ms) : 1902, 1984
. : milestone, 1943,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.362 ms) : 2320, 2404
. : milestone, 2362,
iast (2.11 ms) : 2056, 2164
. : milestone, 2110,
iast_GLOBAL (2.223 ms) : 2165, 2281
. : milestone, 2223,
profiling (1.989 ms) : 1946, 2033
. : milestone, 1989,
tracing (1.905 ms) : 1864, 1945
. : milestone, 1905,
|
smola
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactored
requiresPostProcessing
flag. Now we are able to set post-processing flag fromAppSec
moduleMotivation
This is preparation work for new API Security Sampling
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]