Skip to content

Refactor AgentSpan.Context to be AgentSpanContext #8168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

Refactor AgentSpan.Context to be AgentSpanContext #8168

merged 1 commit into from
Jan 8, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 8, 2025 •
edited by jira bot
Loading

Motivation

Making it a top-level type to reduce confusion with the new generic Context API, and align better with AgentSpanLink

Contributor Checklist

Jira ticket: APMAPI-959

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Jan 8, 2025
@mcculls mcculls force-pushed the mcculls/make-agentspancontext-toplevel-class branch 2 times, most recently from f4eb235 to 15a2be3 Compare January 8, 2025 11:18
@mcculls mcculls marked this pull request as ready for review January 8, 2025 11:18
@mcculls mcculls requested review from a team as code owners January 8, 2025 11:18
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agentspancontext-toplevel-class
git_commit_date 1736340302 1736342521
git_commit_sha 9247ce3 43ee58c
release_version 1.45.0-SNAPSHOT~9247ce3d81 1.45.0-SNAPSHOT~43ee58c3c8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736344824 1736344824
ci_job_id 758436414 758436414
ci_pipeline_id 52433871 52433871
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058593
Total [baseline] (10.579 s) : 0, 10579251
Agent [candidate] (1.063 s) : 0, 1062904
Total [candidate] (10.458 s) : 0, 10458283
section appsec
Agent [baseline] (1.189 s) : 0, 1188991
Total [baseline] (10.706 s) : 0, 10706370
Agent [candidate] (1.188 s) : 0, 1187757
Total [candidate] (10.748 s) : 0, 10748167
section iast
Agent [baseline] (1.182 s) : 0, 1181996
Total [baseline] (11.012 s) : 0, 11012237
Agent [candidate] (1.187 s) : 0, 1187425
Total [candidate] (10.987 s) : 0, 10986818
section profiling
Agent [baseline] (1.274 s) : 0, 1273817
Total [baseline] (10.788 s) : 0, 10787944
Agent [candidate] (1.282 s) : 0, 1281617
Total [candidate] (10.844 s) : 0, 10843824
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.189 s 130.398 ms (12.3%)
Agent iast 1.182 s 123.403 ms (11.7%)
Agent profiling 1.274 s 215.224 ms (20.3%)
Total tracing 10.579 s -
Total appsec 10.706 s 127.119 ms (1.2%)
Total iast 11.012 s 432.986 ms (4.1%)
Total profiling 10.788 s 208.693 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.188 s 124.853 ms (11.7%)
Agent iast 1.187 s 124.521 ms (11.7%)
Agent profiling 1.282 s 218.713 ms (20.6%)
Total tracing 10.458 s -
Total appsec 10.748 s 289.884 ms (2.8%)
Total iast 10.987 s 528.535 ms (5.1%)
Total profiling 10.844 s 385.541 ms (3.7%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.659 ms) : 0, 714659
BytebuddyAgent [candidate] (719.109 ms) : 0, 719109
GlobalTracer [baseline] (256.771 ms) : 0, 256771
GlobalTracer [candidate] (258.367 ms) : 0, 258367
AppSec [baseline] (55.525 ms) : 0, 55525
AppSec [candidate] (55.707 ms) : 0, 55707
Remote Config [baseline] (732.554 µs) : 0, 733
Remote Config [candidate] (729.491 µs) : 0, 729
Telemetry [baseline] (15.91 ms) : 0, 15910
Telemetry [candidate] (13.781 ms) : 0, 13781
section appsec
BytebuddyAgent [baseline] (731.2 ms) : 0, 731200
BytebuddyAgent [candidate] (730.21 ms) : 0, 730210
GlobalTracer [baseline] (253.296 ms) : 0, 253296
GlobalTracer [candidate] (253.088 ms) : 0, 253088
AppSec [baseline] (170.038 ms) : 0, 170038
AppSec [candidate] (169.817 ms) : 0, 169817
Remote Config [baseline] (1.036 ms) : 0, 1036
Remote Config [candidate] (673.379 µs) : 0, 673
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.527 ms) : 0, 8527
IAST [baseline] (20.498 ms) : 0, 20498
IAST [candidate] (20.754 ms) : 0, 20754
section iast
BytebuddyAgent [baseline] (831.044 ms) : 0, 831044
BytebuddyAgent [candidate] (834.577 ms) : 0, 834577
GlobalTracer [baseline] (247.105 ms) : 0, 247105
GlobalTracer [candidate] (248.233 ms) : 0, 248233
AppSec [baseline] (58.093 ms) : 0, 58093
AppSec [candidate] (58.272 ms) : 0, 58272
Remote Config [baseline] (672.87 µs) : 0, 673
Remote Config [candidate] (688.6 µs) : 0, 689
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.855 ms) : 0, 8855
IAST [baseline] (21.274 ms) : 0, 21274
IAST [candidate] (21.757 ms) : 0, 21757
section profiling
ProfilingAgent [baseline] (95.321 ms) : 0, 95321
ProfilingAgent [candidate] (96.28 ms) : 0, 96280
BytebuddyAgent [baseline] (701.811 ms) : 0, 701811
BytebuddyAgent [candidate] (706.911 ms) : 0, 706911
GlobalTracer [baseline] (371.914 ms) : 0, 371914
GlobalTracer [candidate] (373.273 ms) : 0, 373273
AppSec [baseline] (54.166 ms) : 0, 54166
AppSec [candidate] (54.127 ms) : 0, 54127
Remote Config [baseline] (663.167 µs) : 0, 663
Remote Config [candidate] (661.697 µs) : 0, 662
Telemetry [baseline] (8.074 ms) : 0, 8074
Telemetry [candidate] (8.087 ms) : 0, 8087
Profiling [baseline] (95.343 ms) : 0, 95343
Profiling [candidate] (96.304 ms) : 0, 96304
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055032
Total [baseline] (8.625 s) : 0, 8624911
Agent [candidate] (1.052 s) : 0, 1052299
Total [candidate] (8.612 s) : 0, 8611707
section iast
Agent [baseline] (1.182 s) : 0, 1181678
Total [baseline] (9.193 s) : 0, 9192637
Agent [candidate] (1.183 s) : 0, 1183050
Total [candidate] (9.204 s) : 0, 9203840
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1184022
Total [baseline] (9.229 s) : 0, 9228573
Agent [candidate] (1.19 s) : 0, 1189539
Total [candidate] (9.188 s) : 0, 9188385
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1184595
Total [baseline] (9.205 s) : 0, 9204834
Agent [candidate] (1.176 s) : 0, 1176478
Total [candidate] (9.193 s) : 0, 9193377
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.182 s 126.646 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 128.99 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.185 s 129.563 ms (12.3%)
Total tracing 8.625 s -
Total iast 9.193 s 567.726 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.229 s 603.662 ms (7.0%)
Total iast_TELEMETRY_OFF 9.205 s 579.923 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.183 s 130.751 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 137.241 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.176 s 124.179 ms (11.8%)
Total tracing 8.612 s -
Total iast 9.204 s 592.133 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.188 s 576.677 ms (6.7%)
Total iast_TELEMETRY_OFF 9.193 s 581.669 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.016 ms) : 0, 713016
BytebuddyAgent [candidate] (712.033 ms) : 0, 712033
GlobalTracer [baseline] (255.822 ms) : 0, 255822
GlobalTracer [candidate] (255.819 ms) : 0, 255819
AppSec [baseline] (55.267 ms) : 0, 55267
AppSec [candidate] (55.208 ms) : 0, 55208
Remote Config [baseline] (748.884 µs) : 0, 749
Remote Config [candidate] (725.802 µs) : 0, 726
Telemetry [baseline] (15.197 ms) : 0, 15197
Telemetry [candidate] (13.548 ms) : 0, 13548
section iast
BytebuddyAgent [baseline] (830.921 ms) : 0, 830921
BytebuddyAgent [candidate] (831.808 ms) : 0, 831808
GlobalTracer [baseline] (246.9 ms) : 0, 246900
GlobalTracer [candidate] (247.401 ms) : 0, 247401
AppSec [baseline] (58.015 ms) : 0, 58015
AppSec [candidate] (58.322 ms) : 0, 58322
IAST [baseline] (21.399 ms) : 0, 21399
IAST [candidate] (21.06 ms) : 0, 21060
Remote Config [baseline] (676.62 µs) : 0, 677
Remote Config [candidate] (675.094 µs) : 0, 675
Telemetry [baseline] (8.808 ms) : 0, 8808
Telemetry [candidate] (8.752 ms) : 0, 8752
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.394 ms) : 0, 832394
BytebuddyAgent [candidate] (836.158 ms) : 0, 836158
GlobalTracer [baseline] (247.358 ms) : 0, 247358
GlobalTracer [candidate] (248.457 ms) : 0, 248457
AppSec [baseline] (58.362 ms) : 0, 58362
AppSec [candidate] (58.925 ms) : 0, 58925
IAST [baseline] (21.386 ms) : 0, 21386
IAST [candidate] (21.426 ms) : 0, 21426
Remote Config [baseline] (684.293 µs) : 0, 684
Remote Config [candidate] (670.812 µs) : 0, 671
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.765 ms) : 0, 8765
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.261 ms) : 0, 833261
BytebuddyAgent [candidate] (826.613 ms) : 0, 826613
GlobalTracer [baseline] (248.137 ms) : 0, 248137
GlobalTracer [candidate] (246.88 ms) : 0, 246880
AppSec [baseline] (57.947 ms) : 0, 57947
AppSec [candidate] (58.048 ms) : 0, 58048
IAST [baseline] (20.75 ms) : 0, 20750
IAST [candidate] (20.697 ms) : 0, 20697
Remote Config [baseline] (660.642 µs) : 0, 661
Remote Config [candidate] (654.196 µs) : 0, 654
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.561 ms) : 0, 8561
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-08T13:33:00 2025-01-08T13:39:58
git_branch master mcculls/make-agentspancontext-toplevel-class
git_commit_date 1736340302 1736342521
git_commit_sha 9247ce3 43ee58c
release_version 1.45.0-SNAPSHOT~9247ce3d81 1.45.0-SNAPSHOT~43ee58c3c8
start_time 2025-01-08T13:32:47 2025-01-08T13:39:44
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736343950 1736343950
ci_job_id 758436415 758436415
ci_pipeline_id 52433871 52433871
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1381
.   : milestone, 1361,
appsec (1.748 ms) : 1725, 1771
.   : milestone, 1748,
appsec_no_iast (1.748 ms) : 1725, 1771
.   : milestone, 1748,
iast (1.487 ms) : 1463, 1510
.   : milestone, 1487,
profiling (1.558 ms) : 1534, 1582
.   : milestone, 1558,
tracing (1.48 ms) : 1455, 1504
.   : milestone, 1480,
section candidate
no_agent (1.35 ms) : 1330, 1369
.   : milestone, 1350,
appsec (1.733 ms) : 1709, 1757
.   : milestone, 1733,
appsec_no_iast (1.757 ms) : 1734, 1780
.   : milestone, 1757,
iast (1.488 ms) : 1465, 1512
.   : milestone, 1488,
profiling (1.535 ms) : 1511, 1559
.   : milestone, 1535,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.381 ms] -
appsec 1.748 ms [1.725 ms, 1.771 ms] 386.965 µs (28.4%)
appsec_no_iast 1.748 ms [1.725 ms, 1.771 ms] 386.523 µs (28.4%)
iast 1.487 ms [1.463 ms, 1.51 ms] 125.215 µs (9.2%)
profiling 1.558 ms [1.534 ms, 1.582 ms] 196.264 µs (14.4%)
tracing 1.48 ms [1.455 ms, 1.504 ms] 118.21 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.33 ms, 1.369 ms] -
appsec 1.733 ms [1.709 ms, 1.757 ms] 383.305 µs (28.4%)
appsec_no_iast 1.757 ms [1.734 ms, 1.78 ms] 407.347 µs (30.2%)
iast 1.488 ms [1.465 ms, 1.512 ms] 138.825 µs (10.3%)
profiling 1.535 ms [1.511 ms, 1.559 ms] 185.405 µs (13.7%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 130.024 µs (9.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.823 µs) : 355, 395
.   : milestone, 375,
iast (487.073 µs) : 466, 509
.   : milestone, 487,
iast_FULL (641.312 µs) : 620, 663
.   : milestone, 641,
iast_GLOBAL (522.544 µs) : 500, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (483.901 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (451.982 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (485.09 µs) : 463, 507
.   : milestone, 485,
tracing (452.211 µs) : 431, 474
.   : milestone, 452,
section candidate
no_agent (376.382 µs) : 355, 398
.   : milestone, 376,
iast (487.951 µs) : 466, 509
.   : milestone, 488,
iast_FULL (662.012 µs) : 639, 685
.   : milestone, 662,
iast_GLOBAL (522.115 µs) : 500, 545
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (490.106 µs) : 468, 512
.   : milestone, 490,
iast_INACTIVE (452.45 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (483.077 µs) : 461, 506
.   : milestone, 483,
tracing (442.204 µs) : 421, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.823 µs [354.962 µs, 394.685 µs] -
iast 487.073 µs [465.541 µs, 508.605 µs] 112.25 µs (29.9%)
iast_FULL 641.312 µs [619.751 µs, 662.873 µs] 266.489 µs (71.1%)
iast_GLOBAL 522.544 µs [500.16 µs, 544.927 µs] 147.72 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 483.901 µs [462.344 µs, 505.457 µs] 109.077 µs (29.1%)
iast_INACTIVE 451.982 µs [430.906 µs, 473.059 µs] 77.159 µs (20.6%)
iast_TELEMETRY_OFF 485.09 µs [463.029 µs, 507.151 µs] 110.267 µs (29.4%)
tracing 452.211 µs [430.917 µs, 473.505 µs] 77.388 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.382 µs [354.522 µs, 398.242 µs] -
iast 487.951 µs [466.425 µs, 509.477 µs] 111.569 µs (29.6%)
iast_FULL 662.012 µs [638.861 µs, 685.163 µs] 285.63 µs (75.9%)
iast_GLOBAL 522.115 µs [499.577 µs, 544.652 µs] 145.733 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 490.106 µs [468.295 µs, 511.916 µs] 113.724 µs (30.2%)
iast_INACTIVE 452.45 µs [430.917 µs, 473.984 µs] 76.069 µs (20.2%)
iast_TELEMETRY_OFF 483.077 µs [460.556 µs, 505.597 µs] 106.695 µs (28.3%)
tracing 442.204 µs [421.416 µs, 462.992 µs] 65.822 µs (17.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agentspancontext-toplevel-class
git_commit_date 1736340302 1736342521
git_commit_sha 9247ce3 43ee58c
release_version 1.45.0-SNAPSHOT~9247ce3d81 1.45.0-SNAPSHOT~43ee58c3c8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736344359 1736344359
ci_job_id 758436416 758436416
ci_pipeline_id 52433871 52433871
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.413 s) : 15413000, 15413000
.   : milestone, 15413000,
appsec (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
iast (18.638 s) : 18638000, 18638000
.   : milestone, 18638000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
.   : milestone, 17908000,
profiling (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
tracing (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
section candidate
no_agent (15.246 s) : 15246000, 15246000
.   : milestone, 15246000,
appsec (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
iast (18.62 s) : 18620000, 18620000
.   : milestone, 18620000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
.   : milestone, 17770000,
profiling (15.629 s) : 15629000, 15629000
.   : milestone, 15629000,
tracing (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.413 s [15.413 s, 15.413 s] -
appsec 14.956 s [14.956 s, 14.956 s] -457.0 ms (-3.0%)
iast 18.638 s [18.638 s, 18.638 s] 3.225 s (20.9%)
iast_GLOBAL 17.908 s [17.908 s, 17.908 s] 2.495 s (16.2%)
profiling 15.164 s [15.164 s, 15.164 s] -249.0 ms (-1.6%)
tracing 15.011 s [15.011 s, 15.011 s] -402.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.246 s [15.246 s, 15.246 s] -
appsec 15.111 s [15.111 s, 15.111 s] -135.0 ms (-0.9%)
iast 18.62 s [18.62 s, 18.62 s] 3.374 s (22.1%)
iast_GLOBAL 17.77 s [17.77 s, 17.77 s] 2.524 s (16.6%)
profiling 15.629 s [15.629 s, 15.629 s] 383.0 ms (2.5%)
tracing 14.867 s [14.867 s, 14.867 s] -379.0 ms (-2.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~43ee58c3c8, baseline=1.45.0-SNAPSHOT~9247ce3d81
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.102 ms) : 2048, 2156
.   : milestone, 2102,
iast_GLOBAL (2.151 ms) : 2097, 2206
.   : milestone, 2151,
profiling (2.438 ms) : 2197, 2679
.   : milestone, 2438,
tracing (1.946 ms) : 1904, 1988
.   : milestone, 1946,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.367 ms) : 2325, 2410
.   : milestone, 2367,
iast (2.098 ms) : 2044, 2152
.   : milestone, 2098,
iast_GLOBAL (2.14 ms) : 2086, 2194
.   : milestone, 2140,
profiling (2.463 ms) : 2277, 2649
.   : milestone, 2463,
tracing (1.949 ms) : 1907, 1991
.   : milestone, 1949,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.361 ms [2.318 ms, 2.404 ms] 890.771 µs (60.6%)
iast 2.102 ms [2.048 ms, 2.156 ms] 631.998 µs (43.0%)
iast_GLOBAL 2.151 ms [2.097 ms, 2.206 ms] 680.901 µs (46.3%)
profiling 2.438 ms [2.197 ms, 2.679 ms] 968.01 µs (65.8%)
tracing 1.946 ms [1.904 ms, 1.988 ms] 475.491 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.367 ms [2.325 ms, 2.41 ms] 895.543 µs (60.8%)
iast 2.098 ms [2.044 ms, 2.152 ms] 626.237 µs (42.5%)
iast_GLOBAL 2.14 ms [2.086 ms, 2.194 ms] 668.36 µs (45.4%)
profiling 2.463 ms [2.277 ms, 2.649 ms] 990.969 µs (67.3%)
tracing 1.949 ms [1.907 ms, 1.991 ms] 476.791 µs (32.4%)

@mcculls mcculls force-pushed the mcculls/make-agentspancontext-toplevel-class branch from 15a2be3 to c5e53c6 Compare January 8, 2025 12:36
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agentspancontext-toplevel-class
git_commit_date 1736340302 1736342521
git_commit_sha 9247ce3 43ee58c
See matching parameters
Baseline Candidate
ci_job_date 1736343557 1736343557
ci_job_id 758436418 758436418
ci_pipeline_id 52433871 52433871
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@mcculls mcculls force-pushed the mcculls/make-agentspancontext-toplevel-class branch from c5e53c6 to a4db58b Compare January 8, 2025 12:42
@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agentspancontext-toplevel-class
git_commit_date 1736340302 1736342521
git_commit_sha 9247ce3 43ee58c
See matching parameters
Baseline Candidate
ci_job_date 1736343627 1736343627
ci_job_id 758436419 758436419
ci_pipeline_id 52433871 52433871
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@mcculls mcculls force-pushed the mcculls/make-agentspancontext-toplevel-class branch from a4db58b to 43ee58c Compare January 8, 2025 13:22
PerfectSlayer
PerfectSlayer approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@mcculls mcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 8, 2025
@mcculls mcculls merged commit d3d6f9c into master Jan 8, 2025
152 checks passed
@mcculls mcculls deleted the mcculls/make-agentspancontext-toplevel-class branch January 8, 2025 14:21
@github-actions github-actions bot added this to the 1.45.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @PerfectSlayer @amarziali