-
Notifications
You must be signed in to change notification settings - Fork 303
🍒 8544 - Make the default config sources more robust when a security manager is installed #8545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
approved these changes
Mar 12, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049736
Total [baseline] (8.712 s) : 0, 8712247
Agent [candidate] (1.049 s) : 0, 1048646
Total [candidate] (8.691 s) : 0, 8690734
section iast
Agent [baseline] (1.176 s) : 0, 1175797
Total [baseline] (9.271 s) : 0, 9270845
Agent [candidate] (1.181 s) : 0, 1181041
Total [candidate] (9.286 s) : 0, 9285724
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1178177
Total [baseline] (9.255 s) : 0, 9255248
Agent [candidate] (1.181 s) : 0, 1181127
Total [candidate] (9.249 s) : 0, 9249247
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173393
Total [baseline] (9.254 s) : 0, 9253651
Agent [candidate] (1.169 s) : 0, 1168808
Total [candidate] (9.283 s) : 0, 9283438
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.371 ms) : 0, 724371
BytebuddyAgent [candidate] (723.84 ms) : 0, 723840
GlobalTracer [baseline] (241.476 ms) : 0, 241476
GlobalTracer [candidate] (241.41 ms) : 0, 241410
AppSec [baseline] (55.328 ms) : 0, 55328
AppSec [candidate] (56.204 ms) : 0, 56204
Remote Config [baseline] (690.586 µs) : 0, 691
Remote Config [candidate] (695.099 µs) : 0, 695
Telemetry [baseline] (12.885 ms) : 0, 12885
Telemetry [candidate] (11.479 ms) : 0, 11479
section iast
BytebuddyAgent [baseline] (840.808 ms) : 0, 840808
BytebuddyAgent [candidate] (844.369 ms) : 0, 844369
GlobalTracer [baseline] (231.608 ms) : 0, 231608
GlobalTracer [candidate] (232.064 ms) : 0, 232064
IAST [baseline] (22.727 ms) : 0, 22727
IAST [candidate] (22.952 ms) : 0, 22952
AppSec [baseline] (56.377 ms) : 0, 56377
AppSec [candidate] (57.212 ms) : 0, 57212
Remote Config [baseline] (608.767 µs) : 0, 609
Remote Config [candidate] (621.379 µs) : 0, 621
Telemetry [baseline] (8.731 ms) : 0, 8731
Telemetry [candidate] (8.788 ms) : 0, 8788
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.869 ms) : 0, 840869
BytebuddyAgent [candidate] (844.587 ms) : 0, 844587
GlobalTracer [baseline] (233.33 ms) : 0, 233330
GlobalTracer [candidate] (231.983 ms) : 0, 231983
IAST [baseline] (23.846 ms) : 0, 23846
IAST [candidate] (23.001 ms) : 0, 23001
AppSec [baseline] (55.805 ms) : 0, 55805
AppSec [candidate] (57.174 ms) : 0, 57174
Remote Config [baseline] (623.189 µs) : 0, 623
Remote Config [candidate] (628.849 µs) : 0, 629
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.68 ms) : 0, 8680
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.47 ms) : 0, 838470
BytebuddyAgent [candidate] (833.733 ms) : 0, 833733
GlobalTracer [baseline] (231.771 ms) : 0, 231771
GlobalTracer [candidate] (231.118 ms) : 0, 231118
IAST [baseline] (22.32 ms) : 0, 22320
IAST [candidate] (24.074 ms) : 0, 24074
AppSec [baseline] (56.628 ms) : 0, 56628
AppSec [candidate] (55.654 ms) : 0, 55654
Remote Config [baseline] (611.531 µs) : 0, 612
Remote Config [candidate] (623.969 µs) : 0, 624
Telemetry [baseline] (8.64 ms) : 0, 8640
Telemetry [candidate] (8.707 ms) : 0, 8707
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051703
Total [baseline] (10.451 s) : 0, 10450849
Agent [candidate] (1.041 s) : 0, 1040548
Total [candidate] (10.452 s) : 0, 10451516
section appsec
Agent [baseline] (1.183 s) : 0, 1183008
Total [baseline] (10.728 s) : 0, 10727890
Agent [candidate] (1.183 s) : 0, 1182969
Total [candidate] (10.744 s) : 0, 10744241
section iast
Agent [baseline] (1.175 s) : 0, 1175492
Total [baseline] (10.995 s) : 0, 10995123
Agent [candidate] (1.172 s) : 0, 1171719
Total [candidate] (10.986 s) : 0, 10985632
section profiling
Agent [baseline] (1.26 s) : 0, 1259998
Total [baseline] (10.796 s) : 0, 10796458
Agent [candidate] (1.268 s) : 0, 1267602
Total [candidate] (10.876 s) : 0, 10876345
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.921 ms) : 0, 724921
BytebuddyAgent [candidate] (718.147 ms) : 0, 718147
GlobalTracer [baseline] (242.376 ms) : 0, 242376
GlobalTracer [candidate] (240.298 ms) : 0, 240298
AppSec [baseline] (55.198 ms) : 0, 55198
AppSec [candidate] (55.743 ms) : 0, 55743
Remote Config [baseline] (702.319 µs) : 0, 702
Remote Config [candidate] (689.408 µs) : 0, 689
Telemetry [baseline] (13.521 ms) : 0, 13521
Telemetry [candidate] (10.707 ms) : 0, 10707
section appsec
BytebuddyAgent [baseline] (736.108 ms) : 0, 736108
BytebuddyAgent [candidate] (735.318 ms) : 0, 735318
GlobalTracer [baseline] (236.355 ms) : 0, 236355
GlobalTracer [candidate] (236.5 ms) : 0, 236500
AppSec [baseline] (175.687 ms) : 0, 175687
AppSec [candidate] (176.604 ms) : 0, 176604
Remote Config [baseline] (661.234 µs) : 0, 661
Remote Config [candidate] (662.959 µs) : 0, 663
Telemetry [baseline] (8.601 ms) : 0, 8601
Telemetry [candidate] (8.313 ms) : 0, 8313
IAST [baseline] (21.528 ms) : 0, 21528
IAST [candidate] (21.422 ms) : 0, 21422
section iast
BytebuddyAgent [baseline] (840.213 ms) : 0, 840213
BytebuddyAgent [candidate] (837.151 ms) : 0, 837151
GlobalTracer [baseline] (231.485 ms) : 0, 231485
GlobalTracer [candidate] (230.32 ms) : 0, 230320
AppSec [baseline] (56.624 ms) : 0, 56624
AppSec [candidate] (57.148 ms) : 0, 57148
Remote Config [baseline] (624.526 µs) : 0, 625
Remote Config [candidate] (622.462 µs) : 0, 622
Telemetry [baseline] (8.771 ms) : 0, 8771
Telemetry [candidate] (8.677 ms) : 0, 8677
IAST [baseline] (22.856 ms) : 0, 22856
IAST [candidate] (22.835 ms) : 0, 22835
section profiling
BytebuddyAgent [baseline] (709.481 ms) : 0, 709481
BytebuddyAgent [candidate] (709.842 ms) : 0, 709842
GlobalTracer [baseline] (350.296 ms) : 0, 350296
GlobalTracer [candidate] (354.447 ms) : 0, 354447
AppSec [baseline] (54.496 ms) : 0, 54496
AppSec [candidate] (55.01 ms) : 0, 55010
Remote Config [baseline] (661.675 µs) : 0, 662
Remote Config [candidate] (689.038 µs) : 0, 689
Telemetry [baseline] (8.894 ms) : 0, 8894
Telemetry [candidate] (9.185 ms) : 0, 9185
ProfilingAgent [baseline] (95.926 ms) : 0, 95926
ProfilingAgent [candidate] (98.119 ms) : 0, 98119
Profiling [baseline] (95.951 ms) : 0, 95951
Profiling [candidate] (98.144 ms) : 0, 98144
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section baseline
no_agent (379.484 µs) : 358, 401
. : milestone, 379,
iast (516.324 µs) : 494, 538
. : milestone, 516,
iast_FULL (730.023 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (549.9 µs) : 528, 572
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (509.818 µs) : 488, 532
. : milestone, 510,
iast_INACTIVE (454.674 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (499.23 µs) : 476, 522
. : milestone, 499,
tracing (459.086 µs) : 438, 481
. : milestone, 459,
section candidate
no_agent (379.204 µs) : 359, 399
. : milestone, 379,
iast (507.023 µs) : 485, 529
. : milestone, 507,
iast_FULL (729.804 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (555.929 µs) : 534, 578
. : milestone, 556,
iast_HARDCODED_SECRET_DISABLED (510.659 µs) : 488, 533
. : milestone, 511,
iast_INACTIVE (463.973 µs) : 442, 486
. : milestone, 464,
iast_TELEMETRY_OFF (494.836 µs) : 472, 517
. : milestone, 495,
tracing (453.435 µs) : 432, 475
. : milestone, 453,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1387
. : milestone, 1368,
appsec (1.731 ms) : 1707, 1755
. : milestone, 1731,
appsec_no_iast (1.736 ms) : 1711, 1761
. : milestone, 1736,
code_origins (1.669 ms) : 1642, 1697
. : milestone, 1669,
iast (1.513 ms) : 1489, 1538
. : milestone, 1513,
profiling (1.563 ms) : 1538, 1589
. : milestone, 1563,
tracing (1.474 ms) : 1448, 1499
. : milestone, 1474,
section candidate
no_agent (1.366 ms) : 1346, 1386
. : milestone, 1366,
appsec (1.748 ms) : 1724, 1772
. : milestone, 1748,
appsec_no_iast (1.729 ms) : 1705, 1753
. : milestone, 1729,
code_origins (1.692 ms) : 1659, 1724
. : milestone, 1692,
iast (1.505 ms) : 1482, 1529
. : milestone, 1505,
profiling (1.504 ms) : 1481, 1527
. : milestone, 1504,
tracing (1.489 ms) : 1463, 1514
. : milestone, 1489,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section baseline
no_agent (1.516 ms) : 1504, 1528
. : milestone, 1516,
appsec (2.466 ms) : 2418, 2514
. : milestone, 2466,
iast (2.19 ms) : 2132, 2248
. : milestone, 2190,
iast_GLOBAL (2.236 ms) : 2178, 2293
. : milestone, 2236,
profiling (2.042 ms) : 1997, 2088
. : milestone, 2042,
tracing (2.025 ms) : 1980, 2070
. : milestone, 2025,
section candidate
no_agent (1.514 ms) : 1502, 1526
. : milestone, 1514,
appsec (2.429 ms) : 2384, 2474
. : milestone, 2429,
iast (2.195 ms) : 2137, 2253
. : milestone, 2195,
iast_GLOBAL (2.248 ms) : 2189, 2307
. : milestone, 2248,
profiling (2.034 ms) : 1989, 2080
. : milestone, 2034,
tracing (2.008 ms) : 1964, 2052
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~6b700c528a, baseline=1.48.0-SNAPSHOT~ab73c4495d
dateFormat X
axisFormat %s
section baseline
no_agent (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
appsec (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
iast (18.271 s) : 18271000, 18271000
. : milestone, 18271000,
iast_GLOBAL (18.45 s) : 18450000, 18450000
. : milestone, 18450000,
profiling (15.754 s) : 15754000, 15754000
. : milestone, 15754000,
tracing (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
section candidate
no_agent (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
appsec (15.221 s) : 15221000, 15221000
. : milestone, 15221000,
iast (18.893 s) : 18893000, 18893000
. : milestone, 18893000,
iast_GLOBAL (17.911 s) : 17911000, 17911000
. : milestone, 17911000,
profiling (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
tracing (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Mar 14, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.11.0` -> `2.12.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.0` -> `1.47.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.0` -> `1.47.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.30.38` -> `2.31.0` | --- ### Release Notes <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.12.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2120) - \[Feat]: detect dependencies that provide dylibs for use on macOS. - \[Test]: incorrect attribution of so files to Android deps. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.1): 1.47.1 ##### Components ##### Continuous Integration Visibility - 🐛 🍒 8521 - Fix NPE when calculating code coverage for Gradle projects with non-standard directory layout ([#​8546](DataDog/dd-trace-java#8546) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Tracer core - ✨ 🍒 8544 - Make the default config sources more robust when a security manager is installed ([#​8545](DataDog/dd-trace-java#8545) - [@​mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 83507bcf5ab089406b494446695c5ef453bcb000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8544 to release/v1.47.x