-
Notifications
You must be signed in to change notification settings - Fork 303
Minimize changes needed to test code origin on instrumentations #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
just trying to see CI run |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (321.665 µs) : 278, 365
. : milestone, 322,
basic (309.965 µs) : 299, 321
. : milestone, 310,
loop (10.815 ms) : 10789, 10842
. : milestone, 10815,
section candidate
noprobe (304.874 µs) : 278, 331
. : milestone, 305,
basic (311.334 µs) : 303, 319
. : milestone, 311,
loop (10.893 ms) : 10838, 10948
. : milestone, 10893,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039036
Total [baseline] (10.454 s) : 0, 10453771
Agent [candidate] (1.047 s) : 0, 1046909
Total [candidate] (10.455 s) : 0, 10455156
section appsec
Agent [baseline] (1.188 s) : 0, 1188393
Total [baseline] (10.782 s) : 0, 10781664
Agent [candidate] (1.187 s) : 0, 1186574
Total [candidate] (10.792 s) : 0, 10791766
section iast
Agent [baseline] (1.175 s) : 0, 1174719
Total [baseline] (11.022 s) : 0, 11022138
Agent [candidate] (1.171 s) : 0, 1171032
Total [candidate] (10.97 s) : 0, 10970081
section profiling
Agent [baseline] (1.259 s) : 0, 1258622
Total [baseline] (10.896 s) : 0, 10895631
Agent [candidate] (1.266 s) : 0, 1266307
Total [candidate] (10.879 s) : 0, 10879469
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.003 ms) : 0, 717003
BytebuddyAgent [candidate] (721.725 ms) : 0, 721725
GlobalTracer [baseline] (238.402 ms) : 0, 238402
GlobalTracer [candidate] (240.518 ms) : 0, 240518
AppSec [baseline] (54.826 ms) : 0, 54826
AppSec [candidate] (55.022 ms) : 0, 55022
Remote Config [baseline] (702.59 µs) : 0, 703
Remote Config [candidate] (696.077 µs) : 0, 696
Telemetry [baseline] (12.149 ms) : 0, 12149
Telemetry [candidate] (12.917 ms) : 0, 12917
section appsec
BytebuddyAgent [baseline] (738.179 ms) : 0, 738179
BytebuddyAgent [candidate] (737.948 ms) : 0, 737948
GlobalTracer [baseline] (237.434 ms) : 0, 237434
GlobalTracer [candidate] (236.445 ms) : 0, 236445
IAST [baseline] (21.703 ms) : 0, 21703
IAST [candidate] (21.602 ms) : 0, 21602
AppSec [baseline] (176.922 ms) : 0, 176922
AppSec [candidate] (176.432 ms) : 0, 176432
Remote Config [baseline] (678.16 µs) : 0, 678
Remote Config [candidate] (659.615 µs) : 0, 660
Telemetry [baseline] (8.341 ms) : 0, 8341
Telemetry [candidate] (8.299 ms) : 0, 8299
section iast
BytebuddyAgent [baseline] (840.155 ms) : 0, 840155
BytebuddyAgent [candidate] (837.007 ms) : 0, 837007
GlobalTracer [baseline] (230.433 ms) : 0, 230433
GlobalTracer [candidate] (230.012 ms) : 0, 230012
IAST [baseline] (22.816 ms) : 0, 22816
IAST [candidate] (22.697 ms) : 0, 22697
AppSec [baseline] (56.026 ms) : 0, 56026
AppSec [candidate] (56.206 ms) : 0, 56206
Remote Config [baseline] (599.801 µs) : 0, 600
Remote Config [candidate] (596.782 µs) : 0, 597
Telemetry [baseline] (8.696 ms) : 0, 8696
Telemetry [candidate] (8.61 ms) : 0, 8610
section profiling
BytebuddyAgent [baseline] (708.325 ms) : 0, 708325
BytebuddyAgent [candidate] (713.443 ms) : 0, 713443
GlobalTracer [baseline] (349.48 ms) : 0, 349480
GlobalTracer [candidate] (351.155 ms) : 0, 351155
AppSec [baseline] (54.009 ms) : 0, 54009
AppSec [candidate] (53.82 ms) : 0, 53820
Remote Config [baseline] (706.011 µs) : 0, 706
Remote Config [candidate] (710.922 µs) : 0, 711
Telemetry [baseline] (8.947 ms) : 0, 8947
Telemetry [candidate] (8.978 ms) : 0, 8978
ProfilingAgent [baseline] (95.691 ms) : 0, 95691
ProfilingAgent [candidate] (96.51 ms) : 0, 96510
Profiling [baseline] (95.716 ms) : 0, 95716
Profiling [candidate] (96.535 ms) : 0, 96535
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041374
Total [baseline] (8.669 s) : 0, 8669412
Agent [candidate] (1.039 s) : 0, 1038767
Total [candidate] (8.648 s) : 0, 8647759
section iast
Agent [baseline] (1.172 s) : 0, 1171729
Total [baseline] (9.237 s) : 0, 9236830
Agent [candidate] (1.171 s) : 0, 1171177
Total [candidate] (9.248 s) : 0, 9247745
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172542
Total [baseline] (9.18 s) : 0, 9179908
Agent [candidate] (1.188 s) : 0, 1188095
Total [candidate] (9.222 s) : 0, 9221906
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168576
Total [baseline] (9.261 s) : 0, 9260624
Agent [candidate] (1.176 s) : 0, 1175728
Total [candidate] (9.278 s) : 0, 9277716
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.454 ms) : 0, 718454
BytebuddyAgent [candidate] (716.444 ms) : 0, 716444
GlobalTracer [baseline] (239.878 ms) : 0, 239878
GlobalTracer [candidate] (238.821 ms) : 0, 238821
AppSec [baseline] (54.794 ms) : 0, 54794
AppSec [candidate] (54.73 ms) : 0, 54730
Remote Config [baseline] (697.897 µs) : 0, 698
Remote Config [candidate] (693.34 µs) : 0, 693
Telemetry [baseline] (11.536 ms) : 0, 11536
Telemetry [candidate] (12.119 ms) : 0, 12119
section iast
BytebuddyAgent [baseline] (837.019 ms) : 0, 837019
BytebuddyAgent [candidate] (836.863 ms) : 0, 836863
GlobalTracer [baseline] (230.065 ms) : 0, 230065
GlobalTracer [candidate] (230.173 ms) : 0, 230173
IAST [baseline] (23.78 ms) : 0, 23780
IAST [candidate] (22.845 ms) : 0, 22845
AppSec [baseline] (55.592 ms) : 0, 55592
AppSec [candidate] (56.056 ms) : 0, 56056
Remote Config [baseline] (622.293 µs) : 0, 622
Remote Config [candidate] (612.603 µs) : 0, 613
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.754 ms) : 0, 8754
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.994 ms) : 0, 837994
BytebuddyAgent [candidate] (850.095 ms) : 0, 850095
GlobalTracer [baseline] (230.267 ms) : 0, 230267
GlobalTracer [candidate] (232.589 ms) : 0, 232589
IAST [baseline] (23.759 ms) : 0, 23759
IAST [candidate] (23.253 ms) : 0, 23253
AppSec [baseline] (55.242 ms) : 0, 55242
AppSec [candidate] (56.46 ms) : 0, 56460
Remote Config [baseline] (610.856 µs) : 0, 611
Remote Config [candidate] (610.799 µs) : 0, 611
Telemetry [baseline] (8.723 ms) : 0, 8723
Telemetry [candidate] (8.883 ms) : 0, 8883
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.634 ms) : 0, 834634
BytebuddyAgent [candidate] (840.201 ms) : 0, 840201
GlobalTracer [baseline] (230.281 ms) : 0, 230281
GlobalTracer [candidate] (231.497 ms) : 0, 231497
IAST [baseline] (22.418 ms) : 0, 22418
IAST [candidate] (22.387 ms) : 0, 22387
AppSec [baseline] (56.146 ms) : 0, 56146
AppSec [candidate] (56.285 ms) : 0, 56285
Remote Config [baseline] (611.41 µs) : 0, 611
Remote Config [candidate] (610.463 µs) : 0, 610
Telemetry [baseline] (8.577 ms) : 0, 8577
Telemetry [candidate] (8.681 ms) : 0, 8681
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (381.253 µs) : 361, 401
. : milestone, 381,
iast (521.266 µs) : 499, 544
. : milestone, 521,
iast_FULL (736.19 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (564.226 µs) : 543, 586
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (515.593 µs) : 494, 537
. : milestone, 516,
iast_INACTIVE (473.893 µs) : 452, 496
. : milestone, 474,
iast_TELEMETRY_OFF (503.11 µs) : 482, 525
. : milestone, 503,
tracing (472.248 µs) : 451, 494
. : milestone, 472,
section candidate
no_agent (383.322 µs) : 363, 404
. : milestone, 383,
iast (519.172 µs) : 497, 541
. : milestone, 519,
iast_FULL (739.607 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (558.623 µs) : 537, 580
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (516.14 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (476.317 µs) : 455, 498
. : milestone, 476,
iast_TELEMETRY_OFF (504.527 µs) : 483, 526
. : milestone, 505,
tracing (466.425 µs) : 445, 488
. : milestone, 466,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.747 ms) : 1723, 1770
. : milestone, 1747,
appsec_no_iast (1.775 ms) : 1750, 1799
. : milestone, 1775,
code_origins (1.684 ms) : 1657, 1711
. : milestone, 1684,
iast (1.526 ms) : 1502, 1550
. : milestone, 1526,
profiling (1.514 ms) : 1490, 1537
. : milestone, 1514,
tracing (1.509 ms) : 1484, 1534
. : milestone, 1509,
section candidate
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.748 ms) : 1725, 1772
. : milestone, 1748,
appsec_no_iast (1.732 ms) : 1708, 1757
. : milestone, 1732,
code_origins (1.691 ms) : 1665, 1718
. : milestone, 1691,
iast (1.536 ms) : 1511, 1560
. : milestone, 1536,
profiling (1.514 ms) : 1490, 1538
. : milestone, 1514,
tracing (1.505 ms) : 1480, 1531
. : milestone, 1505,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.353 ms) : 2309, 2397
. : milestone, 2353,
iast (2.137 ms) : 2081, 2193
. : milestone, 2137,
iast_GLOBAL (2.185 ms) : 2128, 2242
. : milestone, 2185,
profiling (2.01 ms) : 1964, 2056
. : milestone, 2010,
tracing (1.96 ms) : 1917, 2002
. : milestone, 1960,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.364 ms) : 2320, 2408
. : milestone, 2364,
iast (2.129 ms) : 2073, 2185
. : milestone, 2129,
iast_GLOBAL (2.18 ms) : 2124, 2236
. : milestone, 2180,
profiling (1.992 ms) : 1947, 2037
. : milestone, 1992,
tracing (1.974 ms) : 1931, 2017
. : milestone, 1974,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~98a473e4a7, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
appsec (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
iast (18.323 s) : 18323000, 18323000
. : milestone, 18323000,
iast_GLOBAL (18.327 s) : 18327000, 18327000
. : milestone, 18327000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (14.665 s) : 14665000, 14665000
. : milestone, 14665000,
section candidate
no_agent (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
appsec (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
iast (18.848 s) : 18848000, 18848000
. : milestone, 18848000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
tracing (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
3e050e0
to
77e8ab1
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
f406227
to
4fbf185
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/CodeOriginProbe.java
Outdated
Show resolved
Hide resolved
b1802d2
to
41444a3
Compare
41444a3
to
ede71ff
Compare
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]