-
Notifications
You must be signed in to change notification settings - Fork 303
Most contexts won't have baggage, so this debug line is not that helpful #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ful. It also generates a large amount of log messages when tracer debug is on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. It's actually rare to have a baggage on a common usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Looking at the rest of the inject, there doesn't seem to be anywhere we can write a log that would occur only because of an error in baggage propagation.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039128
Total [baseline] (10.426 s) : 0, 10425958
Agent [candidate] (1.05 s) : 0, 1049585
Total [candidate] (10.426 s) : 0, 10425631
section appsec
Agent [baseline] (1.187 s) : 0, 1186616
Total [baseline] (10.723 s) : 0, 10722812
Agent [candidate] (1.183 s) : 0, 1182639
Total [candidate] (10.681 s) : 0, 10680671
section iast
Agent [baseline] (1.171 s) : 0, 1170736
Total [baseline] (10.996 s) : 0, 10996210
Agent [candidate] (1.181 s) : 0, 1181025
Total [candidate] (10.984 s) : 0, 10983843
section profiling
Agent [baseline] (1.261 s) : 0, 1261496
Total [baseline] (10.836 s) : 0, 10835651
Agent [candidate] (1.268 s) : 0, 1267955
Total [candidate] (10.832 s) : 0, 10831998
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.926 ms) : 0, 717926
BytebuddyAgent [candidate] (725.811 ms) : 0, 725811
GlobalTracer [baseline] (238.759 ms) : 0, 238759
GlobalTracer [candidate] (239.699 ms) : 0, 239699
AppSec [baseline] (54.383 ms) : 0, 54383
AppSec [candidate] (54.863 ms) : 0, 54863
Remote Config [baseline] (685.534 µs) : 0, 686
Remote Config [candidate] (684.597 µs) : 0, 685
Telemetry [baseline] (11.404 ms) : 0, 11404
Telemetry [candidate] (12.381 ms) : 0, 12381
section appsec
BytebuddyAgent [baseline] (738.202 ms) : 0, 738202
BytebuddyAgent [candidate] (735.639 ms) : 0, 735639
GlobalTracer [baseline] (236.825 ms) : 0, 236825
GlobalTracer [candidate] (235.927 ms) : 0, 235927
AppSec [baseline] (175.786 ms) : 0, 175786
AppSec [candidate] (175.487 ms) : 0, 175487
Remote Config [baseline] (661.155 µs) : 0, 661
Remote Config [candidate] (665.325 µs) : 0, 665
Telemetry [baseline] (8.328 ms) : 0, 8328
Telemetry [candidate] (8.252 ms) : 0, 8252
IAST [baseline] (21.673 ms) : 0, 21673
IAST [candidate] (21.511 ms) : 0, 21511
section iast
BytebuddyAgent [baseline] (836.553 ms) : 0, 836553
BytebuddyAgent [candidate] (844.808 ms) : 0, 844808
GlobalTracer [baseline] (229.724 ms) : 0, 229724
GlobalTracer [candidate] (231.234 ms) : 0, 231234
AppSec [baseline] (56.471 ms) : 0, 56471
AppSec [candidate] (56.609 ms) : 0, 56609
Remote Config [baseline] (616.685 µs) : 0, 617
Remote Config [candidate] (607.389 µs) : 0, 607
Telemetry [baseline] (8.68 ms) : 0, 8680
Telemetry [candidate] (8.775 ms) : 0, 8775
IAST [baseline] (22.844 ms) : 0, 22844
IAST [candidate] (22.99 ms) : 0, 22990
section profiling
BytebuddyAgent [baseline] (710.595 ms) : 0, 710595
BytebuddyAgent [candidate] (713.386 ms) : 0, 713386
GlobalTracer [baseline] (349.298 ms) : 0, 349298
GlobalTracer [candidate] (352.421 ms) : 0, 352421
AppSec [baseline] (54.38 ms) : 0, 54380
AppSec [candidate] (53.819 ms) : 0, 53819
Remote Config [baseline] (710.631 µs) : 0, 711
Remote Config [candidate] (724.314 µs) : 0, 724
Telemetry [baseline] (8.949 ms) : 0, 8949
Telemetry [candidate] (8.96 ms) : 0, 8960
ProfilingAgent [baseline] (96.105 ms) : 0, 96105
ProfilingAgent [candidate] (96.873 ms) : 0, 96873
Profiling [baseline] (96.131 ms) : 0, 96131
Profiling [candidate] (96.897 ms) : 0, 96897
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050087
Total [baseline] (8.693 s) : 0, 8693441
Agent [candidate] (1.038 s) : 0, 1038476
Total [candidate] (8.653 s) : 0, 8652753
section iast
Agent [baseline] (1.171 s) : 0, 1171046
Total [baseline] (9.237 s) : 0, 9237329
Agent [candidate] (1.172 s) : 0, 1172298
Total [candidate] (9.239 s) : 0, 9238958
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179884
Total [baseline] (9.222 s) : 0, 9221556
Agent [candidate] (1.171 s) : 0, 1171450
Total [candidate] (9.28 s) : 0, 9279801
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168211
Total [baseline] (9.246 s) : 0, 9246000
Agent [candidate] (1.184 s) : 0, 1184080
Total [candidate] (9.252 s) : 0, 9252246
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.757 ms) : 0, 724757
BytebuddyAgent [candidate] (716.655 ms) : 0, 716655
GlobalTracer [baseline] (240.079 ms) : 0, 240079
GlobalTracer [candidate] (238.714 ms) : 0, 238714
AppSec [baseline] (54.737 ms) : 0, 54737
AppSec [candidate] (54.845 ms) : 0, 54845
Remote Config [baseline] (682.798 µs) : 0, 683
Remote Config [candidate] (696.881 µs) : 0, 697
Telemetry [baseline] (13.698 ms) : 0, 13698
Telemetry [candidate] (11.601 ms) : 0, 11601
section iast
BytebuddyAgent [baseline] (837.258 ms) : 0, 837258
BytebuddyAgent [candidate] (838.33 ms) : 0, 838330
GlobalTracer [baseline] (229.896 ms) : 0, 229896
GlobalTracer [candidate] (229.844 ms) : 0, 229844
AppSec [baseline] (55.038 ms) : 0, 55038
AppSec [candidate] (55.912 ms) : 0, 55912
Remote Config [baseline] (609.62 µs) : 0, 610
Remote Config [candidate] (607.292 µs) : 0, 607
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.746 ms) : 0, 8746
IAST [baseline] (23.736 ms) : 0, 23736
IAST [candidate] (22.934 ms) : 0, 22934
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (844.495 ms) : 0, 844495
BytebuddyAgent [candidate] (837.256 ms) : 0, 837256
GlobalTracer [baseline] (230.669 ms) : 0, 230669
GlobalTracer [candidate] (230.309 ms) : 0, 230309
AppSec [baseline] (55.466 ms) : 0, 55466
AppSec [candidate] (55.886 ms) : 0, 55886
Remote Config [baseline] (610.456 µs) : 0, 610
Remote Config [candidate] (598.938 µs) : 0, 599
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (8.592 ms) : 0, 8592
IAST [baseline] (23.862 ms) : 0, 23862
IAST [candidate] (22.891 ms) : 0, 22891
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.341 ms) : 0, 834341
BytebuddyAgent [candidate] (846.729 ms) : 0, 846729
GlobalTracer [baseline] (229.752 ms) : 0, 229752
GlobalTracer [candidate] (232.083 ms) : 0, 232083
AppSec [baseline] (56.217 ms) : 0, 56217
AppSec [candidate] (56.633 ms) : 0, 56633
Remote Config [baseline] (626.922 µs) : 0, 627
Remote Config [candidate] (625.289 µs) : 0, 625
Telemetry [baseline] (8.72 ms) : 0, 8720
Telemetry [candidate] (8.813 ms) : 0, 8813
IAST [baseline] (22.504 ms) : 0, 22504
IAST [candidate] (22.909 ms) : 0, 22909
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (1.377 ms) : 1357, 1398
. : milestone, 1377,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.746 ms) : 1721, 1771
. : milestone, 1746,
code_origins (1.672 ms) : 1644, 1699
. : milestone, 1672,
iast (1.534 ms) : 1509, 1558
. : milestone, 1534,
profiling (1.508 ms) : 1484, 1532
. : milestone, 1508,
tracing (1.49 ms) : 1464, 1515
. : milestone, 1490,
section candidate
no_agent (1.368 ms) : 1349, 1388
. : milestone, 1368,
appsec (1.737 ms) : 1713, 1762
. : milestone, 1737,
appsec_no_iast (1.74 ms) : 1714, 1765
. : milestone, 1740,
code_origins (1.688 ms) : 1661, 1715
. : milestone, 1688,
iast (1.535 ms) : 1511, 1559
. : milestone, 1535,
profiling (1.514 ms) : 1491, 1538
. : milestone, 1514,
tracing (1.501 ms) : 1475, 1527
. : milestone, 1501,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (389.118 µs) : 369, 409
. : milestone, 389,
iast (517.745 µs) : 496, 540
. : milestone, 518,
iast_FULL (735.343 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (567.072 µs) : 545, 589
. : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (528.892 µs) : 507, 551
. : milestone, 529,
iast_INACTIVE (473.869 µs) : 452, 495
. : milestone, 474,
iast_TELEMETRY_OFF (506.71 µs) : 485, 528
. : milestone, 507,
tracing (473.375 µs) : 451, 496
. : milestone, 473,
section candidate
no_agent (389.651 µs) : 370, 409
. : milestone, 390,
iast (517.919 µs) : 496, 540
. : milestone, 518,
iast_FULL (742.249 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (572.441 µs) : 550, 595
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (520.659 µs) : 499, 543
. : milestone, 521,
iast_INACTIVE (483.62 µs) : 462, 506
. : milestone, 484,
iast_TELEMETRY_OFF (510.586 µs) : 489, 532
. : milestone, 511,
tracing (466.563 µs) : 446, 487
. : milestone, 467,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.362 ms) : 2318, 2406
. : milestone, 2362,
iast (2.131 ms) : 2075, 2187
. : milestone, 2131,
iast_GLOBAL (2.176 ms) : 2119, 2232
. : milestone, 2176,
profiling (2.42 ms) : 2254, 2587
. : milestone, 2420,
tracing (1.956 ms) : 1914, 1999
. : milestone, 1956,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.364 ms) : 2320, 2409
. : milestone, 2364,
iast (2.142 ms) : 2085, 2198
. : milestone, 2142,
iast_GLOBAL (2.18 ms) : 2124, 2236
. : milestone, 2180,
profiling (1.989 ms) : 1944, 2033
. : milestone, 1989,
tracing (1.965 ms) : 1922, 2008
. : milestone, 1965,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~e4ebf924ee, baseline=1.48.0-SNAPSHOT~563b2c9769
dateFormat X
axisFormat %s
section baseline
no_agent (15.604 s) : 15604000, 15604000
. : milestone, 15604000,
appsec (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
iast (18.668 s) : 18668000, 18668000
. : milestone, 18668000,
iast_GLOBAL (17.778 s) : 17778000, 17778000
. : milestone, 17778000,
profiling (15.218 s) : 15218000, 15218000
. : milestone, 15218000,
tracing (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
section candidate
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
iast (19.045 s) : 19045000, 19045000
. : milestone, 19045000,
iast_GLOBAL (17.556 s) : 17556000, 17556000
. : milestone, 17556000,
profiling (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
tracing (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
|
Motivation
It also generates a large amount of log messages when tracer debug is on.