-
Notifications
You must be signed in to change notification settings - Fork 303
🍒 8601 - Introduce cache for peer.hostname lookup #8611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
approved these changes
Mar 24, 2025
manuel-alvarez-alvarez
approved these changes
Mar 24, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 6 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051159
Total [baseline] (8.699 s) : 0, 8699107
Agent [candidate] (1.048 s) : 0, 1047867
Total [candidate] (8.686 s) : 0, 8686421
section iast
Agent [baseline] (1.177 s) : 0, 1176614
Total [baseline] (9.265 s) : 0, 9265231
Agent [candidate] (1.179 s) : 0, 1178791
Total [candidate] (9.253 s) : 0, 9253327
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1181104
Total [baseline] (9.233 s) : 0, 9232935
Agent [candidate] (1.169 s) : 0, 1169387
Total [candidate] (9.205 s) : 0, 9204749
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180124
Total [baseline] (9.269 s) : 0, 9269097
Agent [candidate] (1.185 s) : 0, 1185187
Total [candidate] (9.281 s) : 0, 9281420
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.499 ms) : 0, 720499
BytebuddyAgent [candidate] (721.625 ms) : 0, 721625
GlobalTracer [baseline] (240.49 ms) : 0, 240490
GlobalTracer [candidate] (240.932 ms) : 0, 240932
AppSec [baseline] (55.111 ms) : 0, 55111
AppSec [candidate] (55.997 ms) : 0, 55997
Remote Config [baseline] (772.341 µs) : 0, 772
Remote Config [candidate] (683.896 µs) : 0, 684
Telemetry [baseline] (13.766 ms) : 0, 13766
Telemetry [candidate] (13.549 ms) : 0, 13549
Debugger [baseline] (4.432 ms) : 0, 4432
section iast
BytebuddyAgent [baseline] (838.33 ms) : 0, 838330
BytebuddyAgent [candidate] (843.178 ms) : 0, 843178
GlobalTracer [baseline] (230.424 ms) : 0, 230424
GlobalTracer [candidate] (230.96 ms) : 0, 230960
IAST [baseline] (22.607 ms) : 0, 22607
IAST [candidate] (22.895 ms) : 0, 22895
AppSec [baseline] (55.776 ms) : 0, 55776
AppSec [candidate] (57.309 ms) : 0, 57309
Remote Config [baseline] (606.893 µs) : 0, 607
Remote Config [candidate] (631.678 µs) : 0, 632
Telemetry [baseline] (8.768 ms) : 0, 8768
Telemetry [candidate] (8.761 ms) : 0, 8761
Debugger [baseline] (4.161 ms) : 0, 4161
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.771 ms) : 0, 839771
BytebuddyAgent [candidate] (835.695 ms) : 0, 835695
GlobalTracer [baseline] (232.151 ms) : 0, 232151
GlobalTracer [candidate] (229.838 ms) : 0, 229838
IAST [baseline] (23.06 ms) : 0, 23060
IAST [candidate] (22.741 ms) : 0, 22741
AppSec [baseline] (56.467 ms) : 0, 56467
AppSec [candidate] (56.869 ms) : 0, 56869
Remote Config [baseline] (616.842 µs) : 0, 617
Remote Config [candidate] (622.556 µs) : 0, 623
Telemetry [baseline] (8.86 ms) : 0, 8860
Telemetry [candidate] (8.661 ms) : 0, 8661
Debugger [baseline] (4.191 ms) : 0, 4191
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (840.873 ms) : 0, 840873
BytebuddyAgent [candidate] (847.933 ms) : 0, 847933
GlobalTracer [baseline] (230.948 ms) : 0, 230948
GlobalTracer [candidate] (232.508 ms) : 0, 232508
IAST [baseline] (22.46 ms) : 0, 22460
IAST [candidate] (22.626 ms) : 0, 22626
AppSec [baseline] (56.381 ms) : 0, 56381
AppSec [candidate] (57.512 ms) : 0, 57512
Remote Config [baseline] (600.451 µs) : 0, 600
Remote Config [candidate] (628.817 µs) : 0, 629
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.724 ms) : 0, 8724
Debugger [baseline] (4.153 ms) : 0, 4153
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046685
Total [baseline] (10.478 s) : 0, 10478470
Agent [candidate] (1.04 s) : 0, 1039783
Total [candidate] (10.421 s) : 0, 10420560
section appsec
Agent [baseline] (1.188 s) : 0, 1188005
Total [baseline] (10.687 s) : 0, 10687112
Agent [candidate] (1.191 s) : 0, 1190651
Total [candidate] (10.77 s) : 0, 10770405
section iast
Agent [baseline] (1.178 s) : 0, 1178141
Total [baseline] (11.044 s) : 0, 11044459
Agent [candidate] (1.172 s) : 0, 1171556
Total [candidate] (10.949 s) : 0, 10948843
section profiling
Agent [baseline] (1.275 s) : 0, 1274501
Total [baseline] (10.928 s) : 0, 10928277
Agent [candidate] (1.267 s) : 0, 1267307
Total [candidate] (10.861 s) : 0, 10861413
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.053 ms) : 0, 719053
BytebuddyAgent [candidate] (715.836 ms) : 0, 715836
GlobalTracer [baseline] (240.218 ms) : 0, 240218
GlobalTracer [candidate] (239.319 ms) : 0, 239319
AppSec [baseline] (54.774 ms) : 0, 54774
AppSec [candidate] (55.39 ms) : 0, 55390
Remote Config [baseline] (712.196 µs) : 0, 712
Remote Config [candidate] (685.387 µs) : 0, 685
Telemetry [baseline] (11.478 ms) : 0, 11478
Telemetry [candidate] (13.713 ms) : 0, 13713
Debugger [baseline] (4.412 ms) : 0, 4412
section appsec
BytebuddyAgent [baseline] (735.379 ms) : 0, 735379
BytebuddyAgent [candidate] (738.859 ms) : 0, 738859
GlobalTracer [baseline] (236.304 ms) : 0, 236304
GlobalTracer [candidate] (238.257 ms) : 0, 238257
AppSec [baseline] (176.47 ms) : 0, 176470
AppSec [candidate] (178.583 ms) : 0, 178583
Remote Config [baseline] (646.23 µs) : 0, 646
Remote Config [candidate] (675.465 µs) : 0, 675
Telemetry [baseline] (8.231 ms) : 0, 8231
Telemetry [candidate] (8.386 ms) : 0, 8386
Debugger [baseline] (4.306 ms) : 0, 4306
IAST [baseline] (21.335 ms) : 0, 21335
IAST [candidate] (21.669 ms) : 0, 21669
section iast
BytebuddyAgent [baseline] (837.614 ms) : 0, 837614
BytebuddyAgent [candidate] (836.708 ms) : 0, 836708
GlobalTracer [baseline] (231.516 ms) : 0, 231516
GlobalTracer [candidate] (230.309 ms) : 0, 230309
AppSec [baseline] (56.263 ms) : 0, 56263
AppSec [candidate] (57.222 ms) : 0, 57222
Remote Config [baseline] (601.454 µs) : 0, 601
Remote Config [candidate] (623.786 µs) : 0, 624
Telemetry [baseline] (8.851 ms) : 0, 8851
Telemetry [candidate] (8.713 ms) : 0, 8713
Debugger [baseline] (4.201 ms) : 0, 4201
IAST [baseline] (23.063 ms) : 0, 23063
IAST [candidate] (22.965 ms) : 0, 22965
section profiling
BytebuddyAgent [baseline] (710.593 ms) : 0, 710593
BytebuddyAgent [candidate] (712.603 ms) : 0, 712603
GlobalTracer [baseline] (350.609 ms) : 0, 350609
GlobalTracer [candidate] (352.167 ms) : 0, 352167
AppSec [baseline] (54.723 ms) : 0, 54723
AppSec [candidate] (55.18 ms) : 0, 55180
Remote Config [baseline] (707.697 µs) : 0, 708
Remote Config [candidate] (695.958 µs) : 0, 696
Telemetry [baseline] (8.992 ms) : 0, 8992
Telemetry [candidate] (9.202 ms) : 0, 9202
Debugger [baseline] (4.303 ms) : 0, 4303
ProfilingAgent [baseline] (103.007 ms) : 0, 103007
ProfilingAgent [candidate] (96.681 ms) : 0, 96681
Profiling [baseline] (103.035 ms) : 0, 103035
Profiling [candidate] (96.706 ms) : 0, 96706
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section baseline
no_agent (378.006 µs) : 358, 398
. : milestone, 378,
iast (516.227 µs) : 494, 538
. : milestone, 516,
iast_FULL (727.109 µs) : 705, 749
. : milestone, 727,
iast_GLOBAL (562.838 µs) : 540, 586
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (505.861 µs) : 484, 527
. : milestone, 506,
iast_INACTIVE (456.885 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (495.354 µs) : 473, 517
. : milestone, 495,
tracing (458.44 µs) : 437, 480
. : milestone, 458,
section candidate
no_agent (375.951 µs) : 356, 396
. : milestone, 376,
iast (509.708 µs) : 488, 531
. : milestone, 510,
iast_FULL (729.419 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (554.78 µs) : 533, 577
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (502.731 µs) : 481, 524
. : milestone, 503,
iast_INACTIVE (460.937 µs) : 440, 482
. : milestone, 461,
iast_TELEMETRY_OFF (496.784 µs) : 474, 519
. : milestone, 497,
tracing (455.34 µs) : 434, 476
. : milestone, 455,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1380
. : milestone, 1360,
appsec (1.707 ms) : 1683, 1732
. : milestone, 1707,
appsec_no_iast (1.736 ms) : 1713, 1759
. : milestone, 1736,
code_origins (1.667 ms) : 1641, 1694
. : milestone, 1667,
iast (1.51 ms) : 1485, 1535
. : milestone, 1510,
profiling (1.514 ms) : 1489, 1538
. : milestone, 1514,
tracing (1.473 ms) : 1448, 1498
. : milestone, 1473,
section candidate
no_agent (1.347 ms) : 1327, 1367
. : milestone, 1347,
appsec (1.721 ms) : 1697, 1745
. : milestone, 1721,
appsec_no_iast (1.73 ms) : 1706, 1755
. : milestone, 1730,
code_origins (1.67 ms) : 1637, 1704
. : milestone, 1670,
iast (1.494 ms) : 1470, 1518
. : milestone, 1494,
profiling (1.524 ms) : 1501, 1546
. : milestone, 1524,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.348 ms) : 2304, 2393
. : milestone, 2348,
iast (2.116 ms) : 2060, 2171
. : milestone, 2116,
iast_GLOBAL (2.163 ms) : 2107, 2219
. : milestone, 2163,
profiling (1.978 ms) : 1933, 2022
. : milestone, 1978,
tracing (1.951 ms) : 1908, 1994
. : milestone, 1951,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.337 ms) : 2293, 2380
. : milestone, 2337,
iast (2.125 ms) : 2069, 2180
. : milestone, 2125,
iast_GLOBAL (2.153 ms) : 2097, 2208
. : milestone, 2153,
profiling (1.973 ms) : 1930, 2017
. : milestone, 1973,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~fb82f38296, baseline=1.48.0-SNAPSHOT~dfe313464d
dateFormat X
axisFormat %s
section baseline
no_agent (15.693 s) : 15693000, 15693000
. : milestone, 15693000,
appsec (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
iast (19.103 s) : 19103000, 19103000
. : milestone, 19103000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.701 s) : 15701000, 15701000
. : milestone, 15701000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
section candidate
no_agent (15.425 s) : 15425000, 15425000
. : milestone, 15425000,
appsec (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
iast (18.812 s) : 18812000, 18812000
. : milestone, 18812000,
iast_GLOBAL (17.616 s) : 17616000, 17616000
. : milestone, 17616000,
profiling (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
tracing (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Mar 25, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.13.0` -> `2.13.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.2` -> `1.47.3` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.2` -> `1.47.3` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | --- ### Release Notes <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.13.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2131) - \[Fix]: differentiate between main and other variants when rewriting dependencies with Kotlin DSL. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.3`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.3): 1.47.3 ##### Components ##### Profiling - 🐛 🍒 8605 - Make TempLocationManager USER aware ([#​8614](DataDog/dd-trace-java#8614) - [@​mcculls](https://github.com/mcculls)) ##### Instrumentations ##### All other instrumentations - ✨ 🍒 8601 - Introduce cache for peer.hostname lookup ([#​8611](DataDog/dd-trace-java#8611) - [@​mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 270c10cb444c28cb64015d9874ef52d6a175c271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8601 to release/v1.47.x
Motivation
Mitigates potential delays in mapping IP addresses back to their hostnames.
The
peer.hostname
tag feature can also be turned off completely by adding this JVM option:or setting this environment variable: