Clean up the initial code origin set up instrumentation #8667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (328.71 µs) : 277, 380
. : milestone, 329,
basic (321.19 µs) : 309, 333
. : milestone, 321,
loop (10.151 ms) : 10113, 10190
. : milestone, 10151,
section candidate
noprobe (329.143 µs) : 266, 392
. : milestone, 329,
basic (316.503 µs) : 299, 334
. : milestone, 317,
loop (10.118 ms) : 10089, 10147
. : milestone, 10118,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007986
Total [baseline] (10.512 s) : 0, 10512367
Agent [candidate] (1.006 s) : 0, 1005558
Total [candidate] (10.455 s) : 0, 10455223
section appsec
Agent [baseline] (1.154 s) : 0, 1153796
Total [baseline] (10.633 s) : 0, 10633254
Agent [candidate] (1.157 s) : 0, 1156652
Total [candidate] (10.652 s) : 0, 10652442
section iast
Agent [baseline] (1.134 s) : 0, 1133814
Total [baseline] (10.882 s) : 0, 10882199
Agent [candidate] (1.14 s) : 0, 1140079
Total [candidate] (10.874 s) : 0, 10873885
section profiling
Agent [baseline] (1.251 s) : 0, 1250594
Total [baseline] (10.817 s) : 0, 10817417
Agent [candidate] (1.254 s) : 0, 1253934
Total [candidate] (10.733 s) : 0, 10732916
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.88 ms) : 0, 670880
BytebuddyAgent [candidate] (669.616 ms) : 0, 669616
GlobalTracer [baseline] (240.074 ms) : 0, 240074
GlobalTracer [candidate] (239.818 ms) : 0, 239818
AppSec [baseline] (54.637 ms) : 0, 54637
AppSec [candidate] (54.533 ms) : 0, 54533
Debugger [baseline] (6.116 ms) : 0, 6116
Debugger [candidate] (6.131 ms) : 0, 6131
Remote Config [baseline] (716.12 µs) : 0, 716
Remote Config [candidate] (716.772 µs) : 0, 717
Telemetry [baseline] (12.139 ms) : 0, 12139
Telemetry [candidate] (11.484 ms) : 0, 11484
section appsec
BytebuddyAgent [baseline] (691.149 ms) : 0, 691149
BytebuddyAgent [candidate] (693.736 ms) : 0, 693736
GlobalTracer [baseline] (237.287 ms) : 0, 237287
GlobalTracer [candidate] (238.013 ms) : 0, 238013
AppSec [baseline] (176.651 ms) : 0, 176651
AppSec [candidate] (176.557 ms) : 0, 176557
Debugger [baseline] (5.917 ms) : 0, 5917
Debugger [candidate] (5.855 ms) : 0, 5855
Remote Config [baseline] (641.51 µs) : 0, 642
Remote Config [candidate] (631.095 µs) : 0, 631
Telemetry [baseline] (7.862 ms) : 0, 7862
Telemetry [candidate] (7.416 ms) : 0, 7416
IAST [baseline] (21.752 ms) : 0, 21752
IAST [candidate] (21.961 ms) : 0, 21961
section iast
BytebuddyAgent [baseline] (787.699 ms) : 0, 787699
BytebuddyAgent [candidate] (791.905 ms) : 0, 791905
GlobalTracer [baseline] (229.399 ms) : 0, 229399
GlobalTracer [candidate] (230.848 ms) : 0, 230848
AppSec [baseline] (56.408 ms) : 0, 56408
AppSec [candidate] (56.511 ms) : 0, 56511
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (5.912 ms) : 0, 5912
Remote Config [baseline] (575.314 µs) : 0, 575
Remote Config [candidate] (593.588 µs) : 0, 594
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.885 ms) : 0, 7885
IAST [baseline] (22.613 ms) : 0, 22613
IAST [candidate] (22.957 ms) : 0, 22957
section profiling
BytebuddyAgent [baseline] (661.63 ms) : 0, 661630
BytebuddyAgent [candidate] (663.062 ms) : 0, 663062
GlobalTracer [baseline] (374.014 ms) : 0, 374014
GlobalTracer [candidate] (375.464 ms) : 0, 375464
AppSec [baseline] (53.978 ms) : 0, 53978
AppSec [candidate] (53.124 ms) : 0, 53124
Debugger [baseline] (6.143 ms) : 0, 6143
Debugger [candidate] (6.07 ms) : 0, 6070
Remote Config [baseline] (653.338 µs) : 0, 653
Remote Config [candidate] (643.161 µs) : 0, 643
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.096 ms) : 0, 8096
ProfilingAgent [baseline] (95.792 ms) : 0, 95792
ProfilingAgent [candidate] (97.327 ms) : 0, 97327
Profiling [baseline] (95.815 ms) : 0, 95815
Profiling [candidate] (97.351 ms) : 0, 97351
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022431
Total [baseline] (8.675 s) : 0, 8675321
Agent [candidate] (1.008 s) : 0, 1007634
Total [candidate] (8.694 s) : 0, 8694360
section iast
Agent [baseline] (1.134 s) : 0, 1133638
Total [baseline] (9.18 s) : 0, 9180155
Agent [candidate] (1.136 s) : 0, 1136197
Total [candidate] (9.184 s) : 0, 9183716
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.135 s) : 0, 1135058
Total [baseline] (9.163 s) : 0, 9163293
Agent [candidate] (1.138 s) : 0, 1138063
Total [candidate] (9.184 s) : 0, 9184001
section iast_TELEMETRY_OFF
Agent [baseline] (1.133 s) : 0, 1132901
Total [baseline] (9.17 s) : 0, 9169911
Agent [candidate] (1.136 s) : 0, 1136493
Total [candidate] (9.16 s) : 0, 9159522
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.886 ms) : 0, 680886
BytebuddyAgent [candidate] (672.1 ms) : 0, 672100
GlobalTracer [baseline] (242.962 ms) : 0, 242962
GlobalTracer [candidate] (240.423 ms) : 0, 240423
AppSec [baseline] (55.428 ms) : 0, 55428
AppSec [candidate] (54.825 ms) : 0, 54825
Debugger [baseline] (6.979 ms) : 0, 6979
Debugger [candidate] (6.846 ms) : 0, 6846
Remote Config [baseline] (730.798 µs) : 0, 731
Remote Config [candidate] (713.449 µs) : 0, 713
Telemetry [baseline] (11.583 ms) : 0, 11583
Telemetry [candidate] (9.268 ms) : 0, 9268
section iast
BytebuddyAgent [baseline] (787.956 ms) : 0, 787956
BytebuddyAgent [candidate] (790.081 ms) : 0, 790081
GlobalTracer [baseline] (229.253 ms) : 0, 229253
GlobalTracer [candidate] (229.918 ms) : 0, 229918
IAST [baseline] (22.72 ms) : 0, 22720
IAST [candidate] (22.611 ms) : 0, 22611
AppSec [baseline] (56.063 ms) : 0, 56063
AppSec [candidate] (55.896 ms) : 0, 55896
Debugger [baseline] (5.844 ms) : 0, 5844
Debugger [candidate] (5.827 ms) : 0, 5827
Remote Config [baseline] (586.281 µs) : 0, 586
Remote Config [candidate] (580.932 µs) : 0, 581
Telemetry [baseline] (7.831 ms) : 0, 7831
Telemetry [candidate] (7.855 ms) : 0, 7855
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.508 ms) : 0, 788508
BytebuddyAgent [candidate] (790.539 ms) : 0, 790539
GlobalTracer [baseline] (229.722 ms) : 0, 229722
GlobalTracer [candidate] (230.343 ms) : 0, 230343
IAST [baseline] (22.754 ms) : 0, 22754
IAST [candidate] (22.859 ms) : 0, 22859
AppSec [baseline] (56.342 ms) : 0, 56342
AppSec [candidate] (56.368 ms) : 0, 56368
Debugger [baseline] (5.879 ms) : 0, 5879
Debugger [candidate] (5.905 ms) : 0, 5905
Remote Config [baseline] (593.589 µs) : 0, 594
Remote Config [candidate] (651.001 µs) : 0, 651
Telemetry [baseline] (7.887 ms) : 0, 7887
Telemetry [candidate] (7.902 ms) : 0, 7902
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.667 ms) : 0, 786667
BytebuddyAgent [candidate] (789.148 ms) : 0, 789148
GlobalTracer [baseline] (229.865 ms) : 0, 229865
GlobalTracer [candidate] (230.972 ms) : 0, 230972
IAST [baseline] (22.374 ms) : 0, 22374
IAST [candidate] (22.327 ms) : 0, 22327
AppSec [baseline] (56.397 ms) : 0, 56397
AppSec [candidate] (56.363 ms) : 0, 56363
Debugger [baseline] (5.912 ms) : 0, 5912
Debugger [candidate] (5.885 ms) : 0, 5885
Remote Config [baseline] (608.651 µs) : 0, 609
Remote Config [candidate] (599.21 µs) : 0, 599
Telemetry [baseline] (7.766 ms) : 0, 7766
Telemetry [candidate] (7.746 ms) : 0, 7746
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1379
. : milestone, 1358,
appsec (1.725 ms) : 1701, 1749
. : milestone, 1725,
appsec_no_iast (1.727 ms) : 1704, 1750
. : milestone, 1727,
code_origins (1.661 ms) : 1635, 1687
. : milestone, 1661,
iast (1.513 ms) : 1488, 1537
. : milestone, 1513,
profiling (1.573 ms) : 1548, 1598
. : milestone, 1573,
tracing (1.497 ms) : 1473, 1521
. : milestone, 1497,
section candidate
no_agent (1.36 ms) : 1341, 1379
. : milestone, 1360,
appsec (1.726 ms) : 1702, 1750
. : milestone, 1726,
appsec_no_iast (1.73 ms) : 1707, 1753
. : milestone, 1730,
code_origins (1.67 ms) : 1643, 1696
. : milestone, 1670,
iast (1.513 ms) : 1488, 1537
. : milestone, 1513,
profiling (1.514 ms) : 1491, 1538
. : milestone, 1514,
tracing (1.48 ms) : 1455, 1506
. : milestone, 1480,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~f36ecd23d0, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (378.732 µs) : 358, 399
. : milestone, 379,
iast (524.009 µs) : 501, 547
. : milestone, 524,
iast_FULL (733.803 µs) : 711, 757
. : milestone, 734,
iast_GLOBAL (561.459 µs) : 538, 585
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (508.583 µs) : 486, 531
. : milestone, 509,
iast_INACTIVE (463.163 µs) : 441, 485
. : milestone, 463,
iast_TELEMETRY_OFF (504.309 µs) : 482, 527
. : milestone, 504,
tracing (459.842 µs) : 438, 482
. : milestone, 460,
section candidate
no_agent (376.021 µs) : 356, 396
. : milestone, 376,
iast (520.867 µs) : 498, 544
. : milestone, 521,
iast_FULL (727.242 µs) : 704, 751
. : milestone, 727,
iast_GLOBAL (576.354 µs) : 552, 601
. : milestone, 576,
iast_HARDCODED_SECRET_DISABLED (521.432 µs) : 499, 544
. : milestone, 521,
iast_INACTIVE (468.703 µs) : 446, 491
. : milestone, 469,
iast_TELEMETRY_OFF (497.875 µs) : 476, 520
. : milestone, 498,
tracing (456.2 µs) : 434, 478
. : milestone, 456,
Dacapo |
evanchooly
force-pushed
the
whiteGlove
branch
3 times, most recently
from
6c689de to
7a1aa1c
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
evanchooly
changed the title
evanchooly
added
tag: no release notes
evanchooly
force-pushed
the
whiteGlove
branch
4 times, most recently
from
1435d79 to
6c654a1
Compare
jpbempel
reviewed
Apr 23, 2025
| AbstractInsnNode next = iterator.next(); | ||
| if (buildDescription(next).equals(MARKER)) { | ||
| insertionPoint = next.getPrevious(); | ||
| while (buildDescription(next = iterator.next()).equals(CAPTURE)) {} |
There was a problem hiding this comment.
I think it should loop while the current instruction is NOT equals to CAPTURE, no ?
There was a problem hiding this comment.
yup. pushed the fix earlier. that ! is so easy to miss. 😄
jpbempel
reviewed
Apr 23, 2025
| AbstractInsnNode next = iterator.next(); | ||
| if (buildDescription(next).equals(MARKER)) { | ||
| insertionPoint = next.getPrevious(); | ||
| while (!buildDescription(next = iterator.next()).equals(CAPTURE)) {} |
There was a problem hiding this comment.
what happen if we reach the end of the instruction list (no CAPTURE detected)?
There was a problem hiding this comment.
all the instructions get copied over and insertionPoint remains null which would result in the bytecode getting prepended to the method via findInsertionPoint()
There was a problem hiding this comment.
this actually happens a fair bit in CodeOriginTest with the way we're defining many of those probe locations.
There was a problem hiding this comment.
my point was, we are calling iterator.next() in a loop without checking iterator.hasNext()
jpbempel
approved these changes
Apr 28, 2025
| methodNode.instructions = list; | ||
| return insertionPoint; | ||
| } catch (Exception e) { | ||
| return null; |
There was a problem hiding this comment.
would log something in debug level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]