Skip to content

Add support for @key and @value for Map filtering #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for @key and @value for Map filtering #8669

wants to merge 1 commit into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Apr 4, 2025 •
edited by jira bot
Loading

What Does This Do

Introduce 2 synthetic variables in Expression Language:

  • @key
  • @value
    to reference directly key or value when filtering on a map (filter, any, all) on top of existing @it variable. fix pretty print for filtering expression to add curly braces

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3420

@jpbempel jpbempel added type: enhancement comp: debugger Dynamic Instrumentation labels Apr 4, 2025
@jpbempel jpbempel requested a review from a team as a code owner April 4, 2025 12:25
@jpbempel jpbempel requested review from ojung and evanchooly and removed request for a team April 4, 2025 12:25
@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1743773209 1743773592
end_time 2025-04-04T13:28:06 2025-04-04T13:34:29
git_branch master jpbempel/kv-in-el
git_commit_sha 2dfc8ee ac4c312
start_time 2025-04-04T13:26:50 2025-04-04T13:33:13
See matching parameters
Baseline Candidate
ci_job_id 881389995 881389995
ci_pipeline_id 61098442 61098442
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1743771902 1743771902

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-443.281µs; -285.486µs] or [-4.156%; -2.677%]		 better
[-471.035µs; -296.888µs] or [-4.340%; -2.735%]		 better
[-442.157µs; -259.084µs] or [-4.049%; -2.373%]		 better
[-586.846µs; -180.374µs] or [-5.202%; -1.599%]		 better
[+2.566op/s; +4.359op/s] or [+2.810%; +4.773%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-21.178µs; +18.171µs] or [-7.849%; +6.734%]		 unstable
[-35.628µs; +27.473µs] or [-11.429%; +8.813%]		 unstable
[-46.899µs; +39.039µs] or [-14.391%; +11.979%]		 unstable
[-88.929µs; +100.294µs] or [-15.072%; +16.998%]		 same
scenario:basic same same same unstable
[-45.645µs; +38.850µs] or [-8.508%; +7.241%]		 unstable
[-141.632op/s; +141.632op/s] or [-5.524%; +5.524%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (311.719 µs) : 279, 345
.   : milestone, 312,
basic (307.937 µs) : 298, 318
.   : milestone, 308,
loop (10.854 ms) : 10818, 10889
.   : milestone, 10854,
section candidate
noprobe (307.642 µs) : 281, 335
.   : milestone, 308,
basic (301.899 µs) : 292, 311
.   : milestone, 302,
loop (10.47 ms) : 10361, 10578
.   : milestone, 10470,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 311.719 µs [278.926 µs, 344.513 µs]
basic 307.937 µs [298.148 µs, 317.725 µs]
loop 10.854 ms [10.818 ms, 10.889 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 307.642 µs [280.56 µs, 334.723 µs]
basic 301.899 µs [292.382 µs, 311.415 µs]
loop 10.47 ms [10.361 ms, 10.578 ms]

@jpbempel
Add support for @key and @value for Map filtering
ac4c312 
Introduce 2 synthetic variables in Expression Language:
 - @key
 - @value
to reference directly key or value when filtering on a map
(filter, any, all) on top of existing @it variable.
fix pretty print for filtering expression to add curly braces
@jpbempel jpbempel force-pushed the jpbempel/kv-in-el branch from cc7c151 to ac4c312 Compare April 4, 2025 13:05
@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/kv-in-el
git_commit_date 1743764529 1743771902
git_commit_sha 2dfc8ee ac4c312
release_version 1.48.0-SNAPSHOT~2dfc8eeba9 1.48.0-SNAPSHOT~ac4c312ffb
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743775029 1743775029
ci_job_id 881389983 881389983
ci_pipeline_id 61098442 61098442
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-d-paxy53-project-304-concurrent-0-dx60w18s 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-d-paxy53-project-304-concurrent-0-dx60w18s 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058284
Total [baseline] (8.694 s) : 0, 8694131
Agent [candidate] (1.053 s) : 0, 1053198
Total [candidate] (8.682 s) : 0, 8681588
section iast
Agent [baseline] (1.184 s) : 0, 1183703
Total [baseline] (9.226 s) : 0, 9226388
Agent [candidate] (1.186 s) : 0, 1186099
Total [candidate] (9.269 s) : 0, 9268709
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185928
Total [baseline] (9.237 s) : 0, 9236514
Agent [candidate] (1.194 s) : 0, 1194091
Total [candidate] (9.265 s) : 0, 9265300
section iast_TELEMETRY_OFF
Agent [baseline] (1.183 s) : 0, 1183076
Total [baseline] (9.288 s) : 0, 9288180
Agent [candidate] (1.181 s) : 0, 1181061
Total [candidate] (9.256 s) : 0, 9256283
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.184 s 125.419 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 127.644 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.183 s 124.792 ms (11.8%)
Total tracing 8.694 s -
Total iast 9.226 s 532.256 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.237 s 542.383 ms (6.2%)
Total iast_TELEMETRY_OFF 9.288 s 594.049 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.186 s 132.901 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 140.893 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.181 s 127.863 ms (12.1%)
Total tracing 8.682 s -
Total iast 9.269 s 587.12 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.265 s 583.711 ms (6.7%)
Total iast_TELEMETRY_OFF 9.256 s 574.695 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.98 ms) : 0, 722980
BytebuddyAgent [candidate] (719.581 ms) : 0, 719581
GlobalTracer [baseline] (240.049 ms) : 0, 240049
GlobalTracer [candidate] (240.288 ms) : 0, 240288
AppSec [baseline] (54.714 ms) : 0, 54714
AppSec [candidate] (55.358 ms) : 0, 55358
Debugger [baseline] (4.44 ms) : 0, 4440
Debugger [candidate] (4.459 ms) : 0, 4459
Remote Config [baseline] (695.782 µs) : 0, 696
Remote Config [candidate] (688.577 µs) : 0, 689
Telemetry [baseline] (14.509 ms) : 0, 14509
Telemetry [candidate] (12.195 ms) : 0, 12195
section iast
BytebuddyAgent [baseline] (841.296 ms) : 0, 841296
BytebuddyAgent [candidate] (842.822 ms) : 0, 842822
GlobalTracer [baseline] (230.074 ms) : 0, 230074
GlobalTracer [candidate] (230.346 ms) : 0, 230346
IAST [baseline] (22.637 ms) : 0, 22637
IAST [candidate] (22.569 ms) : 0, 22569
AppSec [baseline] (55.604 ms) : 0, 55604
AppSec [candidate] (56.192 ms) : 0, 56192
Debugger [baseline] (4.097 ms) : 0, 4097
Debugger [candidate] (4.131 ms) : 0, 4131
Remote Config [baseline] (595.993 µs) : 0, 596
Remote Config [candidate] (619.146 µs) : 0, 619
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.868 ms) : 0, 8868
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.182 ms) : 0, 842182
BytebuddyAgent [candidate] (846.888 ms) : 0, 846888
GlobalTracer [baseline] (230.713 ms) : 0, 230713
GlobalTracer [candidate] (232.916 ms) : 0, 232916
IAST [baseline] (22.747 ms) : 0, 22747
IAST [candidate] (23.308 ms) : 0, 23308
AppSec [baseline] (55.867 ms) : 0, 55867
AppSec [candidate] (56.538 ms) : 0, 56538
Debugger [baseline] (4.159 ms) : 0, 4159
Debugger [candidate] (4.247 ms) : 0, 4247
Remote Config [baseline] (605.936 µs) : 0, 606
Remote Config [candidate] (630.4 µs) : 0, 630
Telemetry [baseline] (8.732 ms) : 0, 8732
Telemetry [candidate] (8.944 ms) : 0, 8944
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.638 ms) : 0, 838638
BytebuddyAgent [candidate] (838.015 ms) : 0, 838015
GlobalTracer [baseline] (230.864 ms) : 0, 230864
GlobalTracer [candidate] (230.715 ms) : 0, 230715
IAST [baseline] (22.609 ms) : 0, 22609
IAST [candidate] (22.302 ms) : 0, 22302
AppSec [baseline] (56.63 ms) : 0, 56630
AppSec [candidate] (56.015 ms) : 0, 56015
Debugger [baseline] (4.21 ms) : 0, 4210
Debugger [candidate] (4.173 ms) : 0, 4173
Remote Config [baseline] (606.831 µs) : 0, 607
Remote Config [candidate] (623.935 µs) : 0, 624
Telemetry [baseline] (8.717 ms) : 0, 8717
Telemetry [candidate] (8.773 ms) : 0, 8773
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059956
Total [baseline] (10.499 s) : 0, 10498629
Agent [candidate] (1.057 s) : 0, 1057375
Total [candidate] (10.479 s) : 0, 10478763
section appsec
Agent [baseline] (1.199 s) : 0, 1198728
Total [baseline] (10.785 s) : 0, 10784847
Agent [candidate] (1.194 s) : 0, 1194235
Total [candidate] (10.826 s) : 0, 10825569
section iast
Agent [baseline] (1.186 s) : 0, 1185653
Total [baseline] (11.086 s) : 0, 11085775
Agent [candidate] (1.182 s) : 0, 1182465
Total [candidate] (11.051 s) : 0, 11050637
section profiling
Agent [baseline] (1.285 s) : 0, 1285415
Total [baseline] (10.87 s) : 0, 10870324
Agent [candidate] (1.286 s) : 0, 1286367
Total [candidate] (10.95 s) : 0, 10949587
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.199 s 138.771 ms (13.1%)
Agent iast 1.186 s 125.697 ms (11.9%)
Agent profiling 1.285 s 225.459 ms (21.3%)
Total tracing 10.499 s -
Total appsec 10.785 s 286.218 ms (2.7%)
Total iast 11.086 s 587.145 ms (5.6%)
Total profiling 10.87 s 371.695 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.194 s 136.86 ms (12.9%)
Agent iast 1.182 s 125.09 ms (11.8%)
Agent profiling 1.286 s 228.992 ms (21.7%)
Total tracing 10.479 s -
Total appsec 10.826 s 346.806 ms (3.3%)
Total iast 11.051 s 571.874 ms (5.5%)
Total profiling 10.95 s 470.824 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.443 ms) : 0, 722443
BytebuddyAgent [candidate] (721.055 ms) : 0, 721055
GlobalTracer [baseline] (240.149 ms) : 0, 240149
GlobalTracer [candidate] (240.183 ms) : 0, 240183
AppSec [baseline] (54.682 ms) : 0, 54682
AppSec [candidate] (54.492 ms) : 0, 54492
Debugger [baseline] (4.391 ms) : 0, 4391
Debugger [candidate] (4.462 ms) : 0, 4462
Remote Config [baseline] (692.684 µs) : 0, 693
Remote Config [candidate] (701.745 µs) : 0, 702
Telemetry [baseline] (16.69 ms) : 0, 16690
Telemetry [candidate] (15.808 ms) : 0, 15808
section appsec
BytebuddyAgent [baseline] (740.666 ms) : 0, 740666
BytebuddyAgent [candidate] (737.857 ms) : 0, 737857
GlobalTracer [baseline] (236.638 ms) : 0, 236638
GlobalTracer [candidate] (236.047 ms) : 0, 236047
AppSec [baseline] (176.801 ms) : 0, 176801
AppSec [candidate] (176.017 ms) : 0, 176017
Debugger [baseline] (4.276 ms) : 0, 4276
Debugger [candidate] (4.29 ms) : 0, 4290
Remote Config [baseline] (640.762 µs) : 0, 641
Remote Config [candidate] (653.462 µs) : 0, 653
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (8.216 ms) : 0, 8216
IAST [baseline] (21.211 ms) : 0, 21211
IAST [candidate] (21.398 ms) : 0, 21398
section iast
BytebuddyAgent [baseline] (842.139 ms) : 0, 842139
BytebuddyAgent [candidate] (839.273 ms) : 0, 839273
GlobalTracer [baseline] (230.611 ms) : 0, 230611
GlobalTracer [candidate] (230.346 ms) : 0, 230346
AppSec [baseline] (55.759 ms) : 0, 55759
AppSec [candidate] (56.054 ms) : 0, 56054
Debugger [baseline] (4.162 ms) : 0, 4162
Debugger [candidate] (4.137 ms) : 0, 4137
Remote Config [baseline] (611.236 µs) : 0, 611
Remote Config [candidate] (612.614 µs) : 0, 613
Telemetry [baseline] (8.815 ms) : 0, 8815
Telemetry [candidate] (8.759 ms) : 0, 8759
IAST [baseline] (22.61 ms) : 0, 22610
IAST [candidate] (22.808 ms) : 0, 22808
section profiling
BytebuddyAgent [baseline] (716.124 ms) : 0, 716124
BytebuddyAgent [candidate] (716.059 ms) : 0, 716059
GlobalTracer [baseline] (350.476 ms) : 0, 350476
GlobalTracer [candidate] (352.704 ms) : 0, 352704
AppSec [baseline] (54.054 ms) : 0, 54054
AppSec [candidate] (53.545 ms) : 0, 53545
Debugger [baseline] (4.333 ms) : 0, 4333
Debugger [candidate] (4.35 ms) : 0, 4350
Remote Config [baseline] (705.086 µs) : 0, 705
Remote Config [candidate] (703.414 µs) : 0, 703
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (9.103 ms) : 0, 9103
ProfilingAgent [baseline] (102.174 ms) : 0, 102174
ProfilingAgent [candidate] (103.717 ms) : 0, 103717
Profiling [baseline] (102.199 ms) : 0, 102199
Profiling [candidate] (103.744 ms) : 0, 103744
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-04T13:26:52 2025-04-04T13:34:35
git_branch master jpbempel/kv-in-el
git_commit_date 1743764529 1743771902
git_commit_sha 2dfc8ee ac4c312
release_version 1.48.0-SNAPSHOT~2dfc8eeba9 1.48.0-SNAPSHOT~ac4c312ffb
start_time 2025-04-04T13:26:38 2025-04-04T13:34:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743774072 1743774072
ci_job_id 881389985 881389985
ci_pipeline_id 61098442 61098442
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-d-paxy53-project-304-concurrent-1-gy46tuzq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-d-paxy53-project-304-concurrent-1-gy46tuzq 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.703 µs) : 360, 404
.   : milestone, 382,
iast (508.597 µs) : 487, 530
.   : milestone, 509,
iast_FULL (734.523 µs) : 712, 757
.   : milestone, 735,
iast_GLOBAL (565.112 µs) : 542, 589
.   : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (513.518 µs) : 491, 536
.   : milestone, 514,
iast_INACTIVE (463.262 µs) : 442, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (494.507 µs) : 473, 516
.   : milestone, 495,
tracing (465.038 µs) : 444, 486
.   : milestone, 465,
section candidate
no_agent (377.387 µs) : 358, 397
.   : milestone, 377,
iast (508.022 µs) : 486, 530
.   : milestone, 508,
iast_FULL (724.902 µs) : 702, 747
.   : milestone, 725,
iast_GLOBAL (555.028 µs) : 534, 576
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (510.673 µs) : 489, 533
.   : milestone, 511,
iast_INACTIVE (468.114 µs) : 447, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (493.517 µs) : 472, 515
.   : milestone, 494,
tracing (454.338 µs) : 434, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.703 µs [359.634 µs, 403.773 µs] -
iast 508.597 µs [486.865 µs, 530.329 µs] 126.893 µs (33.2%)
iast_FULL 734.523 µs [712.424 µs, 756.621 µs] 352.819 µs (92.4%)
iast_GLOBAL 565.112 µs [541.519 µs, 588.704 µs] 183.408 µs (48.0%)
iast_HARDCODED_SECRET_DISABLED 513.518 µs [491.473 µs, 535.562 µs] 131.814 µs (34.5%)
iast_INACTIVE 463.262 µs [441.922 µs, 484.601 µs] 81.558 µs (21.4%)
iast_TELEMETRY_OFF 494.507 µs [473.046 µs, 515.967 µs] 112.803 µs (29.6%)
tracing 465.038 µs [444.401 µs, 485.676 µs] 83.335 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.387 µs [357.659 µs, 397.115 µs] -
iast 508.022 µs [486.176 µs, 529.868 µs] 130.635 µs (34.6%)
iast_FULL 724.902 µs [702.443 µs, 747.361 µs] 347.514 µs (92.1%)
iast_GLOBAL 555.028 µs [533.583 µs, 576.473 µs] 177.641 µs (47.1%)
iast_HARDCODED_SECRET_DISABLED 510.673 µs [488.699 µs, 532.648 µs] 133.286 µs (35.3%)
iast_INACTIVE 468.114 µs [446.586 µs, 489.643 µs] 90.727 µs (24.0%)
iast_TELEMETRY_OFF 493.517 µs [471.888 µs, 515.146 µs] 116.13 µs (30.8%)
tracing 454.338 µs [433.544 µs, 475.131 µs] 76.95 µs (20.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1373
.   : milestone, 1353,
appsec (1.719 ms) : 1696, 1742
.   : milestone, 1719,
appsec_no_iast (1.732 ms) : 1707, 1758
.   : milestone, 1732,
code_origins (1.667 ms) : 1640, 1693
.   : milestone, 1667,
iast (1.521 ms) : 1497, 1545
.   : milestone, 1521,
profiling (1.502 ms) : 1479, 1526
.   : milestone, 1502,
tracing (1.502 ms) : 1478, 1526
.   : milestone, 1502,
section candidate
no_agent (1.35 ms) : 1331, 1370
.   : milestone, 1350,
appsec (1.727 ms) : 1703, 1751
.   : milestone, 1727,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
code_origins (1.692 ms) : 1666, 1719
.   : milestone, 1692,
iast (1.521 ms) : 1496, 1546
.   : milestone, 1521,
profiling (1.511 ms) : 1487, 1534
.   : milestone, 1511,
tracing (1.487 ms) : 1462, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.373 ms] -
appsec 1.719 ms [1.696 ms, 1.742 ms] 366.51 µs (27.1%)
appsec_no_iast 1.732 ms [1.707 ms, 1.758 ms] 379.471 µs (28.1%)
code_origins 1.667 ms [1.64 ms, 1.693 ms] 313.894 µs (23.2%)
iast 1.521 ms [1.497 ms, 1.545 ms] 168.052 µs (12.4%)
profiling 1.502 ms [1.479 ms, 1.526 ms] 149.833 µs (11.1%)
tracing 1.502 ms [1.478 ms, 1.526 ms] 149.124 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.37 ms] -
appsec 1.727 ms [1.703 ms, 1.751 ms] 376.851 µs (27.9%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 385.991 µs (28.6%)
code_origins 1.692 ms [1.666 ms, 1.719 ms] 341.746 µs (25.3%)
iast 1.521 ms [1.496 ms, 1.546 ms] 170.66 µs (12.6%)
profiling 1.511 ms [1.487 ms, 1.534 ms] 160.257 µs (11.9%)
tracing 1.487 ms [1.462 ms, 1.511 ms] 136.45 µs (10.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/kv-in-el
git_commit_date 1743764529 1743771902
git_commit_sha 2dfc8ee ac4c312
release_version 1.48.0-SNAPSHOT~2dfc8eeba9 1.48.0-SNAPSHOT~ac4c312ffb
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1743774576 1743774576
ci_job_id 881389987 881389987
ci_pipeline_id 61098442 61098442
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-d-paxy53-project-304-concurrent-2-c96c2xbl 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-d-paxy53-project-304-concurrent-2-c96c2xbl 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.37 ms) : 2324, 2417
.   : milestone, 2370,
iast (2.138 ms) : 2080, 2197
.   : milestone, 2138,
iast_GLOBAL (2.19 ms) : 2131, 2249
.   : milestone, 2190,
profiling (2.003 ms) : 1956, 2050
.   : milestone, 2003,
tracing (1.972 ms) : 1927, 2017
.   : milestone, 1972,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.367 ms) : 2320, 2413
.   : milestone, 2367,
iast (2.147 ms) : 2088, 2206
.   : milestone, 2147,
iast_GLOBAL (2.192 ms) : 2133, 2252
.   : milestone, 2192,
profiling (2.017 ms) : 1970, 2065
.   : milestone, 2017,
tracing (1.977 ms) : 1931, 2022
.   : milestone, 1977,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.37 ms [2.324 ms, 2.417 ms] 903.478 µs (61.6%)
iast 2.138 ms [2.08 ms, 2.197 ms] 671.661 µs (45.8%)
iast_GLOBAL 2.19 ms [2.131 ms, 2.249 ms] 723.455 µs (49.3%)
profiling 2.003 ms [1.956 ms, 2.05 ms] 536.177 µs (36.6%)
tracing 1.972 ms [1.927 ms, 2.017 ms] 505.61 µs (34.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.367 ms [2.32 ms, 2.413 ms] 897.769 µs (61.1%)
iast 2.147 ms [2.088 ms, 2.206 ms] 678.285 µs (46.2%)
iast_GLOBAL 2.192 ms [2.133 ms, 2.252 ms] 723.541 µs (49.3%)
profiling 2.017 ms [1.97 ms, 2.065 ms] 548.616 µs (37.4%)
tracing 1.977 ms [1.931 ms, 2.022 ms] 507.746 µs (34.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ac4c312ffb, baseline=1.48.0-SNAPSHOT~2dfc8eeba9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
appsec (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
iast (19.086 s) : 19086000, 19086000
.   : milestone, 19086000,
iast_GLOBAL (17.864 s) : 17864000, 17864000
.   : milestone, 17864000,
profiling (15.681 s) : 15681000, 15681000
.   : milestone, 15681000,
tracing (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
section candidate
no_agent (15.552 s) : 15552000, 15552000
.   : milestone, 15552000,
appsec (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
iast (18.406 s) : 18406000, 18406000
.   : milestone, 18406000,
iast_GLOBAL (18.108 s) : 18108000, 18108000
.   : milestone, 18108000,
profiling (15.727 s) : 15727000, 15727000
.   : milestone, 15727000,
tracing (14.814 s) : 14814000, 14814000
.   : milestone, 14814000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.381 s [15.381 s, 15.381 s] -
appsec 15.019 s [15.019 s, 15.019 s] -362.0 ms (-2.4%)
iast 19.086 s [19.086 s, 19.086 s] 3.705 s (24.1%)
iast_GLOBAL 17.864 s [17.864 s, 17.864 s] 2.483 s (16.1%)
profiling 15.681 s [15.681 s, 15.681 s] 300.0 ms (2.0%)
tracing 15.093 s [15.093 s, 15.093 s] -288.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.552 s [15.552 s, 15.552 s] -
appsec 14.817 s [14.817 s, 14.817 s] -735.0 ms (-4.7%)
iast 18.406 s [18.406 s, 18.406 s] 2.854 s (18.4%)
iast_GLOBAL 18.108 s [18.108 s, 18.108 s] 2.556 s (16.4%)
profiling 15.727 s [15.727 s, 15.727 s] 175.0 ms (1.1%)
tracing 14.814 s [14.814 s, 14.814 s] -738.0 ms (-4.7%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly