-
Notifications
You must be signed in to change notification settings - Fork 300
Add additional debug logging related to JPS #8718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MattAlp
wants to merge
3
commits into
master
Choose a base branch
from
mattalp/additional-jvmstat-telemetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062752
Total [baseline] (10.597 s) : 0, 10596963
Agent [candidate] (1.06 s) : 0, 1059756
Total [candidate] (10.554 s) : 0, 10554457
section appsec
Agent [baseline] (1.203 s) : 0, 1203104
Total [baseline] (10.817 s) : 0, 10816905
Agent [candidate] (1.214 s) : 0, 1214333
Total [candidate] (10.834 s) : 0, 10833543
section iast
Agent [baseline] (1.197 s) : 0, 1196651
Total [baseline] (11.047 s) : 0, 11047423
Agent [candidate] (1.189 s) : 0, 1189149
Total [candidate] (10.996 s) : 0, 10995862
section profiling
Agent [baseline] (1.309 s) : 0, 1309328
Total [baseline] (11.074 s) : 0, 11074321
Agent [candidate] (1.323 s) : 0, 1322568
Total [candidate] (10.959 s) : 0, 10958549
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.248 ms) : 0, 724248
BytebuddyAgent [candidate] (723.968 ms) : 0, 723968
GlobalTracer [baseline] (239.971 ms) : 0, 239971
GlobalTracer [candidate] (239.768 ms) : 0, 239768
AppSec [baseline] (55.532 ms) : 0, 55532
AppSec [candidate] (55.144 ms) : 0, 55144
Debugger [baseline] (5.09 ms) : 0, 5090
Debugger [candidate] (6.555 ms) : 0, 6555
Remote Config [baseline] (705.856 µs) : 0, 706
Remote Config [candidate] (701.117 µs) : 0, 701
Telemetry [baseline] (13.653 ms) : 0, 13653
Telemetry [candidate] (9.991 ms) : 0, 9991
section appsec
BytebuddyAgent [baseline] (743.084 ms) : 0, 743084
BytebuddyAgent [candidate] (750.152 ms) : 0, 750152
GlobalTracer [baseline] (237.104 ms) : 0, 237104
GlobalTracer [candidate] (239.151 ms) : 0, 239151
AppSec [baseline] (175.34 ms) : 0, 175340
AppSec [candidate] (176.859 ms) : 0, 176859
Debugger [baseline] (4.223 ms) : 0, 4223
Debugger [candidate] (4.236 ms) : 0, 4236
Remote Config [baseline] (628.624 µs) : 0, 629
Remote Config [candidate] (646.653 µs) : 0, 647
Telemetry [baseline] (8.157 ms) : 0, 8157
Telemetry [candidate] (8.243 ms) : 0, 8243
IAST [baseline] (21.933 ms) : 0, 21933
IAST [candidate] (22.338 ms) : 0, 22338
section iast
BytebuddyAgent [baseline] (848.78 ms) : 0, 848780
BytebuddyAgent [candidate] (842.73 ms) : 0, 842730
GlobalTracer [baseline] (231.41 ms) : 0, 231410
GlobalTracer [candidate] (229.935 ms) : 0, 229935
AppSec [baseline] (53.218 ms) : 0, 53218
AppSec [candidate] (54.879 ms) : 0, 54879
Debugger [baseline] (4.252 ms) : 0, 4252
Debugger [candidate] (4.272 ms) : 0, 4272
Remote Config [baseline] (614.663 µs) : 0, 615
Remote Config [candidate] (605.433 µs) : 0, 605
Telemetry [baseline] (8.843 ms) : 0, 8843
Telemetry [candidate] (8.76 ms) : 0, 8760
IAST [baseline] (24.347 ms) : 0, 24347
IAST [candidate] (22.889 ms) : 0, 22889
section profiling
ProfilingAgent [baseline] (101.88 ms) : 0, 101880
ProfilingAgent [candidate] (103.057 ms) : 0, 103057
BytebuddyAgent [baseline] (714.111 ms) : 0, 714111
BytebuddyAgent [candidate] (720.475 ms) : 0, 720475
GlobalTracer [baseline] (374.995 ms) : 0, 374995
GlobalTracer [candidate] (380.015 ms) : 0, 380015
AppSec [baseline] (54.156 ms) : 0, 54156
AppSec [candidate] (54.017 ms) : 0, 54017
Debugger [baseline] (4.388 ms) : 0, 4388
Debugger [candidate] (4.469 ms) : 0, 4469
Remote Config [baseline] (667.538 µs) : 0, 668
Remote Config [candidate] (670.407 µs) : 0, 670
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (9.099 ms) : 0, 9099
Profiling [baseline] (101.906 ms) : 0, 101906
Profiling [candidate] (103.083 ms) : 0, 103083
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061998
Total [baseline] (8.694 s) : 0, 8693990
Agent [candidate] (1.067 s) : 0, 1066556
Total [candidate] (8.735 s) : 0, 8734535
section iast
Agent [baseline] (1.195 s) : 0, 1194606
Total [baseline] (9.293 s) : 0, 9292772
Agent [candidate] (1.187 s) : 0, 1187330
Total [candidate] (9.254 s) : 0, 9253993
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1189716
Total [baseline] (9.214 s) : 0, 9213619
Agent [candidate] (1.197 s) : 0, 1197228
Total [candidate] (9.306 s) : 0, 9306300
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1200279
Total [baseline] (9.306 s) : 0, 9306280
Agent [candidate] (1.187 s) : 0, 1186767
Total [candidate] (9.304 s) : 0, 9304013
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.666 ms) : 0, 723666
BytebuddyAgent [candidate] (728.947 ms) : 0, 728947
GlobalTracer [baseline] (240.38 ms) : 0, 240380
GlobalTracer [candidate] (241.921 ms) : 0, 241921
AppSec [baseline] (56.321 ms) : 0, 56321
AppSec [candidate] (55.312 ms) : 0, 55312
Debugger [baseline] (5.229 ms) : 0, 5229
Debugger [candidate] (5.138 ms) : 0, 5138
Remote Config [baseline] (696.032 µs) : 0, 696
Remote Config [candidate] (699.629 µs) : 0, 700
Telemetry [baseline] (12.169 ms) : 0, 12169
Telemetry [candidate] (10.848 ms) : 0, 10848
section iast
BytebuddyAgent [baseline] (847.346 ms) : 0, 847346
BytebuddyAgent [candidate] (842.149 ms) : 0, 842149
GlobalTracer [baseline] (230.855 ms) : 0, 230855
GlobalTracer [candidate] (230.11 ms) : 0, 230110
IAST [baseline] (23.558 ms) : 0, 23558
IAST [candidate] (25.756 ms) : 0, 25756
AppSec [baseline] (54.824 ms) : 0, 54824
AppSec [candidate] (50.808 ms) : 0, 50808
Debugger [baseline] (4.248 ms) : 0, 4248
Debugger [candidate] (4.155 ms) : 0, 4155
Remote Config [baseline] (621.479 µs) : 0, 621
Remote Config [candidate] (600.507 µs) : 0, 601
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (8.675 ms) : 0, 8675
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.519 ms) : 0, 842519
BytebuddyAgent [candidate] (848.855 ms) : 0, 848855
GlobalTracer [baseline] (230.453 ms) : 0, 230453
GlobalTracer [candidate] (231.442 ms) : 0, 231442
IAST [baseline] (23.116 ms) : 0, 23116
IAST [candidate] (23.977 ms) : 0, 23977
AppSec [baseline] (53.337 ms) : 0, 53337
AppSec [candidate] (54.128 ms) : 0, 54128
Debugger [baseline] (4.266 ms) : 0, 4266
Debugger [candidate] (4.25 ms) : 0, 4250
Remote Config [baseline] (635.076 µs) : 0, 635
Remote Config [candidate] (621.878 µs) : 0, 622
Telemetry [baseline] (8.917 ms) : 0, 8917
Telemetry [candidate] (8.758 ms) : 0, 8758
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (851.522 ms) : 0, 851522
BytebuddyAgent [candidate] (840.362 ms) : 0, 840362
GlobalTracer [baseline] (232.162 ms) : 0, 232162
GlobalTracer [candidate] (230.623 ms) : 0, 230623
IAST [baseline] (23.488 ms) : 0, 23488
IAST [candidate] (22.422 ms) : 0, 22422
AppSec [baseline] (55.815 ms) : 0, 55815
AppSec [candidate] (56.443 ms) : 0, 56443
Debugger [baseline] (4.215 ms) : 0, 4215
Debugger [candidate] (4.194 ms) : 0, 4194
Remote Config [baseline] (632.871 µs) : 0, 633
Remote Config [candidate] (621.306 µs) : 0, 621
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.586 ms) : 0, 8586
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1362
. : milestone, 1342,
appsec (1.751 ms) : 1728, 1775
. : milestone, 1751,
appsec_no_iast (1.734 ms) : 1709, 1758
. : milestone, 1734,
code_origins (1.694 ms) : 1667, 1721
. : milestone, 1694,
iast (1.519 ms) : 1494, 1543
. : milestone, 1519,
profiling (1.528 ms) : 1504, 1551
. : milestone, 1528,
tracing (1.496 ms) : 1471, 1520
. : milestone, 1496,
section candidate
no_agent (1.367 ms) : 1348, 1386
. : milestone, 1367,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.735 ms) : 1710, 1760
. : milestone, 1735,
code_origins (1.686 ms) : 1659, 1712
. : milestone, 1686,
iast (1.527 ms) : 1502, 1551
. : milestone, 1527,
profiling (1.548 ms) : 1522, 1573
. : milestone, 1548,
tracing (1.505 ms) : 1481, 1529
. : milestone, 1505,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section baseline
no_agent (384.735 µs) : 365, 405
. : milestone, 385,
iast (517.717 µs) : 495, 540
. : milestone, 518,
iast_FULL (735.604 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (559.384 µs) : 538, 581
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (513.893 µs) : 492, 536
. : milestone, 514,
iast_INACTIVE (468.129 µs) : 447, 490
. : milestone, 468,
iast_TELEMETRY_OFF (503.873 µs) : 482, 526
. : milestone, 504,
tracing (455.691 µs) : 435, 476
. : milestone, 456,
section candidate
no_agent (383.124 µs) : 364, 403
. : milestone, 383,
iast (527.462 µs) : 504, 551
. : milestone, 527,
iast_FULL (732.69 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (564.431 µs) : 543, 586
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (520.492 µs) : 499, 542
. : milestone, 520,
iast_INACTIVE (472.193 µs) : 450, 494
. : milestone, 472,
iast_TELEMETRY_OFF (501.905 µs) : 480, 524
. : milestone, 502,
tracing (458.855 µs) : 438, 480
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.359 ms) : 2315, 2402
. : milestone, 2359,
iast (2.139 ms) : 2083, 2195
. : milestone, 2139,
iast_GLOBAL (2.177 ms) : 2121, 2233
. : milestone, 2177,
profiling (2.006 ms) : 1961, 2051
. : milestone, 2006,
tracing (1.962 ms) : 1919, 2005
. : milestone, 1962,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.355 ms) : 2312, 2399
. : milestone, 2355,
iast (2.127 ms) : 2071, 2183
. : milestone, 2127,
iast_GLOBAL (2.175 ms) : 2119, 2231
. : milestone, 2175,
profiling (1.998 ms) : 1952, 2043
. : milestone, 1998,
tracing (1.954 ms) : 1911, 1996
. : milestone, 1954,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~87b0131427, baseline=1.49.0-SNAPSHOT~22535c74a4
dateFormat X
axisFormat %s
section baseline
no_agent (15.312 s) : 15312000, 15312000
. : milestone, 15312000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.849 s) : 18849000, 18849000
. : milestone, 18849000,
iast_GLOBAL (18.116 s) : 18116000, 18116000
. : milestone, 18116000,
profiling (15.185 s) : 15185000, 15185000
. : milestone, 15185000,
tracing (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
section candidate
no_agent (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
appsec (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
iast (19.081 s) : 19081000, 19081000
. : milestone, 19081000,
iast_GLOBAL (18.023 s) : 18023000, 18023000
. : milestone, 18023000,
profiling (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
tracing (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
|
Re-associating this with PROF-11678 |
jbachorik
approved these changes
Apr 22, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Records via telemetry if the
jvmstat
module isn't found, for observability across different JVM distributionstype:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-11678