🍒 8722 - Handle reentrant scope cleanup in Akka/Pekko actor instrumentations #8723

mcculls · 2025-04-23T09:48:54Z

Backport #8722 to release/v1.48.x

…ck mechanism to clean up scopes after async operations. To properly handle reentrant scope checkpointing and rollback we need to use a count in ContinuableScope like referenceCount rather than just a flag. This is necessary because ContinuableScopeManager re-uses scope instances when activating the same span twice. (cherry picked from commit 8b77a18)

pr-commenter · 2025-04-23T10:40:35Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	stuart.mcculloch/backport-pr-8722
git_commit_date	1745391799	1745401727
git_commit_sha	`6b6cbf6`	`e42b7c8`
release_version	1.49.0-SNAPSHOT~6b6cbf6499	1.49.0-SNAPSHOT~e42b7c8643

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745404789	1745404789
ci_job_id	908276086	908276086
ci_pipeline_id	63020742	63020742
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xrqtb84m-project-304-concurrent-1-ili48qag 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xrqtb84m-project-304-concurrent-1-ili48qag 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069261
Total [baseline] (8.705 s) : 0, 8705172
Agent [candidate] (1.056 s) : 0, 1055587
Total [candidate] (8.652 s) : 0, 8651524
section iast
Agent [baseline] (1.186 s) : 0, 1186012
Total [baseline] (9.258 s) : 0, 9258424
Agent [candidate] (1.194 s) : 0, 1194439
Total [candidate] (9.286 s) : 0, 9285632
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1186371
Total [baseline] (9.201 s) : 0, 9201435
Agent [candidate] (1.185 s) : 0, 1185186
Total [candidate] (9.194 s) : 0, 9194007
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1182251
Total [baseline] (9.241 s) : 0, 9240508
Agent [candidate] (1.18 s) : 0, 1180417
Total [candidate] (9.266 s) : 0, 9265960

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.186 s	116.751 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.186 s	117.11 ms (11.0%)
Agent	iast_TELEMETRY_OFF	1.182 s	112.99 ms (10.6%)
Total	tracing	8.705 s	-
Total	iast	9.258 s	553.252 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.201 s	496.262 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.241 s	535.336 ms (6.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	iast	1.194 s	138.851 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	129.599 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.18 s	124.83 ms (11.8%)
Total	tracing	8.652 s	-
Total	iast	9.286 s	634.108 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.194 s	542.483 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.266 s	614.436 ms (7.1%)

gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (731.073 ms) : 0, 731073
BytebuddyAgent [candidate] (721.003 ms) : 0, 721003
GlobalTracer [baseline] (241.802 ms) : 0, 241802
GlobalTracer [candidate] (239.044 ms) : 0, 239044
AppSec [baseline] (55.182 ms) : 0, 55182
AppSec [candidate] (54.545 ms) : 0, 54545
Debugger [baseline] (5.9 ms) : 0, 5900
Debugger [candidate] (4.434 ms) : 0, 4434
Remote Config [baseline] (720.193 µs) : 0, 720
Remote Config [candidate] (698.465 µs) : 0, 698
Telemetry [baseline] (10.72 ms) : 0, 10720
Telemetry [candidate] (15.106 ms) : 0, 15106
section iast
BytebuddyAgent [baseline] (841.396 ms) : 0, 841396
BytebuddyAgent [candidate] (850.093 ms) : 0, 850093
GlobalTracer [baseline] (229.695 ms) : 0, 229695
GlobalTracer [candidate] (230.739 ms) : 0, 230739
AppSec [baseline] (50.698 ms) : 0, 50698
AppSec [candidate] (55.496 ms) : 0, 55496
Debugger [baseline] (4.178 ms) : 0, 4178
Debugger [candidate] (4.135 ms) : 0, 4135
Remote Config [baseline] (598.751 µs) : 0, 599
Remote Config [candidate] (608.057 µs) : 0, 608
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.82 ms) : 0, 8820
IAST [baseline] (24.998 ms) : 0, 24998
IAST [candidate] (23.602 ms) : 0, 23602
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.863 ms) : 0, 839863
BytebuddyAgent [candidate] (842.071 ms) : 0, 842071
GlobalTracer [baseline] (229.735 ms) : 0, 229735
GlobalTracer [candidate] (230.306 ms) : 0, 230306
AppSec [baseline] (53.976 ms) : 0, 53976
AppSec [candidate] (55.844 ms) : 0, 55844
Debugger [baseline] (4.29 ms) : 0, 4290
Debugger [candidate] (4.139 ms) : 0, 4139
Remote Config [baseline] (608.567 µs) : 0, 609
Remote Config [candidate] (613.39 µs) : 0, 613
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.719 ms) : 0, 8719
IAST [baseline] (24.937 ms) : 0, 24937
IAST [candidate] (22.744 ms) : 0, 22744
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.655 ms) : 0, 837655
BytebuddyAgent [candidate] (838.716 ms) : 0, 838716
GlobalTracer [baseline] (229.526 ms) : 0, 229526
GlobalTracer [candidate] (229.494 ms) : 0, 229494
AppSec [baseline] (55.751 ms) : 0, 55751
AppSec [candidate] (55.903 ms) : 0, 55903
Debugger [baseline] (4.176 ms) : 0, 4176
Debugger [candidate] (4.131 ms) : 0, 4131
Remote Config [baseline] (619.616 µs) : 0, 620
Remote Config [candidate] (595.394 µs) : 0, 595
Telemetry [baseline] (8.689 ms) : 0, 8689
Telemetry [candidate] (8.545 ms) : 0, 8545
IAST [baseline] (22.426 ms) : 0, 22426
IAST [candidate] (22.298 ms) : 0, 22298

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057039
Total [baseline] (10.475 s) : 0, 10475417
Agent [candidate] (1.069 s) : 0, 1068975
Total [candidate] (10.53 s) : 0, 10530066
section appsec
Agent [baseline] (1.2 s) : 0, 1199612
Total [baseline] (10.739 s) : 0, 10739388
Agent [candidate] (1.198 s) : 0, 1197558
Total [candidate] (10.832 s) : 0, 10831828
section iast
Agent [baseline] (1.186 s) : 0, 1186227
Total [baseline] (11.086 s) : 0, 11085976
Agent [candidate] (1.185 s) : 0, 1185358
Total [candidate] (11.015 s) : 0, 11015016
section profiling
Agent [baseline] (1.313 s) : 0, 1312715
Total [baseline] (10.912 s) : 0, 10911563
Agent [candidate] (1.322 s) : 0, 1322178
Total [candidate] (10.966 s) : 0, 10965695

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	appsec	1.2 s	142.573 ms (13.5%)
Agent	iast	1.186 s	129.188 ms (12.2%)
Agent	profiling	1.313 s	255.677 ms (24.2%)
Total	tracing	10.475 s	-
Total	appsec	10.739 s	263.971 ms (2.5%)
Total	iast	11.086 s	610.559 ms (5.8%)
Total	profiling	10.912 s	436.146 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	appsec	1.198 s	128.582 ms (12.0%)
Agent	iast	1.185 s	116.383 ms (10.9%)
Agent	profiling	1.322 s	253.203 ms (23.7%)
Total	tracing	10.53 s	-
Total	appsec	10.832 s	301.762 ms (2.9%)
Total	iast	11.015 s	484.951 ms (4.6%)
Total	profiling	10.966 s	435.629 ms (4.1%)

gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.561 ms) : 0, 721561
BytebuddyAgent [candidate] (728.966 ms) : 0, 728966
GlobalTracer [baseline] (239.183 ms) : 0, 239183
GlobalTracer [candidate] (242.64 ms) : 0, 242640
AppSec [baseline] (55.106 ms) : 0, 55106
AppSec [candidate] (55.212 ms) : 0, 55212
Debugger [baseline] (5.056 ms) : 0, 5056
Debugger [candidate] (4.463 ms) : 0, 4463
Remote Config [baseline] (691.429 µs) : 0, 691
Remote Config [candidate] (719.299 µs) : 0, 719
Telemetry [baseline] (11.993 ms) : 0, 11993
Telemetry [candidate] (16.001 ms) : 0, 16001
section appsec
BytebuddyAgent [baseline] (741.214 ms) : 0, 741214
BytebuddyAgent [candidate] (740.235 ms) : 0, 740235
GlobalTracer [baseline] (236.265 ms) : 0, 236265
GlobalTracer [candidate] (236.238 ms) : 0, 236238
AppSec [baseline] (174.579 ms) : 0, 174579
AppSec [candidate] (175.625 ms) : 0, 175625
Debugger [baseline] (4.223 ms) : 0, 4223
Debugger [candidate] (4.274 ms) : 0, 4274
Remote Config [baseline] (640.675 µs) : 0, 641
Remote Config [candidate] (648.433 µs) : 0, 648
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.998 ms) : 0, 8998
IAST [baseline] (21.719 ms) : 0, 21719
IAST [candidate] (21.348 ms) : 0, 21348
section iast
BytebuddyAgent [baseline] (840.084 ms) : 0, 840084
BytebuddyAgent [candidate] (842.257 ms) : 0, 842257
GlobalTracer [baseline] (229.526 ms) : 0, 229526
GlobalTracer [candidate] (230.138 ms) : 0, 230138
AppSec [baseline] (56.828 ms) : 0, 56828
AppSec [candidate] (56.053 ms) : 0, 56053
Debugger [baseline] (4.257 ms) : 0, 4257
Debugger [candidate] (4.137 ms) : 0, 4137
Remote Config [baseline] (614.785 µs) : 0, 615
Remote Config [candidate] (607.031 µs) : 0, 607
Telemetry [baseline] (8.733 ms) : 0, 8733
Telemetry [candidate] (8.744 ms) : 0, 8744
IAST [baseline] (22.798 ms) : 0, 22798
IAST [candidate] (22.601 ms) : 0, 22601
section profiling
ProfilingAgent [baseline] (101.61 ms) : 0, 101610
ProfilingAgent [candidate] (103.792 ms) : 0, 103792
BytebuddyAgent [baseline] (716.344 ms) : 0, 716344
BytebuddyAgent [candidate] (725.415 ms) : 0, 725415
GlobalTracer [baseline] (376.112 ms) : 0, 376112
GlobalTracer [candidate] (376.383 ms) : 0, 376383
AppSec [baseline] (54.384 ms) : 0, 54384
AppSec [candidate] (53.656 ms) : 0, 53656
Debugger [baseline] (4.412 ms) : 0, 4412
Debugger [candidate] (4.33 ms) : 0, 4330
Remote Config [baseline] (662.436 µs) : 0, 662
Remote Config [candidate] (706.24 µs) : 0, 706
Telemetry [baseline] (8.941 ms) : 0, 8941
Telemetry [candidate] (9.066 ms) : 0, 9066
Profiling [baseline] (101.634 ms) : 0, 101634
Profiling [candidate] (103.818 ms) : 0, 103818

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-04-23T10:10:07	2025-04-23T10:17:52
git_branch	master	stuart.mcculloch/backport-pr-8722
git_commit_date	1745391799	1745401727
git_commit_sha	`6b6cbf6`	`e42b7c8`
release_version	1.49.0-SNAPSHOT~6b6cbf6499	1.49.0-SNAPSHOT~e42b7c8643
start_time	2025-04-23T10:09:53	2025-04-23T10:17:37

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1745403869	1745403869
ci_job_id	908276087	908276087
ci_pipeline_id	63020742	63020742
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-smzjfe--project-304-concurrent-1-v11pigrc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-smzjfe--project-304-concurrent-1-v11pigrc 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.746 ms) : 1722, 1770
.   : milestone, 1746,
appsec_no_iast (1.723 ms) : 1699, 1746
.   : milestone, 1723,
code_origins (1.672 ms) : 1645, 1699
.   : milestone, 1672,
iast (1.519 ms) : 1495, 1544
.   : milestone, 1519,
profiling (1.518 ms) : 1494, 1541
.   : milestone, 1518,
tracing (1.491 ms) : 1467, 1515
.   : milestone, 1491,
section candidate
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.717 ms) : 1694, 1740
.   : milestone, 1717,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
code_origins (1.681 ms) : 1654, 1708
.   : milestone, 1681,
iast (1.516 ms) : 1491, 1540
.   : milestone, 1516,
profiling (1.519 ms) : 1496, 1542
.   : milestone, 1519,
tracing (1.5 ms) : 1475, 1525
.   : milestone, 1500,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.334 ms, 1.372 ms]	-
appsec	1.746 ms [1.722 ms, 1.77 ms]	393.0 µs (29.0%)
appsec_no_iast	1.723 ms [1.699 ms, 1.746 ms]	369.432 µs (27.3%)
code_origins	1.672 ms [1.645 ms, 1.699 ms]	318.665 µs (23.6%)
iast	1.519 ms [1.495 ms, 1.544 ms]	166.162 µs (12.3%)
profiling	1.518 ms [1.494 ms, 1.541 ms]	164.586 µs (12.2%)
tracing	1.491 ms [1.467 ms, 1.515 ms]	137.839 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.374 ms]	-
appsec	1.717 ms [1.694 ms, 1.74 ms]	362.53 µs (26.8%)
appsec_no_iast	1.736 ms [1.712 ms, 1.76 ms]	381.707 µs (28.2%)
code_origins	1.681 ms [1.654 ms, 1.708 ms]	326.924 µs (24.1%)
iast	1.516 ms [1.491 ms, 1.54 ms]	161.151 µs (11.9%)
profiling	1.519 ms [1.496 ms, 1.542 ms]	164.514 µs (12.1%)
tracing	1.5 ms [1.475 ms, 1.525 ms]	145.403 µs (10.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.861 µs) : 358, 398
.   : milestone, 378,
iast (510.436 µs) : 488, 532
.   : milestone, 510,
iast_FULL (732.124 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (559.144 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (514.12 µs) : 492, 536
.   : milestone, 514,
iast_INACTIVE (468.644 µs) : 446, 491
.   : milestone, 469,
iast_TELEMETRY_OFF (500.778 µs) : 479, 523
.   : milestone, 501,
tracing (455.845 µs) : 435, 477
.   : milestone, 456,
section candidate
no_agent (375.707 µs) : 356, 396
.   : milestone, 376,
iast (517.984 µs) : 496, 540
.   : milestone, 518,
iast_FULL (727.663 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (552.314 µs) : 531, 574
.   : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (517.675 µs) : 495, 540
.   : milestone, 518,
iast_INACTIVE (472.519 µs) : 451, 494
.   : milestone, 473,
iast_TELEMETRY_OFF (506.713 µs) : 485, 529
.   : milestone, 507,
tracing (462.091 µs) : 441, 484
.   : milestone, 462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.861 µs [357.519 µs, 398.202 µs]	-
iast	510.436 µs [488.459 µs, 532.414 µs]	132.576 µs (35.1%)
iast_FULL	732.124 µs [710.072 µs, 754.177 µs]	354.264 µs (93.8%)
iast_GLOBAL	559.144 µs [537.389 µs, 580.9 µs]	181.283 µs (48.0%)
iast_HARDCODED_SECRET_DISABLED	514.12 µs [492.372 µs, 535.869 µs]	136.26 µs (36.1%)
iast_INACTIVE	468.644 µs [446.436 µs, 490.851 µs]	90.783 µs (24.0%)
iast_TELEMETRY_OFF	500.778 µs [478.92 µs, 522.636 µs]	122.917 µs (32.5%)
tracing	455.845 µs [434.912 µs, 476.778 µs]	77.984 µs (20.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.707 µs [355.631 µs, 395.784 µs]	-
iast	517.984 µs [496.244 µs, 539.723 µs]	142.277 µs (37.9%)
iast_FULL	727.663 µs [705.572 µs, 749.753 µs]	351.955 µs (93.7%)
iast_GLOBAL	552.314 µs [530.689 µs, 573.939 µs]	176.607 µs (47.0%)
iast_HARDCODED_SECRET_DISABLED	517.675 µs [495.279 µs, 540.07 µs]	141.967 µs (37.8%)
iast_INACTIVE	472.519 µs [450.801 µs, 494.236 µs]	96.811 µs (25.8%)
iast_TELEMETRY_OFF	506.713 µs [484.684 µs, 528.743 µs]	131.006 µs (34.9%)
tracing	462.091 µs [440.548 µs, 483.634 µs]	86.384 µs (23.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	stuart.mcculloch/backport-pr-8722
git_commit_date	1745391799	1745401727
git_commit_sha	`6b6cbf6`	`e42b7c8`
release_version	1.49.0-SNAPSHOT~6b6cbf6499	1.49.0-SNAPSHOT~e42b7c8643

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1745404363	1745404363
ci_job_id	908276088	908276088
ci_pipeline_id	63020742	63020742
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-z7sxszqb-project-304-concurrent-1-tmkkpk6i 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-z7sxszqb-project-304-concurrent-1-tmkkpk6i 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.854 s) : 14854000, 14854000
.   : milestone, 14854000,
appsec (14.944 s) : 14944000, 14944000
.   : milestone, 14944000,
iast (19.139 s) : 19139000, 19139000
.   : milestone, 19139000,
iast_GLOBAL (17.983 s) : 17983000, 17983000
.   : milestone, 17983000,
profiling (15.82 s) : 15820000, 15820000
.   : milestone, 15820000,
tracing (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
section candidate
no_agent (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
appsec (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
iast (18.696 s) : 18696000, 18696000
.   : milestone, 18696000,
iast_GLOBAL (18.518 s) : 18518000, 18518000
.   : milestone, 18518000,
profiling (14.746 s) : 14746000, 14746000
.   : milestone, 14746000,
tracing (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.854 s [14.854 s, 14.854 s]	-
appsec	14.944 s [14.944 s, 14.944 s]	90.0 ms (0.6%)
iast	19.139 s [19.139 s, 19.139 s]	4.285 s (28.8%)
iast_GLOBAL	17.983 s [17.983 s, 17.983 s]	3.129 s (21.1%)
profiling	15.82 s [15.82 s, 15.82 s]	966.0 ms (6.5%)
tracing	15.179 s [15.179 s, 15.179 s]	325.0 ms (2.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.901 s [14.901 s, 14.901 s]	-
appsec	15.069 s [15.069 s, 15.069 s]	168.0 ms (1.1%)
iast	18.696 s [18.696 s, 18.696 s]	3.795 s (25.5%)
iast_GLOBAL	18.518 s [18.518 s, 18.518 s]	3.617 s (24.3%)
profiling	14.746 s [14.746 s, 14.746 s]	-155.0 ms (-1.0%)
tracing	15.259 s [15.259 s, 15.259 s]	358.0 ms (2.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~e42b7c8643, baseline=1.49.0-SNAPSHOT~6b6cbf6499
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.341 ms) : 2297, 2384
.   : milestone, 2341,
iast (2.138 ms) : 2081, 2194
.   : milestone, 2138,
iast_GLOBAL (2.177 ms) : 2121, 2233
.   : milestone, 2177,
profiling (2.004 ms) : 1958, 2049
.   : milestone, 2004,
tracing (1.953 ms) : 1910, 1996
.   : milestone, 1953,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.348 ms) : 2305, 2392
.   : milestone, 2348,
iast (2.128 ms) : 2072, 2184
.   : milestone, 2128,
iast_GLOBAL (2.17 ms) : 2113, 2226
.   : milestone, 2170,
profiling (1.981 ms) : 1936, 2026
.   : milestone, 1981,
tracing (1.954 ms) : 1912, 1997
.   : milestone, 1954,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.341 ms [2.297 ms, 2.384 ms]	870.105 µs (59.2%)
iast	2.138 ms [2.081 ms, 2.194 ms]	667.075 µs (45.4%)
iast_GLOBAL	2.177 ms [2.121 ms, 2.233 ms]	706.256 µs (48.0%)
profiling	2.004 ms [1.958 ms, 2.049 ms]	533.331 µs (36.3%)
tracing	1.953 ms [1.91 ms, 1.996 ms]	482.716 µs (32.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.348 ms [2.305 ms, 2.392 ms]	872.063 µs (59.1%)
iast	2.128 ms [2.072 ms, 2.184 ms]	651.552 µs (44.1%)
iast_GLOBAL	2.17 ms [2.113 ms, 2.226 ms]	693.24 µs (47.0%)
profiling	1.981 ms [1.936 ms, 2.026 ms]	505.138 µs (34.2%)
tracing	1.954 ms [1.912 ms, 1.997 ms]	478.125 µs (32.4%)

mcculls added type: bug inst: akka Akka instrumentation labels Apr 23, 2025

mcculls requested a review from a team as a code owner April 23, 2025 09:48

mcculls requested review from smola, PerfectSlayer and nikita-tkachenko-datadog April 23, 2025 09:48

PerfectSlayer approved these changes Apr 23, 2025

View reviewed changes

mcculls merged commit 5ca8aa2 into release/v1.48.x Apr 23, 2025
193 checks passed

mcculls deleted the stuart.mcculloch/backport-pr-8722 branch April 23, 2025 10:49

github-actions bot added this to the 1.48.2 milestone Apr 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🍒 8722 - Handle reentrant scope cleanup in Akka/Pekko actor instrumentations #8723

🍒 8722 - Handle reentrant scope cleanup in Akka/Pekko actor instrumentations #8723

mcculls commented Apr 23, 2025

pr-commenter bot commented Apr 23, 2025

🍒 8722 - Handle reentrant scope cleanup in Akka/Pekko actor instrumentations #8723

🍒 8722 - Handle reentrant scope cleanup in Akka/Pekko actor instrumentations #8723

Conversation

mcculls commented Apr 23, 2025

pr-commenter bot commented Apr 23, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary