Skip to content

Trace 'records(TopicPartitions)` in kafka consumer #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Trace 'records(TopicPartitions)` in kafka consumer #908

merged 1 commit into from
Jul 8, 2019

Conversation

mar-kolya
Copy link
Contributor

Unfortunately no tests

@mar-kolya mar-kolya requested a review from a team as a code owner July 8, 2019 14:37
@mar-kolya mar-kolya force-pushed the mar-kolya/kafka-trace-records branch from 48e211b to 058c4ec Compare July 8, 2019 15:20
labbati
labbati approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mar-kolya mar-kolya merged commit 2e62ca8 into master Jul 8, 2019
@mar-kolya mar-kolya deleted the mar-kolya/kafka-trace-records branch July 8, 2019 18:25
@mar-kolya mar-kolya mentioned this pull request Jul 8, 2019
Closed
@tylerbenson tylerbenson added this to the 0.31.0 milestone Jul 10, 2019
@tylerbenson
Copy link
Contributor

@mar-kolya I think this is problematic. That other method returns a List, not an Iterable, so we can't safely instrument it with the same advice (since we're wrapping the return value). I think this needs to be reverted or fixed before we can release.

@tylerbenson tylerbenson added tag: do not merge Do not merge changes tag: needs investigation Issues needing investigations labels Jul 10, 2019
@tylerbenson tylerbenson mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

Assignees
No one assigned
Labels
tag: do not merge Do not merge changes tag: needs investigation Issues needing investigations
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mar-kolya @tylerbenson @labbati