Skip to content

Commit e8c41e2

Browse files
authored
chore(profiling): remove flaky marker on test_accuracy (#13146)
Increase the error margin and remove flaky marker. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 29ab7d8 commit e8c41e2

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

tests/profiling/test_accuracy.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33

44
import pytest
55

6-
from tests.utils import flaky
7-
86

97
def spend_1():
108
time.sleep(1)
@@ -46,8 +44,8 @@ def spend_cpu_3():
4644
pass
4745

4846

49-
# We allow 5% error:
50-
TOLERANCE = 0.05
47+
# We allow 7% error:
48+
TOLERANCE = 0.07
5149

5250

5351
def assert_almost_equal(value, target, tolerance=TOLERANCE):
@@ -63,7 +61,6 @@ def total_time(time_data, funcname):
6361

6462

6563
@pytest.mark.subprocess(env=dict(DD_PROFILING_MAX_TIME_USAGE_PCT="100"))
66-
@flaky(until=1743703564, reason="3177585388 is not approximately equal to 3000000000.0 within tolerance=0.05")
6764
def test_accuracy():
6865
import collections
6966

0 commit comments

Comments
 (0)