Skip to content

chore(profiling): remove flaky marker on test_accuracy #13146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Apr 9, 2025

Increase the error margin and remove flaky marker.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 9, 2025

CODEOWNERS have been resolved as:

tests/profiling/test_accuracy.py                                        @DataDog/profiling-python

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 229 ± 2 ms.

The average import time from base is: 230 ± 1 ms.

The import time difference between this PR and base is: -1.41 ± 0.06 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.925 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.269 ms (0.56%)
ddtrace.bootstrap.preload 1.269 ms (0.56%)
ddtrace.internal.products 1.269 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.622 ms (0.27%)
ddtrace 0.656 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 9, 2025

Benchmarks

Benchmark execution time: 2025-04-09 20:12:34

Comparing candidate commit b645c02 in PR branch taegyunkim/prof-11617-flaky with baseline commit 1871f28 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 9, 2025
@taegyunkim taegyunkim marked this pull request as ready for review April 9, 2025 21:07
@taegyunkim taegyunkim requested a review from a team as a code owner April 9, 2025 21:07
@taegyunkim taegyunkim merged commit e8c41e2 into main Apr 9, 2025
290 of 293 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-11617-flaky branch April 9, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants