-
Notifications
You must be signed in to change notification settings - Fork 439
fix(botocore): inject trace context into stepfunction start_execution input #10262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(botocore): inject trace context into stepfunction start_execution input #10262
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 134619 Passed, 8927 Skipped, 5h 16m 9.27s Total duration (1m 41.61s time saved) |
BenchmarksBenchmark execution time: 2024-08-27 18:44:57 Comparing candidate commit 5fcce4f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
…p-function-start-execution
…ass the injected input object back to the patcher using context.Set/Get
…start-execution' of github.com:DataDog/dd-trace-py into chris.agocs/re-inject-trace-context-into-step-function-start-execution
…p-function-start-execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as Romain. Otherwise, this looks mergeable.
@emmettbutler Thanks! I resolved the circular dependency issue neatly, I think. |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
@emmettbutler , it looks like I still need a review from DataDog/apm-sdk-api-python. Do you know anyone who could give this a look? |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
releasenotes/notes/fix-botocore-stepfunction-patching-9993630697956278.yaml
Show resolved
Hide resolved
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
…p-function-start-execution
🚂 MergeQueue: queue is disabled Added to the queue but the mergequeue is not enabled for now. Use |
/remove |
🚂 Devflow: |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
In #7514 , I added a feature to patch start_execution calls to AWS stepfunctions and inject trace context into the input object. That feature suffered a regression in #8937 , and the whole stepfunctions integration was refactored to use the Core API in #9005 . This PR re-adds the injection of trace context into the start_execution input, and adds a few unit tests to detect the same regression in the future.
Checklist
Reviewer Checklist