Skip to content

chore(llmobs): add codeowner entries for oai_agents integration #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Apr 10, 2025

Adds codeowner entries that were accidentally omitted in #13081.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim requested review from a team as code owners April 10, 2025 22:33
@Yun-Kim Yun-Kim enabled auto-merge (squash) April 10, 2025 22:34
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 10, 2025
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 4 ms.

The average import time from base is: 239 ± 7 ms.

The import time difference between this PR and base is: -5.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.176 ms (0.93%)
ddtrace.bootstrap.sitecustomize 1.501 ms (0.64%)
ddtrace.bootstrap.preload 1.501 ms (0.64%)
ddtrace.internal.products 1.501 ms (0.64%)
ddtrace.internal.remoteconfig.client 0.706 ms (0.30%)
ddtrace 0.675 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 10, 2025

Benchmarks

Benchmark execution time: 2025-04-10 23:20:27

Comparing candidate commit 8776c0a in PR branch yunkim/codeowner-oai-agent with baseline commit dee3673 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

@Yun-Kim Yun-Kim merged commit 4d6134c into main Apr 10, 2025
683 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/codeowner-oai-agent branch April 10, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants