Skip to content

docs: fix command to ID deprecated 2.0 env vars #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Conversation

emmettbutler
Copy link
Collaborator

Internal clone of #11613

Contributed by @jblz

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner April 11, 2025 18:40
@emmettbutler emmettbutler requested a review from taegyunkim April 11, 2025 18:40
Copy link
Contributor

CODEOWNERS have been resolved as:

docs/upgrading.rst                                                      @DataDog/python-guild

@emmettbutler emmettbutler enabled auto-merge (squash) April 11, 2025 18:41
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 2 ms.

The average import time from base is: 235 ± 2 ms.

The import time difference between this PR and base is: -2.47 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.052 ms (0.88%)
ddtrace.bootstrap.sitecustomize 1.347 ms (0.58%)
ddtrace.bootstrap.preload 1.347 ms (0.58%)
ddtrace.internal.remoteconfig.client 0.670 ms (0.29%)
ddtrace 0.705 ms (0.30%)
ddtrace._logger 0.033 ms (0.01%)
logging 0.033 ms (0.01%)
traceback 0.033 ms (0.01%)
contextlib 0.033 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2025

Benchmarks

Benchmark execution time: 2025-05-21 14:22:46

Comparing candidate commit cfe8bb6 in PR branch jblz/patch-1 with baseline commit 52037dc in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 447 metrics, 8 unstable metrics.

scenario:iast_aspects-ljust_aspect

  • 🟥 execution_time [+1.213µs; +1.398µs] or [+9.370%; +10.798%]

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+731.830ns; +809.876ns] or [+17.655%; +19.538%]

scenario:iast_aspects-ospathsplitdrive_aspect

  • 🟥 execution_time [+288.426ns; +383.646ns] or [+7.934%; +10.553%]

scenario:iast_aspects-splitlines_aspect

  • 🟥 execution_time [+139.472ns; +177.761ns] or [+9.758%; +12.436%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+321.923ns; +386.760ns] or [+10.523%; +12.642%]

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 25, 2025
@emmettbutler emmettbutler merged commit 44c971a into main May 21, 2025
355 checks passed
@emmettbutler emmettbutler deleted the jblz/patch-1 branch May 21, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants