Skip to content

chore: fix stale PR closing workflow #13194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2025
Merged

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Apr 14, 2025

We have a GHA workflow to auto-close stale PRs, but it seems to not have been closing any.

Adding the missing config variable to let stale PRs (30 days old) get auto-closed after 1 day of no activity.

Successful run here.
Example PR with bot comment and close here

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/stale.yml                                             @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda marked this pull request as ready for review April 14, 2025 17:28
@erikayasuda erikayasuda requested review from a team as code owners April 14, 2025 17:28
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 14, 2025
@erikayasuda erikayasuda enabled auto-merge (squash) April 14, 2025 17:28
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 231 ± 4 ms.

The average import time from base is: 238 ± 7 ms.

The import time difference between this PR and base is: -7.1 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.447 ms (1.06%)
ddtrace.bootstrap.sitecustomize 1.659 ms (0.72%)
ddtrace.bootstrap.preload 1.659 ms (0.72%)
ddtrace.internal.products 1.659 ms (0.72%)
ddtrace.internal.remoteconfig.client 0.759 ms (0.33%)
ddtrace 0.788 ms (0.34%)
ddtrace._logger 0.111 ms (0.05%)
logging 0.096 ms (0.04%)
traceback 0.096 ms (0.04%)
contextlib 0.096 ms (0.04%)
ddtrace.internal.telemetry 0.015 ms (0.01%)
ddtrace.internal.telemetry.writer 0.015 ms (0.01%)
ddtrace.internal.telemetry.data 0.015 ms (0.01%)
ddtrace.internal.hostname 0.015 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 14, 2025

Benchmarks

Benchmark execution time: 2025-04-14 20:57:55

Comparing candidate commit 23fa7d0 in PR branch erikayasuda/fix-stale-close with baseline commit 7367467 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 400 metrics, 2 unstable metrics.

@erikayasuda erikayasuda merged commit 59df167 into main Apr 24, 2025
267 of 270 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/fix-stale-close branch April 24, 2025 20:47
brettlangdon pushed a commit that referenced this pull request May 6, 2025
We have a GHA workflow to auto-close stale PRs, but it seems to not have
been closing any.

Adding the missing config variable to let stale PRs (30 days old) get
auto-closed after 1 day of no activity.

Successful run
[here](https://github.com/DataDog/dd-trace-py/actions/runs/14451814062/job/40526057672)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants