Skip to content

fix(profiling): upgrade echion to pick up performance fixes #13230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Apr 18, 2025

This PR is to pick up following recent PRs on echion

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 18, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/prof-perf-echion-bbb657265d18148c.yaml               @DataDog/apm-python
ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt              @DataDog/profiling-python

Copy link
Contributor

github-actions bot commented Apr 18, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 231 ± 2 ms.

The average import time from base is: 234 ± 2 ms.

The import time difference between this PR and base is: -3.15 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.068 ms (0.90%)
ddtrace.bootstrap.sitecustomize 1.363 ms (0.59%)
ddtrace.bootstrap.preload 1.363 ms (0.59%)
ddtrace.internal.products 1.363 ms (0.59%)
ddtrace.internal.remoteconfig.client 0.634 ms (0.27%)
ddtrace 0.705 ms (0.31%)
ddtrace._logger 0.032 ms (0.01%)
logging 0.032 ms (0.01%)
traceback 0.032 ms (0.01%)
contextlib 0.032 ms (0.01%)

@taegyunkim taegyunkim changed the title test: use echion@cp311-312-frame-chunk test: use echion@sanchda/avoidprocfs Apr 18, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2025

Benchmarks

Benchmark execution time: 2025-04-21 13:45:42

Comparing candidate commit c2c1d3b in PR branch taegyunkim/cp311-312-frame-chunk with baseline commit 997a12e in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 481 metrics, 8 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+368.096ns; +574.808ns] or [+8.122%; +12.684%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+472.490ns; +685.947ns] or [+7.737%; +11.233%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟥 execution_time [+267.088ns; +369.518ns] or [+7.726%; +10.689%]

@taegyunkim taegyunkim changed the title test: use echion@sanchda/avoidprocfs fix(profiling): upgrade echion Apr 18, 2025
@taegyunkim taegyunkim marked this pull request as ready for review April 18, 2025 19:02
@taegyunkim taegyunkim requested review from a team as code owners April 18, 2025 19:02
@taegyunkim taegyunkim added the Profiling Continous Profling label Apr 18, 2025
@taegyunkim taegyunkim changed the title fix(profiling): upgrade echion fix(profiling): upgrade echion to pick up performance fixes Apr 18, 2025
@taegyunkim taegyunkim merged commit dcfc4ef into main Apr 21, 2025
316 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/cp311-312-frame-chunk branch April 21, 2025 13:56
brettlangdon pushed a commit that referenced this pull request May 6, 2025
This PR is to pick up following recent PRs on echion

- [perf: use cpuclockid in favor of procfs for
is_running()](P403n1x87/echion#99)
- [fix: 3.11 and 3.12 uses datastack chunk for frame address
resolution](P403n1x87/echion#105)
- [fix: set origin pointer to make stackchunk useful
again](P403n1x87/echion#106)


## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: David Sanchez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants