Skip to content

feat(contrib): add awslambdaric integration #13233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

duncanista
Copy link
Collaborator

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

proof of concept that AWS Lambda runtime can be patched
@duncanista duncanista requested review from a team as code owners April 18, 2025 17:01
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/contrib/_awslambdaric.py                                        @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/awslambdaric/__init__.py                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/awslambdaric/patch.py                          @DataDog/apm-core-python @DataDog/apm-idm-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 231 ± 2 ms.

The average import time from base is: 233 ± 2 ms.

The import time difference between this PR and base is: -1.95 ± 0.08 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.959 ms (0.85%)
ddtrace.bootstrap.sitecustomize 1.289 ms (0.56%)
ddtrace.bootstrap.preload 1.289 ms (0.56%)
ddtrace.internal.products 1.289 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.610 ms (0.26%)
ddtrace 0.670 ms (0.29%)

@emmettbutler emmettbutler marked this pull request as draft April 18, 2025 17:56
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2025

Benchmarks

Benchmark execution time: 2025-04-18 18:27:33

Comparing candidate commit 252984e in PR branch jordan.gonzalez/contrib/awslambdaric with baseline commit 002e5f9 in branch main.

Found 5 performance improvements and 1 performance regressions! Performance is the same for 492 metrics, 2 unstable metrics.

scenario:ddtracerun-auto_profiling

  • 🟥 execution_time [+171.745ms; +175.284ms] or [+26.215%; +26.755%]

scenario:otelspan-start-finish

  • 🟩 execution_time [-18.758ms; -18.405ms] or [-23.781%; -23.334%]

scenario:otelspan-start-finish-telemetry

  • 🟩 execution_time [-18.905ms; -18.444ms] or [-23.503%; -22.930%]

scenario:span-start-finish

  • 🟩 execution_time [-15.874ms; -15.432ms] or [-33.093%; -32.170%]

scenario:span-start-finish-telemetry

  • 🟩 execution_time [-15.923ms; -15.505ms] or [-32.340%; -31.492%]

scenario:span-start-finish-traceid128

  • 🟩 execution_time [-18.491ms; -18.108ms] or [-36.070%; -35.323%]

@github-actions github-actions bot added the stale label May 19, 2025
Copy link
Contributor

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant