Skip to content

Make EntitySet<T> implement IAsyncEnumerable<T> so that we can use ToListAsync() on EntitySet<T> #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

axmty
Copy link

@axmty axmty commented Aug 2, 2024

#394

In previous version of DataObjects, we could use AsAsync() on both IQueryable and EntitySet.
Now that AsAsync() has been removed, we expect ToListAsync() to work for both IQueryable and EntitySet types, but there is a runtime error since EntitySet does not implement IAsyncEnumerable.

@alex-kulakov
Copy link
Contributor

alex-kulakov commented Dec 24, 2024

I'm rejecting this PR. The idea is good, but many things haven't implemented to EntitySets be fully functional, the collection uses many APIs which also have to support async operations and it is hard to implement for someone outside the team.

Since root idea was to be able to use certain extensions with EntitySets, I just improved compatibility of those extensions with EntitySets (PR #413), which is way simpler than implementing full support of IAsyncEnumerable by EntitySet itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants