Skip to content

Cleanup and add new test cases #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Cleanup and add new test cases #1

merged 1 commit into from
Apr 16, 2025

Conversation

ardaatahan
Copy link

This PR:

  • Improves the incomplete download logic by downloading first to the cache directory then moves complete downloads to their final locations. This decreases swift-transformers' download logic parity with the huggingface_hub library as laid out here.
  • Adds two test cases to verify functionality.

@ardaatahan ardaatahan mentioned this pull request Apr 16, 2025
Open
@DePasqualeOrg DePasqualeOrg merged commit 94032f4 into DePasqualeOrg:improve-resumable-downloads Apr 16, 2025
DePasqualeOrg added a commit that referenced this pull request Apr 16, 2025
@DePasqualeOrg
Revert "Merge pull request #1 from ardaatahan/improve-resumable-downl…
1c15633 
…oads"

This reverts commit 94032f4, reversing
changes made to ba49d2f.
DePasqualeOrg added a commit that referenced this pull request Apr 16, 2025
@DePasqualeOrg
Revert "Merge pull request #1 from ardaatahan/improve-resumable-downl…
92303cb 
…oads"

This reverts commit 94032f4, reversing
changes made to ba49d2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachNagengast ZachNagengast ZachNagengast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaatahan @ZachNagengast @DePasqualeOrg