Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Arabic translations #148

Merged

Conversation

EliasAfara
Copy link
Contributor

Summary

Added Arabic translations

Reference #48

Type of change

  • New feature (added a non-breaking change which adds functionality)

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ytcards ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 4:35pm

ar:
direction: rtl
view: "1 مشاهدة"
views: "%{number} مشاهدات"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It seems like the YouTube interface uses مشاهدة for multiple views, do you know what the difference might be?

Screenshot_20231105-075051~2.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YouTube in English and Arabic formats view counts differently. In English, YouTube uses abbreviations like "M" for millions and "k" for thousands to make large numbers more concise and readable, as shown below:

  • 5.6M views (5.6 million views)
  • 12k views (12 thousand views)

This format is common in English and helps users quickly grasp the magnitude of view counts without reading all the digits.

On the other hand, in Arabic, YouTube uses the full form of numbers without such abbreviations, making it slightly longer but still clear and easily understandable for Arabic-speaking users, as seen in these examples:

  • 236 ألف مشاهدة (236 thousand views)
  • 1.1 مليون مشاهدة (1.1 million views)

The difference in formatting view counts between English and Arabic on YouTube is not limited to numeric representation. In Arabic, "مشاهدة" (singular form) is used consistently in all cases, regardless of the number of views. This choice is made for consistency and simplicity in the user interface, as Arabic has different forms for singular, dual, and plural quantities, and matching them with numbers in different ranges can be complex. Using the singular form ensures a clear and straightforward presentation of view counts for Arabic-speaking users, maintaining a consistent user experience.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So which do you think is better?

This is what we currently have it looking like with your translation:

https://ytcards-git-fork-eliasafara-yt-cards-arabic-10c6e6-denvercoder1.vercel.app/?id=6u9BrDaSHJc&title=Automatically+Deploy+to+Fly.io+with+GitHub+Actions&lang=ar&timestamp=1661889604&background_color=%230d1117&title_color=%23ffffff&stats_color=%23dedede&width=250&border_radius=5&duration=312&max_title_lines=1

Do you think Google has it right and it should be changed to be consistent, or do you think the way it is is better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change it

ar:
  direction: rtl
  view: "1 مشاهدة"
  views: "%{number} مشاهدة"

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit f5c6340 into DenverCoder1:main Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants