feat: i18n for card text and French translation

[Vyvy-vi]

Summary

This PR adds the python-i18n module to handle localisations for the users and an optional parameter lang to the API query parameters, which can be used to set a user's locale. This PR only adds translations for en-us and fr for now. For the rest, should they be crowd-sourced via a mono-issue worked on by multiple users, or should they be included within the scope of this PR?

Type of change

• New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

• Added or updated test cases to test new features

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ytcards	✅ Ready (Inspect)	Visit Preview	Oct 14, 2022 at 4:25AM (UTC)

[DenverCoder1]

This looks like a great solution 👍

For the Vercel deployment and automated tests to work, the dependencies should also be added to the requirements.txt. I think that's why the preview isn't working. (eg. python-i18n[yaml]==0.3.9). It may need to go in the tox.ini as well.

At some point (probably in another PR) it may be a good idea to try consolidating these to avoid repetition. Vercel doesn't work with poetry too well from what I've seen.

[DenverCoder1]

The way it is isn't bad, but it may nice to take advantage of pluralization groupings in the i18n lib. If we use keys for one and many, the same key can be used by passing count=1 for singular or count greater than 1 for plural.

I also think it's fine to get rid of the "just now" case from the relative time function to simplify things and just go straight to "x seconds ago" instead.

eg.

en-us:
  views: "%{number} views"
  seconds-ago:
    one: "1 second ago"
    many: "%{count} seconds ago"
  minutes-ago:
    one: "1 minute ago"
    many: "%{count} minutes ago"
  hours-ago:
    one: "1 hour ago"
    many: "%{count} hours ago"
  days-ago:
    one: "1 day ago"
    many: "%{count} days ago"
  months-ago:
    one: "1 month ago"
    many: "%{count} months ago"
  years-ago:
    one: "1 year ago"
    many: "%{count} years ago"

fr:
  views: "%{number} vues"
  seconds-ago:
    one: "il y a 1 seconde"
    many: "il y a %{count} secondes"
  minutes-ago:
    one: "il y a 1 minute"
    many: "il y a %{count} minutes"
  hours-ago:
    one: "il y a 1 heure"
    many: "il y a %{count} heures"
  days-ago:
    one: "il y a 1 jour"
    many: "il y a %{count} jours"
  months-ago:
    one: "il y a 1 mois"
    many: "il y a %{count} mois"
  years-ago:
    one: "il y a 1 an"
    many: "il y a %{count} ans"

[Vyvy-vi]

That should make things neater 👍

[DenverCoder1]

Looks great, thanks for the progress. Just a few more things to look into.

[DenverCoder1]

A few small things

[DenverCoder1]

I added some test cases, with the fixes suggested above, they should pass.

(Btw, in case you didn't know, suggestions can be committed in the GitHub UI from the "Commit suggestion" dropdown button. Just letting you know since it looks like you've been committing all the changes manually.)

[DenverCoder1]

Looks great! Thanks for the contribution 🎉

Anything else you want to add before I merge?

[Vyvy-vi]

I added some steps to contribute. They would probably need to be refined a bit but should be good for now.

[DenverCoder1]

Thanks again for the contribution!