Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Indonesian Translations to YouTube Cards #51

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

anonimak
Copy link
Contributor

@anonimak anonimak commented Oct 14, 2022

Summary

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Added or updated test cases to test new features

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ytcards ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 6:49AM (UTC)

@DenverCoder1
Copy link
Owner

Thanks for contributing 🎉

I'm noticing that the Bahasa Indonesia translation on YouTube for views seems to be "ditonton" which is slightly different than your translation "dilihat".

image

I'm sure you are familiar with the language enough to decide which of these translations would be better.

Let me know what you think.

@anonimak
Copy link
Contributor Author

You're right, "ditonton" more suitable word in my opinion too,
lemme quick fix

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title feat: Indonesia Translations to YouTube Cards #48 feat: Added Indonesian Translations to YouTube Cards Oct 14, 2022
@DenverCoder1 DenverCoder1 merged commit c1db1d6 into DenverCoder1:main Oct 14, 2022
@anonimak anonimak deleted the anonimak branch October 14, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants